Skip to content

evidence(OMN-14326): OCC companion for omnimarket PR 1707 - #3845

Merged
jonahgabriel merged 2 commits into
devfrom
jonah/omn-14326-occ-market-1707
Jul 10, 2026
Merged

jonahgabriel merged 2 commits into
devfrom
jonah/omn-14326-occ-market-1707

Conversation

@jonahgabriel

Copy link
Copy Markdown
Contributor

Summary

Net-new OCC companion providing the Evidence-Source durable receipt for omnimarket PR #1707 (OMN-14326 — two pure COMPUTE codegen-analysis nodes: node_ast_node_analyzer + node_stub_detector).

Authored by an independent adversarial verifier who did NOT implement the product PR (the builder died on the session limit after opening #1707), per no-self-authored-evidence (OMN-14055).

Independent verification (product head f6e379329894d7d57383f924463a72367b2dc1e3)

  • Tests: node_ast_node_analyzer + node_stub_detector protocol suites pass 34/34 (18 + 16).
  • Mutation-discrimination (each mutation reverted, worktree left clean): four semantic mutations across the two handlers were each caught RED — analyzer HTTP-detection disabled → 2 fail; analyzer mixin-extraction disabled → 1 fail; stub-detector marker guard inverted → 10 fail; stub-detector NotImplementedError changed from AST-Raise-node to naive substring → the string-literal false-positive test failed by flagging method describe. The suites are behavior-discriminating, not vacuous.
  • COMPUTE purity: neither handler performs file/network I/O. The AST analyzer parses request.source_text — it never reads a file path (the module-name and open(/Path( constants are detection needles matched against the analyzed source, not imports/calls); the stub detector uses in-memory io.StringIO + tokenize only. No Plugin* base and no cross-node imports (each node imports only its own models).
  • Gates: ruff check clean, ruff format --check clean (13 files), mypy --strict clean (13 source files), runtime import-check clean (352 entry points, both new nodes registered), node metadata dependency scope PASS.
  • pyproject delta: two onex.nodes entry-point registration lines only — no new third-party dependency.
  • CI state on evidence(OMN-11827): bind OCC receipt sha #1707: the only real red is occ-preflight / eligibility (missing 'Evidence-Source:' line); the additional red gates (OCC Preflight Dependency, Hostile Review Gate, Omni Standards Gate, PR Arch Review Gate, CI Summary) are pure downstream cascades that fail-fast on occ-preflight=failure. No independent product/test failure.

Files

  • contracts/OMN-14326.yaml — 3 dod_evidence items (dod-001, dod-deploy-assessment, dod-occ-self).
  • drift/dod_receipts/OMN-14326/{dod-001,dod-deploy-assessment,dod-occ-self}/command.yaml.

Self-binds deterministically via the first commit SHA (e87b7c64638a29a40d1c01fb8d59395a78b03035) — no PR-number prediction. contract_sha256 computed after yamlfmt (sha256:38e77d8c…).

Evidence-Ticket: OMN-14326

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 16 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 65088b64-46f6-4410-ae31-f1415137db12

📥 Commits

Reviewing files that changed from the base of the PR and between cd3574a and 758e8fb.

📒 Files selected for processing (4)
  • contracts/OMN-14326.yaml
  • drift/dod_receipts/OMN-14326/dod-001/command.yaml
  • drift/dod_receipts/OMN-14326/dod-deploy-assessment/command.yaml
  • drift/dod_receipts/OMN-14326/dod-occ-self/command.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-14326-occ-market-1707

Comment @coderabbitai help to get the list of available commands.

@jonahgabriel
jonahgabriel merged commit 7945550 into dev Jul 10, 2026
44 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-14326-occ-market-1707 branch July 10, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant