Skip to content

evidence(OMN-13990): bind omnimarket PR 1647 companion - #3727

Closed
jonahgabriel wants to merge 2 commits into
devfrom
jonah/omn-13990-omnimarket-pr-1647-occ-companion
Closed

jonahgabriel wants to merge 2 commits into
devfrom
jonah/omn-13990-omnimarket-pr-1647-occ-companion

Conversation

@jonahgabriel

Copy link
Copy Markdown
Contributor

Evidence-Source companion for omnimarket#1647.\n\nSummary:\n- Adds/refreshes OMN-13990 central evidence for omnimarket PR #1647.\n- Binds receipt to omnimarket#1647 head SHA 4af42f1f677242611f79f3d515d8c7046a6683ab.\n- Preserves existing OMN-13990 receipt rebindings already staged in this worktree.\n\nValidation:\n- uv run python -m omnibase_core.validation.validator_occ_merge_eligibility --repo OmniNode-ai/omnimarket --pr-number 1647 ... --contracts-dir contracts --receipts-dir drift/dod_receipts -> eligible true\n- uv run python -m omnibase_core.validation.validator_receipt_honesty --receipts-dir drift/dod_receipts drift/dod_receipts/OMN-13990/dod-OmniNode-ai-omnimarket-pr-1647/command.yaml\n- pre-commit via git commit: contract validation, receipt honesty, receipt hardening, skip-token all passed\n\nCites OMN-13990.

@coderabbitai

coderabbitai Bot commented Jul 8, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 12 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 16810d12-70ac-4ce1-990e-abdcad41fb6e

📥 Commits

Reviewing files that changed from the base of the PR and between 5322f51 and 87b2686.

📒 Files selected for processing (3)
  • contracts/OMN-13990.yaml
  • drift/dod_receipts/OMN-13990/dod-OmniNode-ai-omnimarket-pr-1647/command.yaml
  • drift/dod_receipts/OMN-13990/occ-self-bind-pr-3727/command.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-13990-omnimarket-pr-1647-occ-companion

Comment @coderabbitai help to get the list of available commands.

@jonahgabriel
jonahgabriel force-pushed the jonah/omn-13990-omnimarket-pr-1647-occ-companion branch from e3759f6 to 9fb6965 Compare July 8, 2026 21:31
@jonahgabriel
jonahgabriel force-pushed the jonah/omn-13990-omnimarket-pr-1647-occ-companion branch from 1848053 to 87b2686 Compare July 8, 2026 21:35
@jonahgabriel

Copy link
Copy Markdown
Contributor Author

Superseded: OCC PR #3726 (merged 2026-07-08T21:35:40Z) independently authored and merged a companion binding OMN-13990 to omnimarket#1647 (dod-omnimarket-pr-1647, pr_number: 1647) before this PR could merge. omnimarket#1647's body Evidence-Source now cites OCC#3726, and its occ-preflight/eligibility + verify/verify checks are green against that binding. Closing this PR to avoid duplicate permanent (append-only) evidence for the same ticket/PR pair — no code or unique evidence value remains here.

jonahgabriel added a commit that referenced this pull request Sep 17, 2026
Four product PRs now land under OMN-18601 -- omninode_infra #1536, #1543 and
#1547, plus omnibase_infra #3727 (the v0.38.31 cut that unblocks the
promotion's parity gate) -- so the autobinder has authored
contracts/OMN-18601.yaml repeatedly and this companion went DIRTY when dev
gained the #3727 entries.

Resolved as an APPEND-ONLY structural union, per the recorded resolution for
this collision class and identically to the earlier OMN-18582 case:

* dev's file text is kept VERBATIM -- no yaml re-dump, which mangles quoting
  and unicode and can trip the yamlfmt contamination ratchet;
* the two identifiers dev lacks are spliced in as exact byte blocks:
  dod-OmniNode-ai-omninode_infra-pr-1547 and occ-self-bind-pr-10102;
* the seven identifiers present on BOTH sides are kept once from dev, because
  a duplicate id is a contract-shape risk and dev's copy is the one existing
  receipts are hashed against.

Asserted by the splice rather than by eye: no duplicate identifier in the
result, and every unique identifier from both sides survives. Eleven entries
in, eleven out.

VERIFIED with the real validator rather than by inspection: every receipt
under drift/dod_receipts/OMN-18601/ that declares a contract_entry_sha256
recomputes equal to it against the union -- 11 matches, 0 mismatches. That is
the control for this resolution: validation is entry-hash-first, so appending
entries cannot invalidate an existing receipt, and a union that moves no entry
hash should rebind nothing.

Refs: OMN-18601
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant