evidence(OMN-12409): OCC contract + receipts for EFFECT result_applier fix

[jonahgabriel]

OMN-12409 — EFFECT result_applier wiring gap

Central OCC evidence for omnibase_infra PR #2086.

Problem fixed

EFFECT and REDUCER nodes whose handlers return a model destined for a published_events topic had their output silently dropped. The kernel's auto-wiring path only registered result_applier for a hard-coded set of ORCHESTRATOR contracts.

Fix (infra PR #2086)

After filtered_manifest is built in service_kernel.py, scan every contract. For each contract with a non-empty published_events map not already in auto_wiring_result_appliers, build a DispatchResultApplier from the contract's discovered contract_path. ORCHESTRATOR pre-registrations are not overwritten.

Evidence

• contracts/OMN-12409.yaml (validated by hook)
• dod-omnibase-infra-pr-2086: PR ci(OMN-12574): port boundary clone retry to main #2086 carries the fix
• dod-unit-tests-pass: 7 unit+integration tests pass
• dod-deploy-runtime-wiring: deploy required post-merge for wiring to take effect
• dod-occ-pr-self: OCC self-binding receipt (pr_number: 2985)

Evidence-Ticket: OMN-12409

Summary by CodeRabbit

Release Notes

• Bug Fixes

  • Fixed a runtime auto-wiring issue affecting effect and reducer handlers that return results.

• Tests

  • Added 7 unit and integration tests with verified passing status.

• Documentation

  • Added contract evidence manifest and verification receipts documenting the fix.

[coderabbitai]

📝 Walkthrough

Walkthrough

Adds the change-control contract manifest contracts/OMN-12409.yaml for ticket OMN-12409, documenting the missing result_applier wiring for EFFECT/REDUCER contracts and the service_kernel.py manifest-scan fix. Four DOD receipt command.yaml files are added under drift/dod_receipts/OMN-12409/ recording PASS outcomes.

Changes

OMN-12409 Change Control Artifact

Layer / File(s)	Summary
Contract manifest: problem definition and DOD criteria contracts/OMN-12409.yaml	Defines ticket metadata, bug summary (missing result_applier for EFFECT/REDUCER contracts), evidence requirements with the exact pytest command, emergency_bypass disabled, and dod_evidence entries with grep-based PASS checks referencing each receipt file.
DOD receipts: PASS evidence drift/dod_receipts/OMN-12409/dod-unit-tests-pass/command.yaml, drift/dod_receipts/OMN-12409/dod-omnibase-infra-pr-2086/command.yaml, drift/dod_receipts/OMN-12409/dod-deploy-runtime-wiring/command.yaml, drift/dod_receipts/OMN-12409/dod-occ-pr-self/command.yaml	Four receipts capturing PASS outcomes for: 7 unit tests passing, omnibase-infra PR-2086 containing the service_kernel.py manifest-scan fix, runtime wiring deploy narrative, and OCC self-binding check — each with commit/branch/PR context and exit_code: 0.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐇 A manifest born, the gap now filled,
EFFECT and REDUCER, their appliers willed.
Seven tests passed, the receipts say PASS,
The kernel scans onward through manifest's glass.
✅ Hop hop, the DOD is complete at last!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: adding OCC contract and receipts documenting a fix for EFFECT result_applier wiring in OMN-12409.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch jonah/occ-omn-12409-effect-result-applier

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

drift/dod_receipts/OMN-12409/dod-unit-tests-pass/command.yaml (1)

6-7: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

Consider tightening the grep pattern for test results.

The current pattern grep -q 'passed' is permissive and could match output like "7 failed, 1 passed" or even "passed" in error messages. Consider using grep -q '7 passed' to ensure all expected tests passed.

♻️ Suggested improvement

-check_value: "uv run pytest tests/unit/runtime/test_effect_result_applier_wiring.py -q 2>&1 | grep -q
-  'passed'"
+check_value: "uv run pytest tests/unit/runtime/test_effect_result_applier_wiring.py -q 2>&1 | grep -q
+  '7 passed'"

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@drift/dod_receipts/OMN-12409/dod-unit-tests-pass/command.yaml` around lines 6
- 7, The grep pattern in the check_value field uses a permissive match for
'passed' which could incorrectly pass when there are failed tests mixed in the
output (e.g., "7 failed, 1 passed"). Tighten the grep pattern to specifically
check for the exact expected test count, such as changing the pattern from grep
-q 'passed' to grep -q '7 passed' to ensure all tests actually passed and no
failures occurred.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@drift/dod_receipts/OMN-12409/dod-unit-tests-pass/command.yaml`:
- Around line 11-13: In the command.yaml file, update the commit_sha field from
its current value "5ff13e180" to the correct head commit sha of PR `#2086` which
is "e721252cf43065d6f645a53634ca5a075444809a" (or the abbreviated form
"e721252cf"). Keep the branch name and pr_number unchanged as they are already
correct.

---

Nitpick comments:
In `@drift/dod_receipts/OMN-12409/dod-unit-tests-pass/command.yaml`:
- Around line 6-7: The grep pattern in the check_value field uses a permissive
match for 'passed' which could incorrectly pass when there are failed tests
mixed in the output (e.g., "7 failed, 1 passed"). Tighten the grep pattern to
specifically check for the exact expected test count, such as changing the
pattern from grep -q 'passed' to grep -q '7 passed' to ensure all tests actually
passed and no failures occurred.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7128a4c4-fc38-436c-ada4-64475a0d72cb

📥 Commits

Reviewing files that changed from the base of the PR and between 88da36e and 845d4c6.

📒 Files selected for processing (5)

• contracts/OMN-12409.yaml
• drift/dod_receipts/OMN-12409/dod-deploy-runtime-wiring/command.yaml
• drift/dod_receipts/OMN-12409/dod-occ-pr-self/command.yaml
• drift/dod_receipts/OMN-12409/dod-omnibase-infra-pr-2086/command.yaml
• drift/dod_receipts/OMN-12409/dod-unit-tests-pass/command.yaml