Repository navigation
evidence(OMN-13371): add delegation quality gate contract receipts - #2833
Merged
Merged
Conversation
📝 WalkthroughWalkthroughAdds the OMN-13371 contract file declaring the quality-gate-result model alignment fix with interface changes, plus four DoD receipt files under ChangesOMN-13371 Contract and DoD Evidence
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@contracts/OMN-13371.yaml`:
- Line 12: In the contracts/OMN-13371.yaml file, change the `is_seam_ticket`
field value from `true` to `false`. This PR addresses existing DTO drift by
aligning the quality gate result contract between the reducer and orchestrator,
which is a bug fix rather than a new architectural boundary, so the seam ticket
flag should be disabled accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 2a3b8ce0-d102-4d8a-8443-3b614890d77f
📒 Files selected for processing (4)
contracts/OMN-13371.yamldrift/dod_receipts/OMN-13371/dod-dev-e2e-blocker-deploy/command.yamldrift/dod_receipts/OMN-13371/dod-focused-tests/command.yamldrift/dod_receipts/OMN-13371/dod-omnimarket-pr-1300/command.yaml
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@drift/dod_receipts/OMN-13371/dod-occ-pr-self/command.yaml`:
- Line 12: Replace the concrete commit_sha value in the command.yaml file
located at drift/dod_receipts/OMN-13371/dod-occ-pr-self/ with an all-zero
placeholder. The commit_sha field should remain as all zeros until the OCC PR
merge commit exists, as this maintains the intended self-binding provenance
model. After the OCC PR is merged, the concrete authoring SHA can be populated
in its place.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: a367dc37-6e94-466d-8bd0-f8add677b9e1
📒 Files selected for processing (5)
contracts/OMN-13371.yamldrift/dod_receipts/OMN-13371/dod-dev-e2e-blocker-deploy/command.yamldrift/dod_receipts/OMN-13371/dod-focused-tests/command.yamldrift/dod_receipts/OMN-13371/dod-occ-pr-self/command.yamldrift/dod_receipts/OMN-13371/dod-omnimarket-pr-1300/command.yaml
✅ Files skipped from review due to trivial changes (3)
- drift/dod_receipts/OMN-13371/dod-dev-e2e-blocker-deploy/command.yaml
- drift/dod_receipts/OMN-13371/dod-omnimarket-pr-1300/command.yaml
- drift/dod_receipts/OMN-13371/dod-focused-tests/command.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
- contracts/OMN-13371.yaml
jonahgabriel
added this pull request to the merge queue
Jun 20, 2026
This was referenced Jun 23, 2026
jonahgabriel
added a commit
that referenced
this pull request
Aug 21, 2026
…6351 contract Resolves an add/add conflict on contracts/OMN-16351.yaml. Both lanes legitimately own that path: contracts/<TICKET>.yaml is per-TICKET, not per-PR, and two omnibase_infra PRs carry OMN-16351. #2833 chore: bump dev to 0.38.8 after the v0.38.7 publish (release-identity gate root fix) — autobound by node_occ_companion_compute as OCC#6830, already merged to dev (entries 1-3). #2832 fix: backmerge the main lineage into dev so main becomes an ancestor of dev and the OMN-16289 release-synced-main fast-forward can succeed — hand-authored here (entries 4-8), because OCC autobind correctly declined it: #2832 changes zero files, so no changed-file candidate can be proven RED and a bare PR-existence probe would be non-falsifiable (OMN-15247). Resolution is a UNION, not a takeover. The other lane's three entries and all three of their receipts are left byte-untouched; only the five #2832 entries are (re)bound to the new contract_sha256. Prior-entry receipts retaining an older contract_sha256 is the documented consequence of the OMN-13888 append design — contract_entry_sha256 is the per-entry binding precisely so appending entry N+1 does not invalidate entries 1..N. Verified: the hardening gate passes on all eight receipts. Also carried here, needed because dev added COMMIT_SHA_EXISTS (OMN-15461) after this branch was cut: - the self-bind receipt's commit_sha is a PUSHED OCC commit (f8f3709), so it resolves same-repo rather than relying on a cross-repo lookup; - actual_output on the cross-repo receipts now also cites repos/OmniNode-ai/omnibase_infra, so the repo hint is recoverable from check_value, probe_command AND actual_output rather than one field. Confirmed locally: _commit_sha_resolves() returns True for all eight receipts, with hints OmniNode-ai/omnibase_infra (six) and OmniNode-ai/onex_change_control (two).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds central OCC contract and PASS receipts for OMN-13371 / omnimarket PR #1300. This evidence covers the live dev e2e blocker, the contract-alignment implementation PR, focused local tests, and the OCC self-binding receipt required for merge eligibility.
Evidence
contracts/OMN-13371.yamldod-omnimarket-pr-1300dod-focused-testsdod-dev-e2e-blocker-deploydod-occ-pr-selfVerification
uv run validate-yaml contracts/OMN-13371.yaml-> passuv run pre-commit run --files contracts/OMN-13371.yaml drift/dod_receipts/OMN-13371/dod-omnimarket-pr-1300/command.yaml drift/dod_receipts/OMN-13371/dod-focused-tests/command.yaml drift/dod_receipts/OMN-13371/dod-dev-e2e-blocker-deploy/command.yaml drift/dod_receipts/OMN-13371/dod-occ-pr-self/command.yaml-> passLive Dev Status
The current live dev probe proved the pre-fix blocker: routing, inference, and quality-gate result production succeeded, then
omnibase-infra.quality-gate-resultwas DLQed before terminal emission. Terminal-event and projection-row success are post-merge acceptance criteria for omnimarket PR #1300 and are not claimed by this OCC PR.Evidence-Source: ec8ef96
Evidence-Ticket: OMN-13371
Summary by CodeRabbit
Bug Fixes / Improvements
Tests
Chores