Repository navigation
evidence(OMN-13097): re-bind OCC receipts to gap-skill follow-up PRs - #2823
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughThe OMN-13097 contract is updated to expect 21 skill tests (up from 20) and gains a new ChangesOMN-13097 DoD contract and receipts update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Fix the OCC PR's own OCC eligibility (pr_ticket_mismatch on PR #2823) and keep omnimarket #1292 bound. Distribute three of the five PASS receipts across the three citing PRs so each has a PR-bound PASS receipt: - dod-skill-tests -> omnibase_infra #2045 (commit 014fa5e5) - dod-mypy-strict -> omnimarket #1292 (commit b0762f65; mypy --strict clean on node_gap_compute, 7 source files) - dod-occ-pr-self -> onex_change_control #2823 self-binding (commit 75e0c34) Contract unchanged (sha256:3f321090...); all receipts keep matching contract_sha256; verifier != runner. Local proof: validator_occ_merge_eligibility eligible=true for #2045, #1292, and #2823.
The gap-skill follow-up PRs (omnibase_infra #2045 register gap->node_gap_compute CLI mapping; omnimarket #1292 declare node_gap_compute operation_match operation) cite OMN-13097 but the existing OMN-13097 OCC receipts bound to the original implementation PRs, so validator_occ_merge_eligibility reported pr_ticket_mismatch ('no PASS receipt ... binds to PR #2045/#1292'). Re-bind two of the five PASS receipts to the new PR commit SHAs so each PR has a PR-bound PASS receipt (eligibility requires >=1 bound receipt per ticket per PR): - dod-skill-tests -> omnibase_infra #2045 (commit 014fa5e5; test_cli_skill.py 21 passed, 1 skipped after registering the gap mapping) - dod-occ-pr-self -> omnimarket #1292 (commit b0762f65; OMN-13097 contract validates against ModelTicketContract) Contract OMN-13097.yaml is unchanged (hash sha256:3f321090...); all five receipts keep matching contract_sha256. verifier (receipt-gate-local) != runner (omn-13097-gap-skill-impl), so no self-attestation. Local proof: validator_occ_merge_eligibility eligible=true for both PRs; validator_receipt_gate_cli RECEIPT GATE PASSED (5 checks) for both repos.
Fix the OCC PR's own OCC eligibility (pr_ticket_mismatch on PR #2823) and keep omnimarket #1292 bound. Distribute three of the five PASS receipts across the three citing PRs so each has a PR-bound PASS receipt: - dod-skill-tests -> omnibase_infra #2045 (commit 014fa5e5) - dod-mypy-strict -> omnimarket #1292 (commit b0762f65; mypy --strict clean on node_gap_compute, 7 source files) - dod-occ-pr-self -> onex_change_control #2823 self-binding (commit 75e0c34) Contract unchanged (sha256:3f321090...); all receipts keep matching contract_sha256; verifier != runner. Local proof: validator_occ_merge_eligibility eligible=true for #2045, #1292, and #2823.
a66db79 to
3a4843e
Compare
Summary
Refreshes the OMN-13097 OCC receipts that unblock the gap-skill follow-up PRs.
The product PRs cite OMN-13097 and require PASS receipts bound to their current
heads, including omnimarket #1292 after its latest CI nudge commit.
Paired downstream PRs:
gap->node_gap_computeCLI mappingoperation: gapon thenode_gap_computeoperation_matchhandlerChanges
drift/dod_receipts/OMN-13097/dod-skill-tests/command.yaml: bound toomnibase_infra evidence(OMN-12570): DoD receipts for orchestrator phase separation #2045; probe =
test_cli_skill.py21 passed, 1 skipped.drift/dod_receipts/OMN-13097/dod-mypy-strict/command.yaml: bound toomnimarket evidence(OMN-11350): bind infra topic startup noise proof #1292 head
380a5ce; probe = node_gap_compute mypy strict pass.drift/dod_receipts/OMN-13097/dod-deploy-user-gated/command.yaml: bound toomnimarket evidence(OMN-11350): bind infra topic startup noise proof #1292 head
380a5ce; probe = deploy gate is user-gated and no liveruntime mutation occurred.
dod_evidence
Local proof from this worktree:
uv run validate-yaml contracts/OMN-13097.yamlpre-commit run --files contracts/OMN-13097.yaml drift/dod_receipts/OMN-13097/dod-mypy-strict/command.yaml drift/dod_receipts/OMN-13097/dod-deploy-user-gated/command.yamluv run python scripts/ci/run_contract_compliance_check.py --pr 2823 --repo OmniNode-ai/onex_change_control --contracts-dir contracts=>OMN-13097: 6/6 PASSEvidence-Source: OCC#2823
Evidence-Ticket: OMN-13097
Summary by CodeRabbit
Tests
Chores