Skip to content

evidence(OMN-13097): re-bind OCC receipts to gap-skill follow-up PRs - #2823

Merged
jonahgabriel merged 6 commits into
devfrom
jonah/omn-13097-occ-gap-skill-binding
Jun 19, 2026
Merged

jonahgabriel merged 6 commits into
devfrom
jonah/omn-13097-occ-gap-skill-binding

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented Jun 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Refreshes the OMN-13097 OCC receipts that unblock the gap-skill follow-up PRs.
The product PRs cite OMN-13097 and require PASS receipts bound to their current
heads, including omnimarket #1292 after its latest CI nudge commit.

Paired downstream PRs:

Changes

dod_evidence

Local proof from this worktree:

  • uv run validate-yaml contracts/OMN-13097.yaml
  • pre-commit run --files contracts/OMN-13097.yaml drift/dod_receipts/OMN-13097/dod-mypy-strict/command.yaml drift/dod_receipts/OMN-13097/dod-deploy-user-gated/command.yaml
  • uv run python scripts/ci/run_contract_compliance_check.py --pr 2823 --repo OmniNode-ai/onex_change_control --contracts-dir contracts => OMN-13097: 6/6 PASS

Evidence-Source: OCC#2823
Evidence-Ticket: OMN-13097

Summary by CodeRabbit

  • Tests

    • Test execution count increased from 20 to 21 passed tests.
  • Chores

    • Updated validation records with latest execution metadata and checksums.
    • Added new deployment gate validation check for quality assurance.

@coderabbitai

coderabbitai Bot commented Jun 19, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 799e46be-7a2c-42d5-a62e-89a9f40e2839

📥 Commits

Reviewing files that changed from the base of the PR and between 4bae6df and d3cbf6e.

📒 Files selected for processing (7)
  • contracts/OMN-13097.yaml
  • drift/dod_receipts/OMN-13097/dod-deploy-user-gated/command.yaml
  • drift/dod_receipts/OMN-13097/dod-mypy-strict/command.yaml
  • drift/dod_receipts/OMN-13097/dod-occ-pr-self/command.yaml
  • drift/dod_receipts/OMN-13097/dod-omniclaude-precommit/command.yaml
  • drift/dod_receipts/OMN-13097/dod-omniclaude-shim-migrations/command.yaml
  • drift/dod_receipts/OMN-13097/dod-skill-tests/command.yaml

📝 Walkthrough

Walkthrough

The OMN-13097 contract is updated to expect 21 skill tests (up from 20) and gains a new dod-deploy-user-gated evidence block. A corresponding new receipt file is created for that evidence item. Five existing DoD receipt files are refreshed with updated run metadata, commit SHAs, probe outputs, and contract hashes.

Changes

OMN-13097 DoD contract and receipts update

Layer / File(s) Summary
Contract update and new deploy-user-gated receipt
contracts/OMN-13097.yaml, drift/dod_receipts/OMN-13097/dod-deploy-user-gated/command.yaml
dod-skill-tests evidence updated to assert 21 passed; new dod-deploy-user-gated evidence block added asserting deploy gate behavior for gap-skill follow-up PRs; matching command.yaml receipt created with full PASS run record.
Refreshed run metadata in existing receipts
drift/dod_receipts/OMN-13097/dod-skill-tests/command.yaml, drift/dod_receipts/OMN-13097/dod-mypy-strict/command.yaml, drift/dod_receipts/OMN-13097/dod-occ-pr-self/command.yaml, drift/dod_receipts/OMN-13097/dod-omniclaude-precommit/command.yaml, drift/dod_receipts/OMN-13097/dod-omniclaude-shim-migrations/command.yaml
Five existing receipts refreshed with new run_timestamp, commit_sha, runner, probe_stdout, actual_output, contract_sha256, pr_number, and branch values; all retain status: PASS.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

🐇 A receipt refreshed, a new gate in place,
Twenty-one tests now pass with grace.
The deploy guard hops into the chain,
SHA hashes stamped, no drift remains.
All evidence green — the rabbit approves! ✅

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: re-binding OCC receipts to gap-skill follow-up PRs as evidenced by the receipt file updates and the explicit PR objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-13097-occ-gap-skill-binding

Comment @coderabbitai help to get the list of available commands and usage tips.

jonahgabriel pushed a commit that referenced this pull request Jun 19, 2026
Fix the OCC PR's own OCC eligibility (pr_ticket_mismatch on PR #2823) and keep
omnimarket #1292 bound. Distribute three of the five PASS receipts across the
three citing PRs so each has a PR-bound PASS receipt:
- dod-skill-tests   -> omnibase_infra #2045 (commit 014fa5e5)
- dod-mypy-strict   -> omnimarket #1292 (commit b0762f65; mypy --strict clean on
  node_gap_compute, 7 source files)
- dod-occ-pr-self   -> onex_change_control #2823 self-binding (commit 75e0c34)

Contract unchanged (sha256:3f321090...); all receipts keep matching
contract_sha256; verifier != runner. Local proof: validator_occ_merge_eligibility
eligible=true for #2045, #1292, and #2823.
jonahgabriel added 4 commits June 19, 2026 16:50
The gap-skill follow-up PRs (omnibase_infra #2045 register gap->node_gap_compute
CLI mapping; omnimarket #1292 declare node_gap_compute operation_match operation)
cite OMN-13097 but the existing OMN-13097 OCC receipts bound to the original
implementation PRs, so validator_occ_merge_eligibility reported pr_ticket_mismatch
('no PASS receipt ... binds to PR #2045/#1292').

Re-bind two of the five PASS receipts to the new PR commit SHAs so each PR has a
PR-bound PASS receipt (eligibility requires >=1 bound receipt per ticket per PR):
- dod-skill-tests -> omnibase_infra #2045 (commit 014fa5e5; test_cli_skill.py 21
  passed, 1 skipped after registering the gap mapping)
- dod-occ-pr-self  -> omnimarket #1292 (commit b0762f65; OMN-13097 contract
  validates against ModelTicketContract)

Contract OMN-13097.yaml is unchanged (hash sha256:3f321090...); all five receipts
keep matching contract_sha256. verifier (receipt-gate-local) != runner
(omn-13097-gap-skill-impl), so no self-attestation. Local proof:
validator_occ_merge_eligibility eligible=true for both PRs;
validator_receipt_gate_cli RECEIPT GATE PASSED (5 checks) for both repos.
Fix the OCC PR's own OCC eligibility (pr_ticket_mismatch on PR #2823) and keep
omnimarket #1292 bound. Distribute three of the five PASS receipts across the
three citing PRs so each has a PR-bound PASS receipt:
- dod-skill-tests   -> omnibase_infra #2045 (commit 014fa5e5)
- dod-mypy-strict   -> omnimarket #1292 (commit b0762f65; mypy --strict clean on
  node_gap_compute, 7 source files)
- dod-occ-pr-self   -> onex_change_control #2823 self-binding (commit 75e0c34)

Contract unchanged (sha256:3f321090...); all receipts keep matching
contract_sha256; verifier != runner. Local proof: validator_occ_merge_eligibility
eligible=true for #2045, #1292, and #2823.
@jonahgabriel
jonahgabriel force-pushed the jonah/omn-13097-occ-gap-skill-binding branch from a66db79 to 3a4843e Compare June 19, 2026 20:51
@jonahgabriel
jonahgabriel added this pull request to the merge queue Jun 19, 2026
Merged via the queue into dev with commit b967ff3 Jun 19, 2026
4 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-13097-occ-gap-skill-binding branch June 19, 2026 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant