Skip to content

fix(contracts): remove circular test_passes DoD from OMN-7998 [OMN-7998] - #259

Closed
jonahgabriel wants to merge 1 commit into
mainfrom
jonah/omn-7998-fix-contract-dod-checks
Closed

jonahgabriel wants to merge 1 commit into
mainfrom
jonah/omn-7998-fix-contract-dod-checks

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented Apr 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Removes dod-003 (test_passes check) from the OMN-7998 contract
  • The test_passes check type calls gh pr checks from within a running CI job, creating a circular deadlock: CI sees in-progress jobs and returns BLOCK
  • CI is itself the test gate; checking it from inside CI is logically circular
  • Unblocks omnidash PR feat(OMN-10415): [onex_change_control] wire Receipt Gate caller workflow #588 which has been blocked by Contract Compliance Check failures

Test plan

Summary by CodeRabbit

  • Chores
    • Removed a Definition of Done evidence criterion related to CI test requirements from the project contracts.

…ircular CI deadlock

The test_passes check calls gh pr checks from within a CI run, which sees
in-progress jobs and returns BLOCK. CI cannot check itself. Remove dod-003
so Contract Compliance Check unblocks PR #588.
@github-actions
github-actions Bot enabled auto-merge April 13, 2026 16:50
@coderabbitai

coderabbitai Bot commented Apr 13, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 61f80eef-44a6-4ee2-bdfd-7e56ffbe20be

📥 Commits

Reviewing files that changed from the base of the PR and between 1e17e6a and 452a7ee.

📒 Files selected for processing (1)
  • contracts/OMN-7998.yaml
💤 Files with no reviewable changes (1)
  • contracts/OMN-7998.yaml

📝 Walkthrough

Walkthrough

Removed one evidence entry (dod-003) from the dod_evidence list in the contracts configuration file, which previously tracked test pass CI requirements. The remaining three evidence items remain unchanged.

Changes

Cohort / File(s) Summary
Configuration Update
contracts/OMN-7998.yaml
Removed evidence entry dod-003 (test pass CI requirement) from dod_evidence array. Remaining entries (dod-001, dod-002, dod-004) unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 One evidence entry hops away,
dod-003 no longer here to stay,
The test checks fade like morning dew,
Simpler contracts—fresh and true!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically summarizes the main change: removing a circular test_passes check from the OMN-7998 contract to resolve a deadlock issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-7998-fix-contract-dod-checks

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant