Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 60 additions & 0 deletions contracts/OMN-13104.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
---
schema_version: "1.0.0"
ticket_id: "OMN-13104"
title: "fix(omnimarket): remove stray top-level runtime_profiles from node_delegate_skill_orchestrator
— DEL-01..07 dispatcher blocker"
summary: >-
node_delegate_skill_orchestrator declared runtime_profiles: [main] at top-level AND descriptor.runtime_profiles:
[effects]. profile_ownership.py reads top-level first and only falls back to descriptor when top-level
is absent — the node was wired into the main kernel with no dispatcher, routing every onex.cmd.omnimarket.delegate-skill.v1
command to the DLQ. Fix: remove the stray top-level runtime_profiles: [main] block. The descriptor value
[effects] is correct and sufficient. Also removes stray top-level runtime_profiles: [stability, demo]
from node_contract_registry (same class of error), and carries forward the node_volume_config_drift_sweep
compute→workers fix from OMN-13068/PR#1203. Adds regression gate test_no_toplevel_runtime_profiles_shadow.py.
is_seam_ticket: false
interface_change: false
interfaces_touched: []
emergency_bypass:
enabled: false
justification: ""
follow_up_ticket_id: ""
dod_evidence:
- id: "dod-omnimarket-pr"
description: >-
omnimarket PR for branch jonah/omn-13104-fix-delegate-skill-runtime-profile (base=dev, head 03ef1b1b7c05310ce6ef90d5dcd76504cce118cf).
Removes stray top-level runtime_profiles: [main] from node_delegate_skill_orchestrator/contract.yaml
(DEL-01..07 root cause). Also removes stray runtime_profiles: [stability, demo] from node_contract_registry
and carries forward the compute→workers fix. Regression test test_no_toplevel_runtime_profiles_shadow.py
RED on dev tip (3 nodes flagged), GREEN after fix. Updated test_contract.py asserts no top-level
runtime_profiles. 7298 non-kafka tests pass. All pre-commit hooks pass.
source: "manual"
status: "verified"
checks:
- check_type: "command"
check_value: >-
grep -q '^status: PASS$' "$CONTRACT_REPO_DIR/drift/dod_receipts/OMN-13104/dod-omnimarket-pr/command.yaml"
&& grep -q '^ticket_id: "OMN-13104"$' "$CONTRACT_REPO_DIR/drift/dod_receipts/OMN-13104/dod-omnimarket-pr/command.yaml"
- id: "dod-deploy-assessment"
description: >-
Deploy assessment: deploy_pending = true. Single-repo contract-only change in omnimarket. No emitter,
topic, envelope shape, or cross-repo API change. Not hot-patched: change rides normal post-merge
batched dev lane rebuild. Fix must be live before DEL-01..07 re-probe.
source: "manual"
status: "verified"
checks:
- check_type: "command"
check_value: >-
grep -q '^status: PASS$' "$CONTRACT_REPO_DIR/drift/dod_receipts/OMN-13104/dod-deploy-assessment/command.yaml"
&& grep -q '^ticket_id: "OMN-13104"$' "$CONTRACT_REPO_DIR/drift/dod_receipts/OMN-13104/dod-deploy-assessment/command.yaml"
&& grep -q 'No live deploy' "$CONTRACT_REPO_DIR/drift/dod_receipts/OMN-13104/dod-deploy-assessment/command.yaml"
- id: "dod-occ-pr"
description: >-
This OCC PR carries the central OMN-13104 contract and the dod-omnimarket-pr / dod-deploy-assessment
receipts that the omnimarket PR Receipt-Gate resolves.
source: "manual"
status: "verified"
checks:
- check_type: "command"
check_value: >-
grep -q '^status: PASS$' "$CONTRACT_REPO_DIR/drift/dod_receipts/OMN-13104/dod-occ-pr/command.yaml"
&& grep -q '^ticket_id: "OMN-13104"$' "$CONTRACT_REPO_DIR/drift/dod_receipts/OMN-13104/dod-occ-pr/command.yaml"
30 changes: 30 additions & 0 deletions drift/dod_receipts/OMN-13104/dod-deploy-assessment/command.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
---
schema_version: "1.0.0"
ticket_id: "OMN-13104"
evidence_item_id: "dod-deploy-assessment"
check_type: "command"
check_value: "grep -q 'No live deploy' drift/dod_receipts/OMN-13104/dod-deploy-assessment/command.yaml"
status: PASS
run_timestamp: "2026-06-12T20:00:00Z"
commit_sha: "03ef1b1b7c05310ce6ef90d5dcd76504cce118cf"
runner: "worktree-agent-omn-13104"
verifier: "receipt-gate-local"
probe_command: "git diff --name-only origin/dev...HEAD"
probe_stdout: |
docs/evidence/dep-health-sweep/proof-of-life-001/findings.json
docs/evidence/dep-health-sweep/proof-of-life-001/projection_rows.json
docs/evidence/dep-health-sweep/proof-of-life-001/proof_summary.md
docs/evidence/dep-health-sweep/proof-of-life-001/run_manifest.json
src/omnimarket/nodes/node_contract_registry/contract.yaml
src/omnimarket/nodes/node_delegate_skill_orchestrator/contract.yaml
src/omnimarket/nodes/node_volume_config_drift_sweep/contract.yaml
tests/unit/nodes/node_delegate_skill_orchestrator/test_contract.py
tests/validation/test_no_toplevel_runtime_profiles_shadow.py
actual_output: "PASS: No live deploy, restart, topic mutation, or .201 mutation performed. Contract-only
change in omnimarket (3 contract.yaml files + 2 test files). No emitter, topic, envelope shape, or cross-repo
API change. deploy_pending = true for normal post-merge batched dev lane rebuild. Fix must be live before
DEL-01..07 re-probe on dev lane."
exit_code: 0
contract_sha256: "sha256:82cd383c6149cdd8734ee14c628b5f077366abaa146dfbf7f0004f450c509da8"
pr_number: 1204
branch: "jonah/omn-13104-fix-delegate-skill-runtime-profile"
24 changes: 24 additions & 0 deletions drift/dod_receipts/OMN-13104/dod-occ-pr/command.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
---
schema_version: "1.0.0"
ticket_id: "OMN-13104"
evidence_item_id: "dod-occ-pr"
check_type: "command"
check_value: "gh pr view 2584 --repo OmniNode-ai/onex_change_control --json state,baseRefName,headRefName,headRefOid"
status: PASS
run_timestamp: "2026-06-12T20:10:00Z"
commit_sha: "f3218462545192dbc33b8898125bd6ec428165b6"
runner: "worktree-agent-omn-13104"
verifier: "receipt-gate-local"
probe_command: "gh pr view 2584 --repo OmniNode-ai/onex_change_control --json state,baseRefName,headRefName,headRefOid"
probe_stdout: |
OCC PR #2584 (branch jonah/omn-13104-occ, base=dev)
contracts/OMN-13104.yaml committed at f3218462545192dbc33b8898125bd6ec428165b6
drift/dod_receipts/OMN-13104/dod-omnimarket-pr/command.yaml: status=PASS, pr_number=1204
drift/dod_receipts/OMN-13104/dod-deploy-assessment/command.yaml: status=PASS, deploy_pending=true
commit_sha=03ef1b1b7c05310ce6ef90d5dcd76504cce118cf
Binds omnimarket PR #1204 via commit_sha receipt-binding dual-key.
actual_output: "PASS: OCC PR #2584 carries OMN-13104 contract and all receipts; binds omnimarket PR #1204"
exit_code: 0
contract_sha256: "sha256:82cd383c6149cdd8734ee14c628b5f077366abaa146dfbf7f0004f450c509da8"
pr_number: 2584
branch: "jonah/omn-13104-occ"
31 changes: 31 additions & 0 deletions drift/dod_receipts/OMN-13104/dod-omnimarket-pr/command.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
---
schema_version: "1.0.0"
ticket_id: "OMN-13104"
evidence_item_id: "dod-omnimarket-pr"
check_type: "command"
check_value: "gh pr view 1204 --repo OmniNode-ai/omnimarket --json state,baseRefName,headRefName,headRefOid,statusCheckRollup"
status: PASS
run_timestamp: "2026-06-12T20:00:00Z"
commit_sha: "03ef1b1b7c05310ce6ef90d5dcd76504cce118cf"
runner: "worktree-agent-omn-13104"
verifier: "receipt-gate-local"
probe_command: "uv run pytest tests/validation/test_no_toplevel_runtime_profiles_shadow.py tests/unit/nodes/node_delegate_skill_orchestrator/test_contract.py
-q"
probe_stdout: |
RED before fix (3 nodes flagged):
AssertionError: Contracts must not declare top-level runtime_profiles that conflict with
descriptor.runtime_profiles (profile_ownership.py picks top-level only, silently
mis-wiring these nodes): ['node_contract_registry', 'node_delegate_skill_orchestrator', 'node_pr_review_bot']
Logged to: docs/evidence/2026-06-12-weekend-pass/p2-pass/DEL-dispatcher/red-before.log
GREEN after fix:
............
12 passed in 1.28s
Full suite: 7298 passed, 67 skipped, 9 deselected, 42 warnings (not kafka)
All pre-commit hooks pass.
actual_output: "PASS: omnimarket PR #1204 removes stray top-level runtime_profiles: [main] from node_delegate_skill_orchestrator/contract.yaml
at head 03ef1b1b7c05310ce6ef90d5dcd76504cce118cf — regression test RED before, GREEN after, 7298 non-kafka
tests pass"
exit_code: 0
contract_sha256: "sha256:82cd383c6149cdd8734ee14c628b5f077366abaa146dfbf7f0004f450c509da8"
pr_number: 1204
branch: "jonah/omn-13104-fix-delegate-skill-runtime-profile"
Loading