Skip to content

fix(OMN-13022): port hotfix/* bypass removal to OCC main-target-guard (retro A-7) - #2543

Merged
jonahgabriel merged 2 commits into
devfrom
jonah/omn-13022-occ-main-guard-no-hotfix
Jun 12, 2026
Merged

jonahgabriel merged 2 commits into
devfrom
jonah/omn-13022-occ-main-guard-no-hotfix

Conversation

@jonahgabriel

Copy link
Copy Markdown
Contributor

Summary

Retro A-7 (PROCESS_FAILURE_RETRO.md §3.A; Wall of Shame row 7 — feedback_dev_only_promotion_to_main recurred on OCC #2530 base=main and omnidash #212 base=main).

Ticket: OMN-13022 (epic OMN-13013 — process enforcement ratchets, June 12 retro).

Live state verified 2026-06-12 (gh api repos/OmniNode-ai/<repo>/branches/main/protection): main-target-guard is already a REQUIRED status check on main for BOTH omnidash and onex_change_control, and retro Win #6 confirms it fired correctly on #2530. The only residual gap: OCC's guard still allowed hotfix/* heads with evidence — a bypass feedback_dev_only_promotion_to_main explicitly prohibits and omnidash removed in OMN-12477.

Changes

  • .github/workflows/main-target-guard.yml: port the OMN-12477 variant verbatim from omnidash — main accepts ONLY dev-headed promotion PRs carrying promotion-receipt: OCC-<number>; the entire hotfix/* branch with hotfix-evidence/backmerge escape is removed.

Verification

@coderabbitai

coderabbitai Bot commented Jun 12, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@jonahgabriel, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 20 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 101489f1-24d1-4576-8c47-2c985417d49d

📥 Commits

Reviewing files that changed from the base of the PR and between de777bb and 76d0b93.

📒 Files selected for processing (5)
  • .github/workflows/main-target-guard.yml
  • contracts/OMN-13022.yaml
  • drift/dod_receipts/OMN-13022/dod-hotfix-bypass-removed/command.yaml
  • drift/dod_receipts/OMN-13022/dod-main-target-guard-port/command.yaml
  • drift/dod_receipts/OMN-13022/dod-occ-pr-2543/command.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-13022-occ-main-guard-no-hotfix

Comment @coderabbitai help to get the list of available commands and usage tips.

@jonahgabriel
jonahgabriel enabled auto-merge June 12, 2026 07:46
…rget-guard (retro A-7)

main accepts only dev promotion PRs with a promotion receipt. The hotfix/*
escape contradicted feedback_dev_only_promotion_to_main ('no hotfix/* bypass')
and was removed from omnidash in OMN-12477; OCC kept the stale variant.
Verified 2026-06-12: main-target-guard is a required status check on OCC main.

Retro A-7 (PROCESS_FAILURE_RETRO.md §3.A, Wall of Shame row 7 — OCC #2530
base=main class). Epic OMN-13013.
@jonahgabriel
jonahgabriel force-pushed the jonah/omn-13022-occ-main-guard-no-hotfix branch from 06a1dda to 76d0b93 Compare June 12, 2026 07:58
@jonahgabriel
jonahgabriel added this pull request to the merge queue Jun 12, 2026
Merged via the queue into dev with commit 33a5c1a Jun 12, 2026
36 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-13022-occ-main-guard-no-hotfix branch June 12, 2026 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant