Repository navigation
fix(OMN-13022): port hotfix/* bypass removal to OCC main-target-guard (retro A-7) - #2543
Conversation
|
Warning Review limit reached
More reviews will be available in 20 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more credits in the billing tab to continue. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
…rget-guard (retro A-7)
main accepts only dev promotion PRs with a promotion receipt. The hotfix/*
escape contradicted feedback_dev_only_promotion_to_main ('no hotfix/* bypass')
and was removed from omnidash in OMN-12477; OCC kept the stale variant.
Verified 2026-06-12: main-target-guard is a required status check on OCC main.
Retro A-7 (PROCESS_FAILURE_RETRO.md §3.A, Wall of Shame row 7 — OCC #2530
base=main class). Epic OMN-13013.
06a1dda to
76d0b93
Compare
Summary
Retro A-7 (PROCESS_FAILURE_RETRO.md §3.A; Wall of Shame row 7 — feedback_dev_only_promotion_to_main recurred on OCC #2530 base=main and omnidash #212 base=main).
Ticket: OMN-13022 (epic OMN-13013 — process enforcement ratchets, June 12 retro).
Live state verified 2026-06-12 (
gh api repos/OmniNode-ai/<repo>/branches/main/protection):main-target-guardis already a REQUIRED status check on main for BOTH omnidash and onex_change_control, and retro Win #6 confirms it fired correctly on #2530. The only residual gap: OCC's guard still allowedhotfix/*heads with evidence — a bypassfeedback_dev_only_promotion_to_mainexplicitly prohibits and omnidash removed in OMN-12477.Changes
.github/workflows/main-target-guard.yml: port the OMN-12477 variant verbatim from omnidash — main accepts ONLY dev-headed promotion PRs carryingpromotion-receipt: OCC-<number>; the entirehotfix/*branch withhotfix-evidence/backmergeescape is removed.Verification