Repository navigation
evidence(OMN-13011): OCC contract + receipts for lane census reconciliation - #2536
Merged
Merged
Conversation
|
Warning Review limit reached
More reviews will be available in 1 hour, 19 minutes, and 30 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more credits in the billing tab to continue. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
jonahgabriel
enabled auto-merge
June 12, 2026 06:27
jonahgabriel
added this pull request to the merge queue
Jun 12, 2026
This was referenced Jul 29, 2026
jonahgabriel
added a commit
that referenced
this pull request
Jul 29, 2026
…-time contract lint
contracts/OMN-14968.yaml failed dod_verify 3/7: four dod_evidence check_values opened
with the human-readable prose "Recorded product receipt: ..." handed verbatim to `sh -c`
(the literal word "Recorded" fails "command not found", exit 127), one of which piped
into a bare `sha256sum` with no explicit assertion -- vacuously green on any input since
`sh -c` has no `pipefail`. A sixth item used the OMN-14431 bare ${PR_NUMBER}/${REPO}
runner placeholder, so it never pinned PR #2536 (class-3 mis-binding).
Repairs contracts/OMN-14968.yaml with five append-only, hosted-runnable, falsifiable
replacement entries (mirroring the OMN-14875/PR#4528 supersedes_dod_evidence idiom):
a literal PR #2536 pin, gh-api content probes against omnibase_infra PR #2536's merge
commit for the two committed test names + the static ratchet assertion string, and an
in-checkout grep against the already-committed lane-render-parity receipt's sha256
fragments (replacing the vacuous pipe).
Ships the mechanism in the same PR: scripts/lint_contract_check_values.py gains
Rule A (executable-command-shape) and Rule B (per-item PR binding). A corpus-wide
survey found the mis-binding defect recurs ~1,190 times historically and the prose
defect ~244 times; both are frozen into shrink-only baselines under .onex_ratchets/
asserted by set equality so new instances hard-fail while historical debt stays visible.
Adds contracts/OMN-15382.yaml (this ticket's own OCC evidence).
jonahgabriel
added a commit
that referenced
this pull request
Jul 29, 2026
…-time contract lint
contracts/OMN-14968.yaml failed dod_verify 3/7: four dod_evidence check_values opened
with the human-readable prose "Recorded product receipt: ..." handed verbatim to `sh -c`
(the literal word "Recorded" fails "command not found", exit 127), one of which piped
into a bare `sha256sum` with no explicit assertion -- vacuously green on any input since
`sh -c` has no `pipefail`. A sixth item used the OMN-14431 bare ${PR_NUMBER}/${REPO}
runner placeholder, so it never pinned PR #2536 (class-3 mis-binding).
Repairs contracts/OMN-14968.yaml with five append-only, hosted-runnable, falsifiable
replacement entries (mirroring the OMN-14875/PR#4528 supersedes_dod_evidence idiom):
a literal PR #2536 pin, gh-api content probes against omnibase_infra PR #2536's merge
commit for the two committed test names + the static ratchet assertion string, and an
in-checkout grep against the already-committed lane-render-parity receipt's sha256
fragments (replacing the vacuous pipe).
Ships the mechanism in the same PR: scripts/lint_contract_check_values.py gains
Rule A (executable-command-shape) and Rule B (per-item PR binding). A corpus-wide
survey found the mis-binding defect recurs ~1,190 times historically and the prose
defect ~244 times; both are frozen into shrink-only baselines under .onex_ratchets/
asserted by set equality so new instances hard-fail while historical debt stays visible.
Adds contracts/OMN-15382.yaml (this ticket's own OCC evidence).
jonahgabriel
added a commit
that referenced
this pull request
Jul 29, 2026
…-time contract lint (#5458) * fix(OMN-15382): repair OMN-14968 dod_verify 3/7 FAIL + ship authoring-time contract lint contracts/OMN-14968.yaml failed dod_verify 3/7: four dod_evidence check_values opened with the human-readable prose "Recorded product receipt: ..." handed verbatim to `sh -c` (the literal word "Recorded" fails "command not found", exit 127), one of which piped into a bare `sha256sum` with no explicit assertion -- vacuously green on any input since `sh -c` has no `pipefail`. A sixth item used the OMN-14431 bare ${PR_NUMBER}/${REPO} runner placeholder, so it never pinned PR #2536 (class-3 mis-binding). Repairs contracts/OMN-14968.yaml with five append-only, hosted-runnable, falsifiable replacement entries (mirroring the OMN-14875/PR#4528 supersedes_dod_evidence idiom): a literal PR #2536 pin, gh-api content probes against omnibase_infra PR #2536's merge commit for the two committed test names + the static ratchet assertion string, and an in-checkout grep against the already-committed lane-render-parity receipt's sha256 fragments (replacing the vacuous pipe). Ships the mechanism in the same PR: scripts/lint_contract_check_values.py gains Rule A (executable-command-shape) and Rule B (per-item PR binding). A corpus-wide survey found the mis-binding defect recurs ~1,190 times historically and the prose defect ~244 times; both are frozen into shrink-only baselines under .onex_ratchets/ asserted by set equality so new instances hard-fail while historical debt stays visible. Adds contracts/OMN-15382.yaml (this ticket's own OCC evidence). * evidence(OMN-15382): self-bind PR #5458 -- hardcode real PR number * evidence(OMN-15382): bind pr_number 5458 on all receipts (occ-preflight PR-binding fix) * reconcile(OMN-15382): rebase onto dev, append-only merge with autobind contract dev independently landed its own contracts/OMN-15382.yaml (node_occ_companion_compute autobind reacting to OmniNode-ai/omnimarket PR #1949) after this branch diverged. Reconciled per the OCC append-only gate: every dev dod_evidence entry is kept byte-intact, in dev's original order, ahead of this branch's items (verified via compute_contract_entry_sha256 -- all existing receipts under drift/dod_receipts/ still validate against the merged file, so none needed regeneration). The one id collision (dod-OmniNode-ai-omnimarket-pr-1949) is resolved by keeping dev's entry untouched and renaming this branch's strictly-stronger duplicate (which additionally asserts the PR's file list contains node_dod_verify) to dod-OmniNode-ai-omnimarket-pr-1949-strict. Rebasing onto dev also surfaced 3 NEW Rule B (per-item PR binding) violations in dev's own autobind entries (occ-self-bind-pr-5459/5465/5466, each using the bare ${PR_NUMBER} placeholder while the id embeds a specific PR number) -- exactly the defect class this ticket's lint exists to catch, landing via the same autobind race. Per append-only, the originals are kept untouched; each is superseded (evidence_artifact: supersedes_dod_evidence:<id>) by an occ-self-bind-pr-<n>-strict entry hardcoding the PR number (verified live: PRs #5459/#5465/#5466 are real, merged OCC PRs), so contracts/OMN-15382.yaml stays clean under this PR's own lint as its authoring-time-clean design requires. Also shrinks .onex_ratchets/omn_15382_rule_b_baseline.yaml by 2 entries (contracts/OMN-15192.yaml::dod-OmniNode-ai-omnimarket-pr-1941-ci, contracts/OMN-15192.yaml::occ-self-bind-pr-5387) that an independent dev-side repair healed since this baseline was frozen -- the corpus-baseline test requires exact set equality and flagged them as stale. Verified locally (env -u PYTHONPATH, this Mac -- logged exception per root CLAUDE.md rule 11a for this bounded remediation): scripts/lint_contract_check_values.py contracts/OMN-14968.yaml contracts/OMN-15382.yaml -- exit 0 pytest tests/unit/scripts/test_lint_contract_check_values*.py -- 49 passed pytest tests/test_evidence_admissibility.py tests/test_evidence_admissibility_parity.py tests/test_contract_compliance_check.py tests/test_handler_contract_compliance_scan.py -- 180 passed scripts/validation/check_receipt_hardening.py -- exit 0 * evidence(OMN-15382): PASS receipts for the 4 append-only -strict entries occ-preflight/eligibility (and receipt-gate's verify/verify) requires a PASS receipt for every dod_evidence item across every ticket cited in this PR, including the 4 append-only supersession entries added by the prior reconciliation commit (dod-OmniNode-ai-omnimarket-pr-1949-strict, occ-self-bind-pr-5459-strict, occ-self-bind-pr-5465-strict, occ-self-bind-pr-5466-strict). None had a receipt yet -- verified live and recorded here: gh pr view 1949 --repo OmniNode-ai/omnimarket --json state -> MERGED gh pr view 1949 --repo OmniNode-ai/omnimarket --json files --jq ... node_dod_verify -> true gh pr view 5459/5465/5466 --repo OmniNode-ai/onex_change_control --json number,state -> all MERGED Locally simulated the exact CI invocation of validator_occ_merge_eligibility against this contract + receipt tree with occ-commit-sha = this commit's parent: eligible=true, missing_or_nonpass_receipts=[]. * fix(OMN-15382): supersede OCC 5472 self-bind placeholders
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Evidence-Ticket: OMN-13011
Evidence-Source: automated-manual-merge-sweep
Adds the central OMN-13011 OCC contract and PASS receipts for omnibase_infra#1953 lane census reconciliation.