Skip to content

evidence(OMN-12991): correct SEA docs receipt - #2507

Merged
jonahgabriel merged 4 commits into
devfrom
jonah/omn-12991-occ-correct-sea-docs
Jun 11, 2026
Merged

jonahgabriel merged 4 commits into
devfrom
jonah/omn-12991-occ-correct-sea-docs

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented Jun 11, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Verification

  • uv run pre-commit run --files contracts/OMN-12991.yaml drift/dod_receipts/OMN-12991/dod-sea-pr-230/command.yaml drift/dod_receipts/OMN-12991/dod-occ-pr/command.yaml

Evidence-Ticket: OMN-12991

Summary by CodeRabbit

  • Chores
    • Updated internal contract documentation and verification records with refined architectural scope and deterministic workflow specifications.
    • Consolidated and refreshed verification evidence tracking records.

@coderabbitai

coderabbitai Bot commented Jun 11, 2026 •

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@jonahgabriel, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 1 hour, 51 minutes, and 34 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d137ead5-7d97-4a55-8fd5-c563af3ce6ad

📥 Commits

Reviewing files that changed from the base of the PR and between 3f76964 and a201e26.

📒 Files selected for processing (3)
  • contracts/OMN-12991.yaml
  • drift/dod_receipts/OMN-12991/dod-occ-pr/command.yaml
  • drift/dod_receipts/OMN-12991/dod-sea-pr-230/command.yaml
📝 Walkthrough

Walkthrough

This PR updates the OMN-12991 ticket's evidence specification and supporting receipt records. The contract migrates its evidence reference from dod-omniintelligence-pr-704 to dod-sea-pr-230, updates the OCC receipt metadata to point to PR 2507, and adds a new SEA proof receipt with passing verification status.

Changes

OMN-12991 Evidence Receipt Migration

Layer / File(s) Summary
Contract evidence specification update
contracts/OMN-12991.yaml
Contract title and summary reframe to OmniNode SEA proof and deterministic workflow; dod_evidence section swaps primary receipt reference from dod-omniintelligence-pr-704 to dod-sea-pr-230 with updated grep command assertions; dod-occ-pr description updated; evidence_requirements block removed; emergency_bypass repositioned.
Receipt metadata for evidence items
drift/dod_receipts/OMN-12991/dod-occ-pr/command.yaml, drift/dod_receipts/OMN-12991/dod-sea-pr-230/command.yaml
OCC receipt updated to reference PR 2507 with branch jonah/omn-12991-occ-correct-sea-docs, including refreshed run_timestamp, commit_sha, runner, verifier, and contract_sha256. New SEA receipt created with complete metadata: schema version, ticket/evidence identifiers, PASS status, probe command, stdout verification output, and commit provenance.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • OmniNode-ai/onex_change_control#1872: Both PRs update the dod-occ-pr/command.yaml receipt to correct the self-referential pr_number field so the OCC grep check matches the actual PR being verified.
  • OmniNode-ai/onex_change_control#2014: Both PRs update drift/dod_receipts/**/command.yaml receipt records' contract_sha256 digest values used by the receipt gate validation.

Poem

🐰 A contract refined, new receipts in place,
From old proof to SEA, a cleaner embrace,
OCC points true, metadata blessed,
Deterministic workflows stand the test!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: correcting SEA documentation receipts for ticket OMN-12991 by replacing an incorrect receipt with the proper one.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-12991-occ-correct-sea-docs

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@contracts/OMN-12991.yaml`:
- Around line 33-36: The contract check for dod-occ-pr (check_type "command"
with check_value) only validates status and ticket_id and must be tightened to
pin the OCC receipt to PR 2507: update the check_value for the file at
"$CONTRACT_REPO_DIR/drift/dod_receipts/OMN-12991/dod-occ-pr/command.yaml" to
also grep for the PR identifier (e.g., a line like pr: "2507" or pr_number:
"2507") so the command requires status: PASS, ticket_id: "OMN-12991", and the
specific PR 2507 simultaneously.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c8a80fb0-17be-4409-a29c-eb6dc4583be9

📥 Commits

Reviewing files that changed from the base of the PR and between 7f12a7e and 3f76964.

📒 Files selected for processing (4)
  • contracts/OMN-12991.yaml
  • drift/dod_receipts/OMN-12991/dod-occ-pr/command.yaml
  • drift/dod_receipts/OMN-12991/dod-omniintelligence-pr-704/command.yaml
  • drift/dod_receipts/OMN-12991/dod-sea-pr-230/command.yaml
💤 Files with no reviewable changes (1)
  • drift/dod_receipts/OMN-12991/dod-omniintelligence-pr-704/command.yaml

Comment thread contracts/OMN-12991.yaml
@jonahgabriel
jonahgabriel added this pull request to the merge queue Jun 11, 2026
Merged via the queue into dev with commit bd37a98 Jun 11, 2026
42 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-12991-occ-correct-sea-docs branch June 11, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant