Repository navigation
evidence(OMN-11513): 2026-06-08 SEA delegation verification — broker + local-ADK retests - #2355
Merged
Merged
Conversation
…(OMN-12832) + local-ADK (OMN-12834) retests
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (21)
✅ Files skipped from review due to trivial changes (14)
📝 WalkthroughWalkthroughThis PR adds comprehensive integration test evidence for OMN-11513 SEA delegation verification, including a multi-phase retest report, phase-specific diagnostic artifacts, unit test results, and architectural findings. The test documents broker readiness (Phase 1 GREEN), end-to-end inference delegation success (Phase 3 PASS), Phase 2 agent orchestration blockers, and local ADK tool-schema compatibility issues. ChangesSEA Delegation Verification Evidence
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
evidence/OMN-11513/integration-test-passes/2026-06-08-sea-delegation-verification/phase4-projection-readback.txt (2)
38-60: ⚡ Quick winConsider including verification command outputs.
The root cause explanation references code locations (lines 41-47), grep findings (lines 50-54), and local file existence (lines 56-59) but doesn't include the actual command outputs. For independently verifiable evidence, consider appending:
- The actual code snippet from
src/__main__.py:819-839- The grep command and its output confirming no
bus.publish()calls- Output from
ls -lorcatshowing the local event chain file contentsThis would strengthen the evidence trail and allow independent confirmation of the architectural boundary without requiring access to the codebase or environment.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@evidence/OMN-11513/integration-test-passes/2026-06-08-sea-delegation-verification/phase4-projection-readback.txt` around lines 38 - 60, Add the actual verification outputs to the explanation: paste the src/__main__.py snippet that builds and records the envelopes (the block that calls EventChainCapture(output_dir=...), capture.record(REQUESTED_TOPIC,...), capture.record(COMPLETED_TOPIC,...), capture.save(...)); include the grep command text and its stdout showing no occurrences of bus.publish() for the generation-completed topic; and append the ls -l and cat output for the .onex_state/hackathon/event_chains/<correlation_id>.json file so reviewers can independently confirm the local capture file and its contents.
6-6: Clarify that port 13002 is lane-specific (stability-test) vs :3002 (OMN-12760 contract)
- contracts/OMN-12760.yaml targets the projection API on :3002, but other receipts (OMN-12833) explicitly use the stability-test projection API on :13002 and assert ZERO traffic to :3002—so using :13002 in this phase4 readback is consistent for that lane.
- Add a short note in
phase4-projection-readback.txtstating that this evidence is for the stability-test lane (hence 13002), to prevent confusion with the :3002 contract surface.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@evidence/OMN-11513/integration-test-passes/2026-06-08-sea-delegation-verification/phase4-projection-readback.txt` at line 6, The evidence file phase4-projection-readback.txt uses port 13002 for the projection API but doesn't clarify that this is the stability-test lane (versus the OMN-12760 contract surface on :3002); update phase4-projection-readback.txt to add a short note stating this evidence is for the stability-test lane and that port 13002 is used intentionally (and that :3002 is the contract/API surface referenced by OMN-12760) to avoid confusion with receipts asserting zero traffic to :3002.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@evidence/OMN-11513/integration-test-passes/2026-06-08-sea-delegation-verification/report.md`:
- Line 30: The Phase 0 characterization is incorrect: replace the
"contractor-overlay-drift (the `model_registry.local.yaml` false alarm), no code
regression" summary with an accurate description that all three unit test
failures are due to endpoint resolution ignoring the environment override and
resolving to http://100.109.203.94:8000 (not localhost or the
LOCAL_INFERENCE_BASE_URL_ENV), explicitly call out the failing test
test_load_default_registry_honors_env_override (from phase0-unit-tests.txt lines
~78-91) which verifies the env override but shows it being ignored, and remove
the unsupported "no code regression" claim (or mark it as unverified) unless you
add baseline evidence; update the report text accordingly so it references
phase0-unit-tests.txt and the environment variable handling defect.
---
Nitpick comments:
In
`@evidence/OMN-11513/integration-test-passes/2026-06-08-sea-delegation-verification/phase4-projection-readback.txt`:
- Around line 38-60: Add the actual verification outputs to the explanation:
paste the src/__main__.py snippet that builds and records the envelopes (the
block that calls EventChainCapture(output_dir=...),
capture.record(REQUESTED_TOPIC,...), capture.record(COMPLETED_TOPIC,...),
capture.save(...)); include the grep command text and its stdout showing no
occurrences of bus.publish() for the generation-completed topic; and append the
ls -l and cat output for the
.onex_state/hackathon/event_chains/<correlation_id>.json file so reviewers can
independently confirm the local capture file and its contents.
- Line 6: The evidence file phase4-projection-readback.txt uses port 13002 for
the projection API but doesn't clarify that this is the stability-test lane
(versus the OMN-12760 contract surface on :3002); update
phase4-projection-readback.txt to add a short note stating this evidence is for
the stability-test lane and that port 13002 is used intentionally (and that
:3002 is the contract/API surface referenced by OMN-12760) to avoid confusion
with receipts asserting zero traffic to :3002.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 149da90c-f51d-4805-95dd-9918ee77f570
📒 Files selected for processing (8)
evidence/OMN-11513/integration-test-passes/2026-06-08-sea-delegation-verification/afternoon-retest-unblocked.txtevidence/OMN-11513/integration-test-passes/2026-06-08-sea-delegation-verification/local-adk-400-capture.jsonevidence/OMN-11513/integration-test-passes/2026-06-08-sea-delegation-verification/phase0-unit-tests.txtevidence/OMN-11513/integration-test-passes/2026-06-08-sea-delegation-verification/phase2-agent-e2e.txtevidence/OMN-11513/integration-test-passes/2026-06-08-sea-delegation-verification/phase2-local-adk-PASS-postfix.txtevidence/OMN-11513/integration-test-passes/2026-06-08-sea-delegation-verification/phase3-inference-smoke.txtevidence/OMN-11513/integration-test-passes/2026-06-08-sea-delegation-verification/phase4-projection-readback.txtevidence/OMN-11513/integration-test-passes/2026-06-08-sea-delegation-verification/report.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Daily Integration Test Pass Report for 2026-06-08 contractor verification (stability-test lane, WSL2/Tailscale).
Verdict: partially green / projection limited.
--agentgeneration now completes end to end with no cloud key (correlation 0cdc2410).--agentrecords generation events locally rather than publishing to the bus, so nogeneration_eventsprojection row is created (code-confirmed,__main__.py:819-839). Projection-backed proof requires the server-side runtime path, which is out of contractor scope. Not a projection defect.Report + 7 evidence transcripts in
evidence/OMN-11513/integration-test-passes/2026-06-08-sea-delegation-verification/.Summary by CodeRabbit
Documentation
Tests
Chores
Evidence-Ticket: OMN-11513