Repository navigation
evidence(OMN-12661): add clean on-off experiment receipts - #2293
Conversation
📝 WalkthroughWalkthroughThis PR adds a new evidence bundle contract for ticket OMN-12661 (WS-F bounded ON-vs-OFF experiment) along with five supporting evidence receipt files documenting test execution, deployment verification, PR state checks, cost analysis, and proof classification outcomes, all verified with PASS status. ChangesEvidence Bundle for ON-vs-OFF Experiment (OMN-12661)
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@drift/dod_receipts/OMN-12661/dod-occ-pr-evidence/command.yaml`:
- Around line 1-23: The receipt in
drift/dod_receipts/OMN-12661/dod-occ-pr-evidence/command.yaml is inconsistent
with the contract contracts/OMN-12661.yaml: the contract describes
dod-occ-pr-evidence as verifying the OCC PR that carries the central contract
and PASS receipts, but this receipt's check_value/probe_command target
omnimarket PR `#1072` while pr_number is 2293; align them by either (A) updating
check_value and probe_command to target PR `#2293` (and ensure
probe_stdout/actual_output reflect that PR) or (B) update
contracts/OMN-12661.yaml (the dod-occ-pr-evidence description) to state it
verifies PR `#1072`; modify the unique fields check_value, probe_command,
pr_number, and any related probe_stdout/actual_output so all three consistently
reference the same PR number and evidence.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 92ebcc71-4806-4e95-837f-48e21da36c13
📒 Files selected for processing (6)
contracts/OMN-12661.yamldrift/dod_receipts/OMN-12661/dod-cost-delta-bundle/command.yamldrift/dod_receipts/OMN-12661/dod-deploy-evidence/command.yamldrift/dod_receipts/OMN-12661/dod-occ-pr-evidence/command.yamldrift/dod_receipts/OMN-12661/dod-on-off-run-evidence/command.yamldrift/dod_receipts/OMN-12661/dod-proof-classification/command.yaml
Evidence-Ticket: OMN-12661
Summary
Verification
uv run pre-commit run yamlfmt --files contracts/OMN-12661.yaml drift/dod_receipts/OMN-12661/*/command.yamluv run python scripts/lint_contract_check_values.py contracts/OMN-12661.yamluv run python scripts/check_dod_evidence_present.py contracts/OMN-12661.yamlvalidator_occ_merge_eligibilityfor omnimarket PR evidence(OMN-11011): bind package migration classification #1072 -> eligibleDownstream
Summary by CodeRabbit
Tests
Chores