Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 40 additions & 32 deletions contracts/OMN-12471.yaml
Original file line number Diff line number Diff line change
@@ -1,51 +1,59 @@
---
schema_version: "1.0.0"
ticket_id: "OMN-12471"
title: "node_kafka_ingress_effect replaces kafka_runner.py daemon"
summary: >
Phase 2b / PR-5 of the SEA stack-vs-dev reconciliation. Replaces the bespoke src/pipeline/kafka_runner.py
daemon (its __main__, SIGINT/SIGTERM handlers, the for-msg KafkaConsumer/KafkaProducer loop, the three
inline onex.*.omnimarket.* topic literals, and the direct generate_with_retry call) with a contract-bound
EFFECT transport-adapter node. node_kafka_ingress_effect declares the full transport lifecycle as typed,
validated config (ModelKafkaIngressContract, extra=forbid): source_topic_ref + dead_letter topic_ref
resolved from src/pipeline/topics.py constants (never inline literals), consumer_group, offset_policy,
dedupe_key, invalid_message_handling, and first-class typed dead_letter + replay sub-models. The pure
map_ingress_envelope maps a validated external command envelope into ModelNodeGenerationRequestedCommand
and the handler republishes it onto the in-process bus as DEMO_REQUESTED_TOPIC. The node does NOT call
inference — zero httpx.post added; all config from the contract. Manually re-applied onto onex-self-extending-agent
origin/dev @ 0984678 (NOT cherry-picked from the abandoned OMN-12468 stack branches).
title: "SEA: enum-typed ModelRegistryEntry + entry_for_tier coercion"
summary: >-
Bind central evidence for onex-self-extending-agent PR #186, which lifts ModelRegistryEntry.provider/model_tier/cost_basis
from str to the EnumModelProvider/EnumModelTier/EnumModelCostBasis StrEnums, adds EnumModelTier coercion
to entry_for_tier, and replaces the cost-basis-keyed secret-overlay validator with provider-keyed overlay/usage
validators while preserving entries_for_tier / entry_by_name for the eval path.
is_seam_ticket: false
interface_change: false
interfaces_touched: []
evidence_requirements:
- kind: "tests"
description: "onex-self-extending-agent PR #185 carries the ingress node, the kafka_runner.py deletion,
and unit + broker-gated integration tests."
command: "See drift/dod_receipts/OMN-12471/dod-sea-pr-185/command.yaml"
- kind: "manual"
description: "onex_change_control PR carrying this contract binds the central evidence publication."
command: "See drift/dod_receipts/OMN-12471/dod-occ-pr/command.yaml"
emergency_bypass:
enabled: false
justification: ""
follow_up_ticket_id: ""
dod_evidence:
- id: "dod-sea-pr-185"
description: >
onex-self-extending-agent PR #185 deletes src/pipeline/kafka_runner.py and adds node_kafka_ingress_effect
(contract-declared transport lifecycle, pure map_ingress_envelope, fail-closed mapping, no httpx,
no off-bus topic literals). Full suite green: uv run pytest tests/ -v (1211 passed, 15 skipped)
+ mypy --strict + ruff + pre-commit.
- id: "dod-sea-pr-189"
description: "Bind onex-self-extending-agent PR #189 head and branch for the OMN-12471 change."
source: "manual"
status: "verified"
checks:
- check_type: "command"
check_value: "grep -q '^status: PASS$' drift/dod_receipts/OMN-12471/dod-sea-pr-185/command.yaml
&& grep -q '^pr_number: 185$' drift/dod_receipts/OMN-12471/dod-sea-pr-185/command.yaml"
- id: "dod-occ-pr"
description: "onex_change_control publishes the OMN-12471 central contract and receipts."
check_value: >-
grep -q '^status: PASS$' "$CONTRACT_REPO_DIR/drift/dod_receipts/OMN-12471/dod-sea-pr-189/command.yaml"
&& grep -q '^pr_number: 189$' "$CONTRACT_REPO_DIR/drift/dod_receipts/OMN-12471/dod-sea-pr-189/command.yaml"
&& grep -q '^commit_sha: "e7f10f1092d9706065cb2e51b5bc96fde5d30bdc"$' "$CONTRACT_REPO_DIR/drift/dod_receipts/OMN-12471/dod-sea-pr-189/command.yaml"
- id: "dod-enum-typing"
description: "Prove the registry entry fields are enum-typed, entry_for_tier coerces, and no httpx
surface was added."
source: "manual"
status: "verified"
checks:
- check_type: "command"
check_value: "grep -q '^status: PASS$' drift/dod_receipts/OMN-12471/dod-occ-pr/command.yaml"
check_value: >-
grep -q '^status: PASS$' "$CONTRACT_REPO_DIR/drift/dod_receipts/OMN-12471/dod-enum-typing/command.yaml"
&& grep -q 'provider: EnumModelProvider' "$CONTRACT_REPO_DIR/drift/dod_receipts/OMN-12471/dod-enum-typing/command.yaml"
&& grep -q 'model_tier: EnumModelTier' "$CONTRACT_REPO_DIR/drift/dod_receipts/OMN-12471/dod-enum-typing/command.yaml"
&& grep -q 'cost_basis: EnumModelCostBasis' "$CONTRACT_REPO_DIR/drift/dod_receipts/OMN-12471/dod-enum-typing/command.yaml"
&& grep -q 'httpx added: 0' "$CONTRACT_REPO_DIR/drift/dod_receipts/OMN-12471/dod-enum-typing/command.yaml"
- id: "dod-local-validation"
description: "Full unit suite, mypy strict, ruff format, ruff check, and pre-commit passed locally."
source: "manual"
status: "verified"
checks:
- check_type: "command"
check_value: >-
grep -q '^status: PASS$' "$CONTRACT_REPO_DIR/drift/dod_receipts/OMN-12471/dod-local-validation/command.yaml"
&& grep -q '1200 passed, 15 skipped' "$CONTRACT_REPO_DIR/drift/dod_receipts/OMN-12471/dod-local-validation/command.yaml"
&& grep -q 'Success: no issues found in 156 source files' "$CONTRACT_REPO_DIR/drift/dod_receipts/OMN-12471/dod-local-validation/command.yaml"
- id: "dod-occ-pr-self"
description: "Self-binding receipt for the OCC PR carrying OMN-12471 central evidence."
source: "manual"
status: "verified"
checks:
- check_type: "command"
check_value: >-
grep -q '^status: PASS$' "$CONTRACT_REPO_DIR/drift/dod_receipts/OMN-12471/dod-occ-pr-self/command.yaml"
&& grep -q '^pr_number: 1993$' "$CONTRACT_REPO_DIR/drift/dod_receipts/OMN-12471/dod-occ-pr-self/command.yaml"
29 changes: 29 additions & 0 deletions drift/dod_receipts/OMN-12471/dod-enum-typing/command.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
---
schema_version: "1.0.0"
ticket_id: "OMN-12471"
evidence_item_id: "dod-enum-typing"
check_type: "command"
check_value: "grep -nE 'provider: EnumModelProvider|model_tier: EnumModelTier|cost_basis: EnumModelCostBasis'
src/contracts/model_registry.py && git diff origin/dev...HEAD -- src/ | grep -cE '^\\+.*httpx'"
status: PASS
run_timestamp: "2026-05-31T11:06:00Z"
commit_sha: "e7f10f1092d9706065cb2e51b5bc96fde5d30bdc"
contract_sha256: "sha256:ec93c06f821cd1d2e9d7536677084d2ff78d94a9a6cdb185bf374c338f5a26eb"
branch: "jonah/omn-12471-sea-enum-registry"
runner: "claude"
verifier: "jonah"
probe_command: "grep -nE 'provider: EnumModelProvider|model_tier: EnumModelTier|cost_basis: EnumModelCostBasis'
src/contracts/model_registry.py; grep -n 'resolved = EnumModelTier(tier)' src/contracts/model_registry.py;
git diff origin/dev...HEAD -- src/ | grep -cE '^\\+.*httpx'"
probe_stdout: |
92: provider: EnumModelProvider
95: model_tier: EnumModelTier
96: cost_basis: EnumModelCostBasis
202: resolved = EnumModelTier(tier)
0
actual_output: >-
PASS: ModelRegistryEntry fields are enum-typed (provider: EnumModelProvider, model_tier: EnumModelTier,
cost_basis: EnumModelCostBasis); entry_for_tier coerces via EnumModelTier(tier); httpx added: 0 lines
in the PR diff under src/.
exit_code: 0
working_dir: "/Users/jonah/Code/omni_worktrees/enum-registry/sea"
26 changes: 26 additions & 0 deletions drift/dod_receipts/OMN-12471/dod-local-validation/command.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
---
schema_version: "1.0.0"
ticket_id: "OMN-12471"
evidence_item_id: "dod-local-validation"
check_type: "command"
check_value: "uv run pytest tests/ -q && uv run mypy src/ --strict && uv run ruff check src/ tests/ &&
uv run ruff format --check src/ tests/"
status: PASS
run_timestamp: "2026-05-31T11:07:00Z"
commit_sha: "e7f10f1092d9706065cb2e51b5bc96fde5d30bdc"
contract_sha256: "sha256:ec93c06f821cd1d2e9d7536677084d2ff78d94a9a6cdb185bf374c338f5a26eb"
branch: "jonah/omn-12471-sea-enum-registry"
runner: "claude"
verifier: "jonah"
probe_command: "PYTHONDONTWRITEBYTECODE=1 uv run pytest tests/ -q; uv run mypy src/ --strict; uv run ruff
check src/ tests/; uv run ruff format --check src/ tests/"
probe_stdout: |
1200 passed, 15 skipped in 11.55s
Success: no issues found in 156 source files
All checks passed!
281 files already formatted
actual_output: >-
PASS: full unit suite green (1200 passed, 15 skipped); mypy --strict clean (Success: no issues found
in 156 source files); ruff check + format clean; pre-commit run --all-files passed on the SEA worktree.
exit_code: 0
working_dir: "/Users/jonah/Code/omni_worktrees/enum-registry/sea"
20 changes: 20 additions & 0 deletions drift/dod_receipts/OMN-12471/dod-occ-pr-self/command.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
---
schema_version: "1.0.0"
ticket_id: "OMN-12471"
evidence_item_id: "dod-occ-pr-self"
check_type: "command"
check_value: "gh pr view 1993 --repo OmniNode-ai/onex_change_control --json number,state,headRefName,headRefOid,url,isDraft,title"
status: PASS
run_timestamp: "2026-05-31T11:12:00Z"
commit_sha: "7546a3f4952a08d7b8c6fc57e6ef31908b60d60a"
contract_sha256: "sha256:ec93c06f821cd1d2e9d7536677084d2ff78d94a9a6cdb185bf374c338f5a26eb"
branch: "jonah/omn-12471a-occ-evidence"
pr_number: 1993
runner: "claude"
verifier: "jonah"
probe_command: "gh pr view 1993 --repo OmniNode-ai/onex_change_control --json number,state,headRefName,headRefOid,url,isDraft,title"
probe_stdout: |
{"headRefName":"jonah/omn-12471a-occ-evidence","headRefOid":"7546a3f4952a08d7b8c6fc57e6ef31908b60d60a","isDraft":false,"number":1993,"state":"OPEN","title":"evidence(OMN-12471): SEA enum-typed model registry receipts","url":"https://github.com/OmniNode-ai/onex_change_control/pull/1993"}
actual_output: "PASS: OCC PR #1993 carries the OMN-12471 central contract and receipts."
exit_code: 0
working_dir: "/Users/jonah/Code/omni_worktrees/enum-registry/occ"
20 changes: 0 additions & 20 deletions drift/dod_receipts/OMN-12471/dod-occ-pr/command.yaml

This file was deleted.

27 changes: 0 additions & 27 deletions drift/dod_receipts/OMN-12471/dod-sea-pr-185/command.yaml

This file was deleted.

22 changes: 22 additions & 0 deletions drift/dod_receipts/OMN-12471/dod-sea-pr-189/command.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
---
schema_version: "1.0.0"
ticket_id: "OMN-12471"
evidence_item_id: "dod-sea-pr-189"
check_type: "command"
check_value: "gh pr view 189 --repo OmniNode-ai/onex-self-extending-agent --json number,url,headRefOid,headRefName,baseRefName,title,state,isDraft"
status: PASS
run_timestamp: "2026-05-31T11:55:00Z"
commit_sha: "e7f10f1092d9706065cb2e51b5bc96fde5d30bdc"
contract_sha256: "sha256:ec93c06f821cd1d2e9d7536677084d2ff78d94a9a6cdb185bf374c338f5a26eb"
branch: "jonah/omn-12471-sea-enum-registry"
pr_number: 189
runner: "claude"
verifier: "jonah"
probe_command: "gh pr view 189 --repo OmniNode-ai/onex-self-extending-agent --json number,url,headRefOid,headRefName,baseRefName,title,state,isDraft"
probe_stdout: |
{"baseRefName":"dev","headRefName":"jonah/omn-12471-sea-enum-registry","headRefOid":"e7f10f1092d9706065cb2e51b5bc96fde5d30bdc","number":189,"state":"OPEN","title":"feat(OMN-12471): enum-typed ModelRegistryEntry + entry_for_tier coercion (piece a)"}
actual_output: >-
PASS: onex-self-extending-agent PR #189 binds OMN-12471 at head e7f10f1092d9706065cb2e51b5bc96fde5d30bdc
on base dev (supersedes closed #186, same commit).
exit_code: 0
working_dir: "/Users/jonah/Code/omni_worktrees/enum-registry/sea"
Loading