Repository navigation
fix(OMN-12418): drop $CONTRACT_REPO_DIR prefix from 501 check_value paths - #1850
Merged
Merged
Conversation
…paths (501 contracts) \$CONTRACT_REPO_DIR is unset in the evidence_collector — expanding it produces an absolute /drift/... or /contracts/... path that never resolves, silently failing every DoD check. The evidence_collector already sets cwd=\$OMNI_HOME/onex_change_control via _infer_occ_cwd, so relative paths resolve correctly. Fix: strip '"\$CONTRACT_REPO_DIR/' prefix from all 501 affected contracts. Paths fixed: drift/dod_receipts/..., contracts/..., evidence/..., src/... Sanity-verified OMN-11428 (3/3 verified) and OMN-12403 path fix (receipts on dev, cwd resolves correctly). yamlfmt + full pre-commit suite pass. OMN-12418
|
Warning Review limit reached
More reviews will be available in 28 minutes and 5 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (300)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
jonahgabriel
added this pull request to the merge queue
May 29, 2026
jonahgabriel
added a commit
that referenced
this pull request
Oct 2, 2026
…branch Merge origin/dev (cce17e6) into the branch of PR #12369, the hand-authored companion for omnibase_core#1850. The PR was DIRTY, so it could not merge, and the occ-preflight eligibility jobs on omnibase_core#1850 waited 1500s on "companion OCC#12369 is still OPEN" and failed closed. The one conflict was contracts/OMN-20375.yaml: dev added it in a0d8216 (#12367, the companion for omnimarket#3250, same ticket) and this branch added it too. The resolved file holds both: two evidence_requirements entries (PR #3250 and PR #1850) and four dod_evidence entries. The omnibase_core-pr-1850 check, run against 3a0c55c65e7722866fb69ac630bce17abe45606d, prints 1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sweep fix for the silent DoD-check-failure bug originally diagnosed in OMN-12403 (OCC PR #1838).
Root cause:
$CONTRACT_REPO_DIRis unset in the evidence_collector. Shell expansion produces/drift/dod_receipts/...(absolute path from filesystem root) which never exists → every command check silently fails → DoD guard blocks tickets that have real evidence.Fix: Drop the
"$CONTRACT_REPO_DIR/prefix from every affectedcheck_valuefield. The evidence_collector already setscwd=$OMNI_HOME/onex_change_controlvia_infer_occ_cwd, so relative paths (drift/dod_receipts/...,contracts/...,evidence/...,src/...) all resolve correctly.Contracts fixed
501 contracts across the full
contracts/directory. All instances used the single form"$CONTRACT_REPO_DIR/(no single-quote or unquoted variants found). Path prefixes affected:drift/dod_receipts/<ticket>/<id>/command.yaml(majority)contracts/<ticket>.yamlevidence/<ticket>/dod_report.jsonsrc/onex_change_control/boundaries/migration_inventory.yamlVerification
.201touchedOMN-12418