Skip to content

contracts(OMN-11946): add LLM closeout evidence - #1592

Merged
jonahgabriel merged 1 commit into
mainfrom
jonah/omn-11946-occ-evidence
May 25, 2026
Merged

jonahgabriel merged 1 commit into
mainfrom
jonah/omn-11946-occ-evidence

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented May 25, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Evidence

  • uv run python scripts/check_dod_evidence_present.py contracts/OMN-11946.yaml
  • uv run pre-commit run --files contracts/OMN-11946.yaml drift/dod_receipts/OMN-11946/dod-omnimarket-pr-839/command.yaml drift/dod_receipts/OMN-11946/dod-contract-overlay-boundary/command.yaml drift/dod_receipts/OMN-11946/dod-runtime-proof/command.yaml drift/dod_receipts/OMN-11946/dod-deploy-assessment/command.yaml

Downstream

Required by OmniNode-ai/omnimarket#839 Receipt Gate and deploy-gate.

Ticket

OMN-11946

Summary by CodeRabbit

  • Documentation
    • Added verification records and assessment documentation for ticket OMN-11946, including deployment assessment results and runtime proof validation.
    • Documented interface changes and contract verification checks across multiple systems.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 25, 2026 •

Copy link
Copy Markdown

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

This PR submits ticket OMN-11946 as a seam/interface change contract alongside corresponding proof-of-execution receipt documents. The contract defines five DOD evidence items, each with a verification receipt recording PASS status, execution metadata, and probe output.

Changes

Contract Ticket OMN-11946 Submission

Layer / File(s) Summary
Contract ticket definition
contracts/OMN-11946.yaml
Defines OMN-11946 with schema versioning, seam and interface change flags (touching protocols and public_api), disabled emergency bypass, and five verified DOD evidence entries with grep-based command checks referencing drift receipt paths.
DOD evidence verification receipts
drift/dod_receipts/OMN-11946/dod-contract-overlay-boundary/command.yaml, drift/dod_receipts/OMN-11946/dod-deploy-assessment/command.yaml, drift/dod_receipts/OMN-11946/dod-occ-pr-1592/command.yaml, drift/dod_receipts/OMN-11946/dod-omnimarket-pr-839/command.yaml, drift/dod_receipts/OMN-11946/dod-runtime-proof/command.yaml
Five YAML receipt records document verification of contract overlay boundary validation, deploy assessment check, OCC PR #1592 state, Omnimarket PR #839 state, and golden-chain routing/delegation runtime tests, each recording PASS status, execution timestamps, commit/contract hashes, runner/verifier identifiers, and probe output.

Estimated Code Review Effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A ticket emerges from contracts so fine,
With five proofs of passage, all passing the line!
Each receipt a small badge of verification cheer,
Contract OMN-11946, crystal clear! 🏆

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title clearly and specifically describes the main change: adding LLM closeout evidence for ticket OMN-11946 to the contracts system.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-11946-occ-evidence

Comment @coderabbitai help to get the list of available commands and usage tips.

@jonahgabriel
jonahgabriel enabled auto-merge (squash) May 25, 2026 01:38
@jonahgabriel
jonahgabriel force-pushed the jonah/omn-11946-occ-evidence branch from 4cb8a09 to 612e85f Compare May 25, 2026 01:40
@jonahgabriel
jonahgabriel merged commit b639233 into main May 25, 2026
35 of 36 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-11946-occ-evidence branch May 25, 2026 01:43
andywu42 pushed a commit to andywu42/onex_change_control that referenced this pull request Jun 10, 2026
…receipts for skip-token enforcement (OmniNode-ai#1005)

* contract(OMN-10967,OMN-10968,OMN-10969): add contracts and receipts for skip-token bypass removal

Binds three omnibase_infra/omniclaude PRs that close skip-token bypass mechanisms:
- OMN-10967: infra PR OmniNode-ai#1592 removes [skip-test-removal-gate:] bypass from integration-test-check.yml
- OMN-10968: omniclaude PR OmniNode-ai#1583 hardens pre-commit hook from advisory to BLOCKING
- OMN-10969: omniclaude PR OmniNode-ai#1584 extends CI gate to scan commit messages and changed files

* contract(OMN-10967,OMN-10968,OMN-10969): bind self-receipt SHAs to OCC commit bb35d85

* contract(OMN-10969): update receipt to PR head 463bee60 after CR fix commit

* contract(OMN-10970): add contract and receipts for org-wide skip-token gate rollout

* fix(OMN-10970): use valid commit SHAs in receipt files

* fix(OMN-10970): mark as seam ticket per CR review (cross-repo CI rollout)
andywu42 pushed a commit to andywu42/onex_change_control that referenced this pull request Jun 10, 2026
jonahgabriel added a commit that referenced this pull request Jul 3, 2026
…y deploy-gate evidence

- Revert scripts/validation/check_receipt_hardening.py + test to origin/dev
  (round-1 SCOPE DEVIATION: OCC companion must be net-new only; no supersede
  files are added here so the gate change was unnecessary).
- Append net-new dod-deploy dod_evidence entry to contracts/OMN-13888.yaml
  carrying the omnimarket #1592 post-merge runtime smoke (docker exec) so the
  deploy-gate on runtime-path PRs is satisfied (OMN-8912 / OMN-11423, OMN-9552
  reconciliation pattern).
- Add dod-deploy PASS receipt; re-bind all four receipts' contract_sha256 to the
  post-append whole-file hash (net-new files only; no merged file edited).

Refs OMN-13888.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant