Skip to content

contracts(OMN-11915): add codebase intelligence bridge node evidence - #1530

Merged
jonahgabriel merged 4 commits into
mainfrom
jonah/omn-11915-occ-contract
May 24, 2026
Merged

jonahgabriel merged 4 commits into
mainfrom
jonah/omn-11915-occ-contract

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented May 24, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Adds OCC contract and PASS receipts for omnimarket PR docs(OMN-9769): refresh infra PR 1535 receipts #823 (OMN-11915).
  • node_codebase_intelligence_bridge_effect: new ONEX effect node proxying codebase intelligence queries to Repowise CLI subprocess.
  • 16 unit tests pass covering all five operations (get_answer, get_context, get_symbol, search_codebase, get_why), error path, timeout path, missing _meta.
  • Deploy assessment: new node with no live deploy dependency; no docker exec or rpk topic produce required pre-merge.

Closes OMN-11915

Summary by CodeRabbit

Chores

  • Added verification contract definition for ticket OMN-11915 that specifies required evidence and compliance checks needed for this task
  • Recorded evidence documentation from multiple system verification procedures including unit test execution (16 tests passed), pull request validation and cross-reference checks, deployment readiness assessment, and self-verification protocols
  • All recorded system checks achieved passing status

Review Change Stack

Bind OCC contract and PASS receipts for omnimarket PR #823.
node_codebase_intelligence_bridge_effect: new ONEX effect node proxying
codebase intelligence queries to Repowise CLI subprocess. 16 unit tests pass.
@coderabbitai

coderabbitai Bot commented May 24, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@jonahgabriel, we couldn't start this review because you've used your available PR reviews for now.

Your plan currently allows 5 reviews/hour. Refill in 37 minutes and 41 seconds.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more review capacity refills, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7fe933f3-1763-4f45-9fa5-e47e39a518f4

📥 Commits

Reviewing files that changed from the base of the PR and between fd6359c and f417989.

📒 Files selected for processing (6)
  • contracts/OMN-11915.yaml
  • drift/dod_receipts/OMN-11915/dod-deploy-assessment/command.yaml
  • drift/dod_receipts/OMN-11915/dod-occ-pr-self/command.yaml
  • drift/dod_receipts/OMN-11915/dod-omnimarket-pr-823/command.yaml
  • drift/dod_receipts/OMN-11915/dod-unit-tests/command.yaml
  • src/onex_change_control/boundaries/migration_inventory.yaml
📝 Walkthrough

Walkthrough

This PR adds a definition-of-done (DoD) contract for ticket OMN-11915 along with evidence receipts documenting verification results. The contract specifies five required checks for the Bridge Node task, and corresponding YAML evidence files record that each check passed.

Changes

OMN-11915 Evidence Submission

Layer / File(s) Summary
Contract Definition
contracts/OMN-11915.yaml
Defines evidence requirements for the Bridge Node ticket, enumerating five verification steps and establishing manual evidence bindings with emergency bypass configuration (disabled).
Evidence Receipt Records
drift/dod_receipts/OMN-11915/dod-occ-pr-self/command.yaml, drift/dod_receipts/OMN-11915/dod-unit-tests/command.yaml, drift/dod_receipts/OMN-11915/dod-omnimarket-pr-823/command.yaml, drift/dod_receipts/OMN-11915/dod-deploy-assessment/command.yaml
Records verification results for PR title validation (confirming OMN-11915 reference), unit tests (16 passed), external PR checks, and deploy assessment. All checks report PASS status with execution metadata and checksums.

Estimated Code Review Effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

A rabbit hops through evidence today,
Five checks aligned in perfect display,
Bridge Node bright from test to deploy,
Each receipt marks proof with joy! 🐰✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding evidence contracts and receipts for ticket OMN-11915 related to the codebase intelligence bridge node feature.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-11915-occ-contract

Comment @coderabbitai help to get the list of available commands and usage tips.

Receipts produced after 2026-04-30 require contract_sha256. Adds the
field to all four OMN-11915 receipts to satisfy the Receipt Gate check.
@jonahgabriel
jonahgabriel force-pushed the jonah/omn-11915-occ-contract branch from e6bbf73 to fd6359c Compare May 24, 2026 18:38

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@drift/dod_receipts/OMN-11915/dod-occ-pr-self/command.yaml`:
- Line 20: Remove the duplicate YAML mapping key by deleting the second
occurrence of the "ticket_id" entry so the file contains a single "ticket_id"
mapping; keep the original ticket_id value and remove the redundant one to
ensure the YAML mapping has unique keys.
- Line 10: The commit_sha value in the self-binding OCC receipt for OMN-11915 is
incorrect and must be replaced with the actual commit SHA from the referenced
PR; open the command.yaml receipt for OMN-11915, locate the commit_sha field and
set it to the real commit SHA from the OmniNode-ai/onex_change_control PR that
this receipt should bind to (confirm the PR number referenced in the receipt or
commit message to find the correct SHA), then save the updated commit_sha value
so the receipt binds to an existing commit.
- Line 18: The contract_sha256 in
drift/dod_receipts/OMN-11915/dod-occ-pr-self/command.yaml is incorrect; update
the contract_sha256 field to match the actual SHA-256 of
contracts/OMN-11915.yaml
(sha256:3abcff7b23a2322ec85a548514aeeb89dcb163222cbb3b4644092daa52b466f8) or,
alternatively, change the contents of contracts/OMN-11915.yaml so its computed
SHA-256 matches the existing value in command.yaml; ensure the value of the
contract_sha256 key exactly matches the computed sha256:<hex> string.

In `@drift/dod_receipts/OMN-11915/dod-unit-tests/command.yaml`:
- Line 9: The commit_sha value currently set to
"a2ee0dccf4eafc6f2cdd133e4e0c19c351db7e1a" does not match the head of omnimarket
PR `#823`; update the commit_sha field in command.yaml to the PR head value
"e1d2ba8e629d84aca2d25c9ce74228728b4794a5" (or add a brief justification in the
file explaining why a different commit is intentionally referenced) so the
receipt references the correct PR head.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 931301a8-7755-42e6-88b0-9130d573913c

📥 Commits

Reviewing files that changed from the base of the PR and between 6338131 and fd6359c.

📒 Files selected for processing (5)
  • contracts/OMN-11915.yaml
  • drift/dod_receipts/OMN-11915/dod-deploy-assessment/command.yaml
  • drift/dod_receipts/OMN-11915/dod-occ-pr-self/command.yaml
  • drift/dod_receipts/OMN-11915/dod-omnimarket-pr-823/command.yaml
  • drift/dod_receipts/OMN-11915/dod-unit-tests/command.yaml

Comment thread drift/dod_receipts/OMN-11915/dod-occ-pr-self/command.yaml Outdated
Comment thread drift/dod_receipts/OMN-11915/dod-occ-pr-self/command.yaml Outdated
Comment thread drift/dod_receipts/OMN-11915/dod-occ-pr-self/command.yaml Outdated
Comment thread drift/dod_receipts/OMN-11915/dod-unit-tests/command.yaml Outdated
@jonahgabriel
jonahgabriel force-pushed the jonah/omn-11915-occ-contract branch 2 times, most recently from 819b1b0 to 8fc57cb Compare May 24, 2026 18:55
yamlfmt hook reformatted long lines in all four receipts to satisfy
pre-commit requirements in CI.
@jonahgabriel
jonahgabriel force-pushed the jonah/omn-11915-occ-contract branch from 8fc57cb to f417989 Compare May 24, 2026 19:01
@jonahgabriel
jonahgabriel merged commit 4c28cab into main May 24, 2026
33 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-11915-occ-contract branch May 24, 2026 19:05
andywu42 pushed a commit to andywu42/onex_change_control that referenced this pull request Jun 10, 2026
…OCC contract (OmniNode-ai#808)

* docs(OMN-10657): add OCC contract for bifrost contract-driven routing

Central evidence contract for OMN-10657 — NodeDelegationRoutingReducer
now resolves endpoint URLs from the deployed bifrost delegation contract
instead of environment variables.

* docs(OMN-10657): add DoD receipt evidence for bifrost contract-driven routing

Five dod_evidence receipts for OMN-10657:
- dod-unit-tests: 75 delegation tests pass (routing reducer + integration)
- dod-integration-test: bifrost contract loading from source file verified
- dod-precommit: pre-commit hooks pass for all touched files
- dod-pr-1530-head: bound to omnibase_infra PR OmniNode-ai#1530 head SHA
- dod-occ-pr: OCC PR OmniNode-ai#807 confirmed with head SHA

* docs(OMN-10656): bind PR OmniNode-ai#1540 SQLite schema alignment to OCC contract

Add dod-pr-1540-head receipt and contract entry so the receipt gate
accepts omniclaude PR OmniNode-ai#1540 (fix: align SQLite schema with projection handler).

* docs(OMN-10656): add self-binding OCC#808 receipt for eligibility gate
andywu42 pushed a commit to andywu42/onex_change_control that referenced this pull request Jun 10, 2026
…OmniNode-ai#811)

* docs(OMN-10657): add OCC contract for bifrost contract-driven routing

Central evidence contract for OMN-10657 — NodeDelegationRoutingReducer
now resolves endpoint URLs from the deployed bifrost delegation contract
instead of environment variables.

* docs(OMN-10657): add DoD receipt evidence for bifrost contract-driven routing

Five dod_evidence receipts for OMN-10657:
- dod-unit-tests: 75 delegation tests pass (routing reducer + integration)
- dod-integration-test: bifrost contract loading from source file verified
- dod-precommit: pre-commit hooks pass for all touched files
- dod-pr-1530-head: bound to omnibase_infra PR OmniNode-ai#1530 head SHA
- dod-occ-pr: OCC PR OmniNode-ai#807 confirmed with head SHA

* feat(OMN-10697): add ticket contract for Opus grading LLM effect node

* feat(OMN-10697): add DoD receipt evidence for grader node
andywu42 pushed a commit to andywu42/onex_change_control that referenced this pull request Jun 10, 2026
…OmniNode-ai#807)

* docs(OMN-10657): add OCC contract for bifrost contract-driven routing

Central evidence contract for OMN-10657 — NodeDelegationRoutingReducer
now resolves endpoint URLs from the deployed bifrost delegation contract
instead of environment variables.

* docs(OMN-10657): add DoD receipt evidence for bifrost contract-driven routing

Five dod_evidence receipts for OMN-10657:
- dod-unit-tests: 75 delegation tests pass (routing reducer + integration)
- dod-integration-test: bifrost contract loading from source file verified
- dod-precommit: pre-commit hooks pass for all touched files
- dod-pr-1530-head: bound to omnibase_infra PR OmniNode-ai#1530 head SHA
- dod-occ-pr: OCC PR OmniNode-ai#807 confirmed with head SHA

* docs(OMN-10657): bind omniclaude runtime PR evidence
andywu42 pushed a commit to andywu42/onex_change_control that referenced this pull request Jun 10, 2026
…g validator (OmniNode-ai#813)

* docs(OMN-10657): add OCC contract for bifrost contract-driven routing

Central evidence contract for OMN-10657 — NodeDelegationRoutingReducer
now resolves endpoint URLs from the deployed bifrost delegation contract
instead of environment variables.

* docs(OMN-10657): add DoD receipt evidence for bifrost contract-driven routing

Five dod_evidence receipts for OMN-10657:
- dod-unit-tests: 75 delegation tests pass (routing reducer + integration)
- dod-integration-test: bifrost contract loading from source file verified
- dod-precommit: pre-commit hooks pass for all touched files
- dod-pr-1530-head: bound to omnibase_infra PR OmniNode-ai#1530 head SHA
- dod-occ-pr: OCC PR OmniNode-ai#807 confirmed with head SHA

* docs(OMN-10688): add contract and receipt evidence for contract-config validator

Adds OCC contract and dod_evidence receipts for omnibase_core PR OmniNode-ai#1053
(AST-based contract-config compliance validator).

* docs(OMN-10688): update dod-occ-pr receipt with OCC PR OmniNode-ai#813 binding

* docs(OMN-10688): normalize receipt worktree paths
andywu42 pushed a commit to andywu42/onex_change_control that referenced this pull request Jun 10, 2026
…de (OmniNode-ai#810)

* docs(OMN-10657): add OCC contract for bifrost contract-driven routing

Central evidence contract for OMN-10657 — NodeDelegationRoutingReducer
now resolves endpoint URLs from the deployed bifrost delegation contract
instead of environment variables.

* docs(OMN-10657): add DoD receipt evidence for bifrost contract-driven routing

Five dod_evidence receipts for OMN-10657:
- dod-unit-tests: 75 delegation tests pass (routing reducer + integration)
- dod-integration-test: bifrost contract loading from source file verified
- dod-precommit: pre-commit hooks pass for all touched files
- dod-pr-1530-head: bound to omnibase_infra PR OmniNode-ai#1530 head SHA
- dod-occ-pr: OCC PR OmniNode-ai#807 confirmed with head SHA

* docs(OMN-10696): add OCC contract and DoD receipts for ADR draft generation node

Binds omnimarket PR OmniNode-ai#559 (pure COMPUTE node, 22 unit tests, no runtime
deploy required) to the central change-control record.

* docs(OMN-10696): add dod-occ-pr receipt binding OCC PR OmniNode-ai#810

* docs(OMN-10696): normalize receipt worktree paths
andywu42 pushed a commit to andywu42/onex_change_control that referenced this pull request Jun 10, 2026
…ith Pydantic BaseModel (OmniNode-ai#809)

* docs(OMN-10657): add OCC contract for bifrost contract-driven routing

Central evidence contract for OMN-10657 — NodeDelegationRoutingReducer
now resolves endpoint URLs from the deployed bifrost delegation contract
instead of environment variables.

* docs(OMN-10657): add DoD receipt evidence for bifrost contract-driven routing

Five dod_evidence receipts for OMN-10657:
- dod-unit-tests: 75 delegation tests pass (routing reducer + integration)
- dod-integration-test: bifrost contract loading from source file verified
- dod-precommit: pre-commit hooks pass for all touched files
- dod-pr-1530-head: bound to omnibase_infra PR OmniNode-ai#1530 head SHA
- dod-occ-pr: OCC PR OmniNode-ai#807 confirmed with head SHA

* feat(OMN-9739): replace @DataClass EnvContract with ModelEnvContract(BaseModel)

Migrates EnvContract, Violation, and ScanResult in check_env_var_contract.py
from @DataClass to Pydantic BaseModel (frozen=True, extra="forbid") per ONEX
no-dataclass rule. EnvContract alias preserved for test backward compatibility.

* docs(OMN-9739): add OCC evidence for env contract models

* fix(OMN-9739): align env contract model names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant