Repository navigation
contracts(OMN-11915): add codebase intelligence bridge node evidence - #1530
Conversation
Bind OCC contract and PASS receipts for omnimarket PR #823. node_codebase_intelligence_bridge_effect: new ONEX effect node proxying codebase intelligence queries to Repowise CLI subprocess. 16 unit tests pass.
|
Warning Review limit reached
Your plan currently allows 5 reviews/hour. Refill in 37 minutes and 41 seconds. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more review capacity refills, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThis PR adds a definition-of-done (DoD) contract for ticket OMN-11915 along with evidence receipts documenting verification results. The contract specifies five required checks for the Bridge Node task, and corresponding YAML evidence files record that each check passed. ChangesOMN-11915 Evidence Submission
Estimated Code Review Effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Receipts produced after 2026-04-30 require contract_sha256. Adds the field to all four OMN-11915 receipts to satisfy the Receipt Gate check.
e6bbf73 to
fd6359c
Compare
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@drift/dod_receipts/OMN-11915/dod-occ-pr-self/command.yaml`:
- Line 20: Remove the duplicate YAML mapping key by deleting the second
occurrence of the "ticket_id" entry so the file contains a single "ticket_id"
mapping; keep the original ticket_id value and remove the redundant one to
ensure the YAML mapping has unique keys.
- Line 10: The commit_sha value in the self-binding OCC receipt for OMN-11915 is
incorrect and must be replaced with the actual commit SHA from the referenced
PR; open the command.yaml receipt for OMN-11915, locate the commit_sha field and
set it to the real commit SHA from the OmniNode-ai/onex_change_control PR that
this receipt should bind to (confirm the PR number referenced in the receipt or
commit message to find the correct SHA), then save the updated commit_sha value
so the receipt binds to an existing commit.
- Line 18: The contract_sha256 in
drift/dod_receipts/OMN-11915/dod-occ-pr-self/command.yaml is incorrect; update
the contract_sha256 field to match the actual SHA-256 of
contracts/OMN-11915.yaml
(sha256:3abcff7b23a2322ec85a548514aeeb89dcb163222cbb3b4644092daa52b466f8) or,
alternatively, change the contents of contracts/OMN-11915.yaml so its computed
SHA-256 matches the existing value in command.yaml; ensure the value of the
contract_sha256 key exactly matches the computed sha256:<hex> string.
In `@drift/dod_receipts/OMN-11915/dod-unit-tests/command.yaml`:
- Line 9: The commit_sha value currently set to
"a2ee0dccf4eafc6f2cdd133e4e0c19c351db7e1a" does not match the head of omnimarket
PR `#823`; update the commit_sha field in command.yaml to the PR head value
"e1d2ba8e629d84aca2d25c9ce74228728b4794a5" (or add a brief justification in the
file explaining why a different commit is intentionally referenced) so the
receipt references the correct PR head.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 931301a8-7755-42e6-88b0-9130d573913c
📒 Files selected for processing (5)
contracts/OMN-11915.yamldrift/dod_receipts/OMN-11915/dod-deploy-assessment/command.yamldrift/dod_receipts/OMN-11915/dod-occ-pr-self/command.yamldrift/dod_receipts/OMN-11915/dod-omnimarket-pr-823/command.yamldrift/dod_receipts/OMN-11915/dod-unit-tests/command.yaml
819b1b0 to
8fc57cb
Compare
yamlfmt hook reformatted long lines in all four receipts to satisfy pre-commit requirements in CI.
8fc57cb to
f417989
Compare
…OCC contract (OmniNode-ai#808) * docs(OMN-10657): add OCC contract for bifrost contract-driven routing Central evidence contract for OMN-10657 — NodeDelegationRoutingReducer now resolves endpoint URLs from the deployed bifrost delegation contract instead of environment variables. * docs(OMN-10657): add DoD receipt evidence for bifrost contract-driven routing Five dod_evidence receipts for OMN-10657: - dod-unit-tests: 75 delegation tests pass (routing reducer + integration) - dod-integration-test: bifrost contract loading from source file verified - dod-precommit: pre-commit hooks pass for all touched files - dod-pr-1530-head: bound to omnibase_infra PR OmniNode-ai#1530 head SHA - dod-occ-pr: OCC PR OmniNode-ai#807 confirmed with head SHA * docs(OMN-10656): bind PR OmniNode-ai#1540 SQLite schema alignment to OCC contract Add dod-pr-1540-head receipt and contract entry so the receipt gate accepts omniclaude PR OmniNode-ai#1540 (fix: align SQLite schema with projection handler). * docs(OMN-10656): add self-binding OCC#808 receipt for eligibility gate
…OmniNode-ai#811) * docs(OMN-10657): add OCC contract for bifrost contract-driven routing Central evidence contract for OMN-10657 — NodeDelegationRoutingReducer now resolves endpoint URLs from the deployed bifrost delegation contract instead of environment variables. * docs(OMN-10657): add DoD receipt evidence for bifrost contract-driven routing Five dod_evidence receipts for OMN-10657: - dod-unit-tests: 75 delegation tests pass (routing reducer + integration) - dod-integration-test: bifrost contract loading from source file verified - dod-precommit: pre-commit hooks pass for all touched files - dod-pr-1530-head: bound to omnibase_infra PR OmniNode-ai#1530 head SHA - dod-occ-pr: OCC PR OmniNode-ai#807 confirmed with head SHA * feat(OMN-10697): add ticket contract for Opus grading LLM effect node * feat(OMN-10697): add DoD receipt evidence for grader node
…OmniNode-ai#807) * docs(OMN-10657): add OCC contract for bifrost contract-driven routing Central evidence contract for OMN-10657 — NodeDelegationRoutingReducer now resolves endpoint URLs from the deployed bifrost delegation contract instead of environment variables. * docs(OMN-10657): add DoD receipt evidence for bifrost contract-driven routing Five dod_evidence receipts for OMN-10657: - dod-unit-tests: 75 delegation tests pass (routing reducer + integration) - dod-integration-test: bifrost contract loading from source file verified - dod-precommit: pre-commit hooks pass for all touched files - dod-pr-1530-head: bound to omnibase_infra PR OmniNode-ai#1530 head SHA - dod-occ-pr: OCC PR OmniNode-ai#807 confirmed with head SHA * docs(OMN-10657): bind omniclaude runtime PR evidence
…g validator (OmniNode-ai#813) * docs(OMN-10657): add OCC contract for bifrost contract-driven routing Central evidence contract for OMN-10657 — NodeDelegationRoutingReducer now resolves endpoint URLs from the deployed bifrost delegation contract instead of environment variables. * docs(OMN-10657): add DoD receipt evidence for bifrost contract-driven routing Five dod_evidence receipts for OMN-10657: - dod-unit-tests: 75 delegation tests pass (routing reducer + integration) - dod-integration-test: bifrost contract loading from source file verified - dod-precommit: pre-commit hooks pass for all touched files - dod-pr-1530-head: bound to omnibase_infra PR OmniNode-ai#1530 head SHA - dod-occ-pr: OCC PR OmniNode-ai#807 confirmed with head SHA * docs(OMN-10688): add contract and receipt evidence for contract-config validator Adds OCC contract and dod_evidence receipts for omnibase_core PR OmniNode-ai#1053 (AST-based contract-config compliance validator). * docs(OMN-10688): update dod-occ-pr receipt with OCC PR OmniNode-ai#813 binding * docs(OMN-10688): normalize receipt worktree paths
…de (OmniNode-ai#810) * docs(OMN-10657): add OCC contract for bifrost contract-driven routing Central evidence contract for OMN-10657 — NodeDelegationRoutingReducer now resolves endpoint URLs from the deployed bifrost delegation contract instead of environment variables. * docs(OMN-10657): add DoD receipt evidence for bifrost contract-driven routing Five dod_evidence receipts for OMN-10657: - dod-unit-tests: 75 delegation tests pass (routing reducer + integration) - dod-integration-test: bifrost contract loading from source file verified - dod-precommit: pre-commit hooks pass for all touched files - dod-pr-1530-head: bound to omnibase_infra PR OmniNode-ai#1530 head SHA - dod-occ-pr: OCC PR OmniNode-ai#807 confirmed with head SHA * docs(OMN-10696): add OCC contract and DoD receipts for ADR draft generation node Binds omnimarket PR OmniNode-ai#559 (pure COMPUTE node, 22 unit tests, no runtime deploy required) to the central change-control record. * docs(OMN-10696): add dod-occ-pr receipt binding OCC PR OmniNode-ai#810 * docs(OMN-10696): normalize receipt worktree paths
…ith Pydantic BaseModel (OmniNode-ai#809) * docs(OMN-10657): add OCC contract for bifrost contract-driven routing Central evidence contract for OMN-10657 — NodeDelegationRoutingReducer now resolves endpoint URLs from the deployed bifrost delegation contract instead of environment variables. * docs(OMN-10657): add DoD receipt evidence for bifrost contract-driven routing Five dod_evidence receipts for OMN-10657: - dod-unit-tests: 75 delegation tests pass (routing reducer + integration) - dod-integration-test: bifrost contract loading from source file verified - dod-precommit: pre-commit hooks pass for all touched files - dod-pr-1530-head: bound to omnibase_infra PR OmniNode-ai#1530 head SHA - dod-occ-pr: OCC PR OmniNode-ai#807 confirmed with head SHA * feat(OMN-9739): replace @DataClass EnvContract with ModelEnvContract(BaseModel) Migrates EnvContract, Violation, and ScanResult in check_env_var_contract.py from @DataClass to Pydantic BaseModel (frozen=True, extra="forbid") per ONEX no-dataclass rule. EnvContract alias preserved for test backward compatibility. * docs(OMN-9739): add OCC evidence for env contract models * fix(OMN-9739): align env contract model names
Summary
node_codebase_intelligence_bridge_effect: new ONEX effect node proxying codebase intelligence queries to Repowise CLI subprocess.Closes OMN-11915
Summary by CodeRabbit
Chores