Skip to content

evidence(OMN-11775): refresh delegation PR heads - #1469

Merged
jonahgabriel merged 5 commits into
mainfrom
jonah/omn-11775-11777-deploy-evidence
May 23, 2026
Merged

jonahgabriel merged 5 commits into
mainfrom
jonah/omn-11775-11777-deploy-evidence

Conversation

@jonahgabriel

Copy link
Copy Markdown
Contributor

Summary

Verification

  • uv run validate-yaml contracts/OMN-11775.yaml contracts/OMN-11776.yaml contracts/OMN-11777.yaml
  • uv run pre-commit run --files contracts/OMN-11775.yaml contracts/OMN-11776.yaml contracts/OMN-11777.yaml drift/dod_receipts/OMN-11775/dod-deploy-assessment/command.yaml drift/dod_receipts/OMN-11775/dod-occ-batch-pr/command.yaml drift/dod_receipts/OMN-11775/dod-omnimarket-pr-780/command.yaml drift/dod_receipts/OMN-11775/dod-occ-pr-1466/command.yaml drift/dod_receipts/OMN-11776/dod-deploy-assessment/command.yaml drift/dod_receipts/OMN-11776/dod-occ-batch-pr/command.yaml drift/dod_receipts/OMN-11776/dod-omnimarket-pr-779/command.yaml drift/dod_receipts/OMN-11777/dod-deploy-assessment/command.yaml drift/dod_receipts/OMN-11777/dod-occ-batch-pr/command.yaml drift/dod_receipts/OMN-11777/dod-omnimarket-pr-778/command.yaml
  • local execution of all dod_evidence check_value commands for OMN-11775, OMN-11776, OMN-11777

Evidence-Ticket: OMN-11775
Evidence-Ticket: OMN-11776
Evidence-Source: 8279f7d

@coderabbitai

coderabbitai Bot commented May 23, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@jonahgabriel, we couldn't start this review because you've used your available PR reviews for now.

Your plan currently allows 1 review/hour. Refill in 33 minutes and 48 seconds.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more review capacity refills, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2646d962-867c-4a56-847f-8ac039b4cfdc

📥 Commits

Reviewing files that changed from the base of the PR and between 27ac51a and fcc508c.

📒 Files selected for processing (10)
  • contracts/OMN-11775.yaml
  • contracts/OMN-11776.yaml
  • drift/dod_receipts/OMN-11775/dod-deploy-assessment/command.yaml
  • drift/dod_receipts/OMN-11775/dod-occ-batch-pr/command.yaml
  • drift/dod_receipts/OMN-11775/dod-occ-pr-1466/command.yaml
  • drift/dod_receipts/OMN-11775/dod-occ-pr-1469/command.yaml
  • drift/dod_receipts/OMN-11775/dod-omnimarket-pr-780/command.yaml
  • drift/dod_receipts/OMN-11776/dod-deploy-assessment/command.yaml
  • drift/dod_receipts/OMN-11776/dod-occ-batch-pr/command.yaml
  • drift/dod_receipts/OMN-11776/dod-omnimarket-pr-779/command.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-11775-11777-deploy-evidence

Comment @coderabbitai help to get the list of available commands and usage tips.

…-deploy-evidence

# Conflicts:
#	contracts/OMN-11775.yaml
#	contracts/OMN-11776.yaml
#	drift/dod_receipts/OMN-11775/dod-deploy-assessment/command.yaml
#	drift/dod_receipts/OMN-11775/dod-occ-batch-pr/command.yaml
#	drift/dod_receipts/OMN-11775/dod-occ-pr-1466/command.yaml
#	drift/dod_receipts/OMN-11775/dod-omnimarket-pr-780/command.yaml
#	drift/dod_receipts/OMN-11776/dod-deploy-assessment/command.yaml
#	drift/dod_receipts/OMN-11776/dod-occ-batch-pr/command.yaml
#	drift/dod_receipts/OMN-11776/dod-omnimarket-pr-779/command.yaml
@jonahgabriel
jonahgabriel merged commit afb51c2 into main May 23, 2026
33 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-11775-11777-deploy-evidence branch May 23, 2026 22:06
jonahgabriel added a commit that referenced this pull request Sep 17, 2026
… state (#10064)

* evidence(OMN-18381): bind six criteria to behaviour proofs, not merge state

The sweep held this ticket on a proof-class gap: "2/6 checks verified, 0
failed -- and not one of them executed the claimed behavior. Every passing
check binds merge state (a PR is merged) or is a surrogate (a file exists, a
generic suite ran)."

The three pre-existing items are exactly that shape -- two `gh pr view` merge
probes and `tests/test_evidence_admissibility.py`, a generic OCC suite -- and
none declares `binds_ac`. They are left untouched.

Six items are appended, one per criterion, each running a test class written
for that criterion at cwd ${OMNI_HOME}/omninode_infra. Every class carries a
demonstrated negative control: the artifact it asserts over was mutated and the
class observed to fail, then reverted.

  AC1/AC2  seam -> runs-on: ubuntu-latest   3 failed, 11 passed
  AC3      hourly -> 15-minute cadence      1 failed, 13 passed
  AC4      bucket renamed                   1 failed, 13 passed
  AC5      staleness bar id stripped        1 failed, 13 passed
  AC6      aws probe removed                2 failed, 12 passed
  restored                                 14 passed

All six ACs were separately re-measured against dev before any of this was
written, and all six are already substantively satisfied -- PR #1469 merged
2026-09-15. What was missing was proof of the right class, not the work.

AC2 binds a test asserting INDEPENDENCE from hosted billing, which is a
property of the tree, and deliberately not that the fleet is up or the budget
raised: the org Actions budget was still $600 with prevent_further_usage true
when this was written.

Ordering: the test file lands in omninode_infra#1539, which is gated by `OCC
Companion Merged Gate (OMN-15214)` on this companion, so this merges first --
the same order OMN-16504 used (OCC#7214 before #1019).

Receipts are `test_passes.yaml`, not `command.yaml`: the eligibility gate keys
a receipt by `<ticket>:<item>:<check_type>`, and a test_passes check with a
command.yaml receipt reads as missing.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PacR7UupWUbZ2Hf8YnyXZV

* evidence(OMN-18381): self-bind to OCC companion PR #10064

The occ-preflight `missing_occ_self_bind` leg requires the PR carrying a
contract to bind itself, which needs the PR number and so could not land in the
first commit.

Appending the entry moves `contract_sha256`, so all six behaviour receipts are
resynced. Their `contract_entry_sha256` values are unaffected by the append
(OMN-13888), and are recomputed rather than assumed.

Verified with the same validator the gate runs: no missing receipts, no stale
bindings for this ticket.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PacR7UupWUbZ2Hf8YnyXZV

* fix(OMN-18381): bind receipts to full product commit

* fix(OMN-18381): expand remaining receipt commit bindings

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: jonahgabriel <jonah@omninode.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant