Skip to content

fix(OMN-11768): post-yamlfmt hash sync and deploy-smoke evidence - #1420

Closed
jonahgabriel wants to merge 4 commits into
mainfrom
jonah/omn-11768-occ-receipt-fix
Closed

jonahgabriel wants to merge 4 commits into
mainfrom
jonah/omn-11768-occ-receipt-fix

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented May 23, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Updates all five OMN-11768 dod_evidence receipts to carry the post-yamlfmt contract_sha256 (1906cf88...) that matches the current contracts/OMN-11768.yaml
  • Adds dod-deploy-smoke receipt (docker exec HandlerProjectionLlmRouting import smoke) to satisfy the deploy-gate requirement on omnimarket PR docs(OMN-10581): OCC contract and dod receipts for omnimarket#544 #772

Related

OMN-11768

Evidence-Ticket: OMN-11768
Evidence-Source: self

Summary by CodeRabbit

  • Chores
    • Updated internal verification system records and metadata for OMN-11768.
    • Added new verification checks for handler import functionality and OCC fix PR binding validation.
    • Corrected PR and branch references in verification records.

Review Change Stack

- All three receipts now have pr_number: 772 and commit_sha from omnimarket
- Contract updated to add dod-occ-pr evidence item (receipt to follow)
- dod-omnimarket-pr check_value now greps pr_number: 772
- All receipt contract_sha256 updated to match new contract hash
Enables OCC eligibility gate to bind via pr_number: 1414 (this PR).
… add deploy-smoke evidence

All five dod_evidence receipts now carry contract_sha256 matching the
yamlfmt-normalized contracts/OMN-11768.yaml (1906cf88...). Adds
dod-deploy-smoke receipt (docker exec HandlerProjectionLlmRouting) to
satisfy the deploy-gate check_value requirement on omnimarket PR #772.
@coderabbitai

coderabbitai Bot commented May 23, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1cc38482-1c66-4829-a0b0-a1b0aaeb3132

📥 Commits

Reviewing files that changed from the base of the PR and between eb4f47e and 9b59faa.

📒 Files selected for processing (6)
  • contracts/OMN-11768.yaml
  • drift/dod_receipts/OMN-11768/dod-contract-wired/command.yaml
  • drift/dod_receipts/OMN-11768/dod-deploy-smoke/command.yaml
  • drift/dod_receipts/OMN-11768/dod-occ-pr/command.yaml
  • drift/dod_receipts/OMN-11768/dod-omnimarket-pr/command.yaml
  • drift/dod_receipts/OMN-11768/dod-tests-pass/command.yaml

📝 Walkthrough

Walkthrough

This PR updates the OMN-11768 Demonstration of Drift (DOD) evidence configuration and records. It corrects a PR number metadata discrepancy from 1404 to 772, defines two new evidence checks for OCC PR binding and runtime container verification, and refreshes receipt metadata across multiple evidence files.

Changes

DOD Evidence Definition and Receipt Updates

Layer / File(s) Summary
Contract definition and evidence configuration
contracts/OMN-11768.yaml
Updated the main contract to correct pr_number: 772 in the dod-omnimarket-pr check and added two new DOD evidence entries: dod-occ-pr confirming the OCC fix PR binds evidence to onex_change_control, and dod-deploy-smoke validating HandlerProjectionLlmRouting importability via Python import in the runtime container.
New evidence receipt records
drift/dod_receipts/OMN-11768/dod-deploy-smoke/command.yaml, drift/dod_receipts/OMN-11768/dod-occ-pr/command.yaml
Created two new evidence receipt files: dod-deploy-smoke/command.yaml recording the Docker-based Python import smoke test with PASS status and contract verification metadata, and dod-occ-pr/command.yaml recording the grep command verification binding the receipt to OCC PR #1414 with PASS status.
Existing evidence receipt metadata refresh
drift/dod_receipts/OMN-11768/dod-contract-wired/command.yaml, drift/dod_receipts/OMN-11768/dod-omnimarket-pr/command.yaml, drift/dod_receipts/OMN-11768/dod-tests-pass/command.yaml
Updated metadata fields across three existing receipt files: contract_sha256, commit_sha, pr_number, run_timestamp, and branch were refreshed to reflect the corrected PR routing and golden chain branch context, while all PASS statuses and probe command outputs remained consistent.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • OmniNode-ai/onex_change_control#1300: Both PRs modify the DoD receipt command.yaml metadata to include/update contract_sha256 for receipt verification (OMN-11768 in the main PR, OMN-11424 in the retrieved PR).
  • OmniNode-ai/onex_change_control#1145: Both PRs update dod-*/command.yaml evidence/check_value grep-style receipts to bind and verify specific onex_change_control PR numbers (main PR for OMN-11768/OCC fix receipt, retrieved PR for OMN-11261/OCC PR receipts).

Poem

🐰 A golden chain of proofs so true,
Evidence receipts refresh anew,
PR numbers corrected with care,
Handlers imported, smoke tests fair! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: fixing hash synchronization across DOD receipts after YAML formatting and adding deploy-smoke evidence as required.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-11768-occ-receipt-fix
⚔️ Resolve merge conflicts
  • Resolve merge conflict in branch jonah/omn-11768-occ-receipt-fix

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant