Skip to content

docs(OMN-10813,OMN-7777): add OCC evidence for DEC-003 migration and dead flag removal - #1315

Merged
jonahgabriel merged 9 commits into
mainfrom
jonah/omn-10813-7777-occ
May 22, 2026
Merged

jonahgabriel merged 9 commits into
mainfrom
jonah/omn-10813-7777-occ

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented May 22, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Evidence

Summary by CodeRabbit

  • Chores

    • Added new contract definitions with structured metadata and evidence requirements for internal compliance tracking.
    • Updated existing contracts to a more detailed, specific specification with enhanced verification and audit records.
  • Documentation

    • Added and expanded verification receipts and evidence entries to document QA checks and fulfillment status.

Review Change Stack

…dead flag removal

- contracts/OMN-10813.yaml: enriched contract for DEC-003 ONEX_EXCLUDE bypass removal
  (4 effect nodes: contract_persistence, delta_bundle, decision_store, delta_metrics)
- contracts/OMN-7777.yaml: enriched contract for DUAL_PUBLISH_LEGACY_TOPICS dead flag removal
- drift/dod_receipts/OMN-10813/dod-pr-1698-open/command.yaml: omnibase_infra PR #1698 receipt
- drift/dod_receipts/OMN-7777/dod-pr-1632-open/command.yaml: omniclaude PR #1632 receipt
@coderabbitai

coderabbitai Bot commented May 22, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 394ab7c5-0a34-40f5-a949-0e3493f900dd

📥 Commits

Reviewing files that changed from the base of the PR and between ef4664f and d19f1f9.

📒 Files selected for processing (4)
  • drift/dod_receipts/OMN-10813/dod-occ-self/command.yaml
  • drift/dod_receipts/OMN-10813/dod-pr-1698-open/command.yaml
  • drift/dod_receipts/OMN-7777/dod-occ-self/command.yaml
  • drift/dod_receipts/OMN-7777/dod-pr-1632-open/command.yaml
✅ Files skipped from review due to trivial changes (3)
  • drift/dod_receipts/OMN-10813/dod-pr-1698-open/command.yaml
  • drift/dod_receipts/OMN-7777/dod-occ-self/command.yaml
  • drift/dod_receipts/OMN-10813/dod-occ-self/command.yaml

📝 Walkthrough

Walkthrough

This PR adds a new contract (OMN-10813), updates an existing contract (OMN-7777), and adds corresponding drift evidence receipts that capture and assert gh CLI probe command outputs.

Changes

Contract Definitions and Evidence Records

Layer / File(s) Summary
OMN-10813 contract definition with evidence receipts
contracts/OMN-10813.yaml, drift/dod_receipts/OMN-10813/*
Adds OMN-10813 contract with schema metadata, a migration summary, explicit gh CLI evidence commands, and DOD grep assertions. Two command receipt records capture gh pr view probe results and execution metadata for self-validation and PR #1698.
OMN-7777 contract enrichment with evidence receipts
contracts/OMN-7777.yaml, drift/dod_receipts/OMN-7777/*
Enriches OMN-7777 with schema_version, expanded title/summary, replaces generic CI checks with explicit gh pr view/gh pr checks commands referencing PR #1632, and replaces generated DOD entries with two verified receipt references. Two command receipt records capture gh pr view probe results and execution metadata for self-validation and PR #1632.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A contract hops in, tidy and spry,
Receipts record probes with a careful eye,
OMN-10813 joins the fold,
OMN-7777 polished and told,
Git probes pass — the rabbits sigh.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: adding OCC evidence for two contract tickets (OMN-10813 and OMN-7777) related to DEC-003 migration and dead flag removal, which directly matches the PR's primary objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-10813-7777-occ

Comment @coderabbitai help to get the list of available commands and usage tips.

@jonahgabriel
jonahgabriel enabled auto-merge (squash) May 22, 2026 05:17

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@drift/dod_receipts/OMN-10813/dod-occ-self/command.yaml`:
- Line 10: Replace the placeholder contract_sha256 in this receipt by computing
the SHA-256 digest of the final contract file and writing that exact digest into
contract_sha256; specifically, compute the SHA-256 of contracts/OMN-10813.yaml
at the PR head (binary/text canonicalization as used by your repo's hashing
convention), then update the contract_sha256 field in command.yaml (currently
"sha256:placeholder-omn-10813-occ-self") to "sha256:<actual-digest>" so the
receipt is bound to the final contract content.

In `@drift/dod_receipts/OMN-10813/dod-pr-1698-open/command.yaml`:
- Line 10: Replace the placeholder in the receipt's contract_sha256 field with
the actual SHA-256 digest of the final contract file by computing the SHA-256 of
contracts/OMN-10813.yaml at the PR head and setting contract_sha256 to that
exact "sha256:<hex>" value (overwriting "sha256:placeholder-omn-10813"); ensure
the digest matches the contract content used in this PR so the receipt is bound
to the final contract version.

In `@drift/dod_receipts/OMN-7777/dod-occ-self/command.yaml`:
- Line 10: Replace the placeholder contract_sha256 in command.yaml with the
actual SHA-256 digest of the contract file for OMN-7777: compute the SHA-256 of
contracts/OMN-7777.yaml from the PR HEAD commit (e.g., compute the file bytes’
sha256 on the PR head, or use git show <HEAD>:contracts/OMN-7777.yaml |
sha256sum) and set contract_sha256: "sha256:<actual-digest>" so the receipt’s
contract_sha256 matches the contract file hash; update the value where
contract_sha256 is currently "sha256:placeholder-omn-7777-occ-self".

In `@drift/dod_receipts/OMN-7777/dod-pr-1632-open/command.yaml`:
- Line 10: Replace the placeholder value for the contract_sha256 field with the
actual SHA-256 digest of the final contract file; compute the hash for
contracts/OMN-7777.yaml at the PR head (e.g. run LC_ALL=C shasum -a 256
contracts/OMN-7777.yaml), then set contract_sha256 to the form
"sha256:<computed-hex-digest>" so the receipt is bound to the approved contract
content.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b4498e0d-3eff-4129-9d84-861e7ae8a0e3

📥 Commits

Reviewing files that changed from the base of the PR and between 99d276e and ef4664f.

📒 Files selected for processing (6)
  • contracts/OMN-10813.yaml
  • contracts/OMN-7777.yaml
  • drift/dod_receipts/OMN-10813/dod-occ-self/command.yaml
  • drift/dod_receipts/OMN-10813/dod-pr-1698-open/command.yaml
  • drift/dod_receipts/OMN-7777/dod-occ-self/command.yaml
  • drift/dod_receipts/OMN-7777/dod-pr-1632-open/command.yaml

Comment thread drift/dod_receipts/OMN-10813/dod-occ-self/command.yaml Outdated
Comment thread drift/dod_receipts/OMN-10813/dod-pr-1698-open/command.yaml Outdated
Comment thread drift/dod_receipts/OMN-7777/dod-occ-self/command.yaml Outdated
Comment thread drift/dod_receipts/OMN-7777/dod-pr-1632-open/command.yaml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant