Repository navigation
docs(OMN-10813,OMN-7777): add OCC evidence for DEC-003 migration and dead flag removal - #1315
Conversation
…dead flag removal - contracts/OMN-10813.yaml: enriched contract for DEC-003 ONEX_EXCLUDE bypass removal (4 effect nodes: contract_persistence, delta_bundle, decision_store, delta_metrics) - contracts/OMN-7777.yaml: enriched contract for DUAL_PUBLISH_LEGACY_TOPICS dead flag removal - drift/dod_receipts/OMN-10813/dod-pr-1698-open/command.yaml: omnibase_infra PR #1698 receipt - drift/dod_receipts/OMN-7777/dod-pr-1632-open/command.yaml: omniclaude PR #1632 receipt
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (3)
📝 WalkthroughWalkthroughThis PR adds a new contract (OMN-10813), updates an existing contract (OMN-7777), and adds corresponding drift evidence receipts that capture and assert gh CLI probe command outputs. ChangesContract Definitions and Evidence Records
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@drift/dod_receipts/OMN-10813/dod-occ-self/command.yaml`:
- Line 10: Replace the placeholder contract_sha256 in this receipt by computing
the SHA-256 digest of the final contract file and writing that exact digest into
contract_sha256; specifically, compute the SHA-256 of contracts/OMN-10813.yaml
at the PR head (binary/text canonicalization as used by your repo's hashing
convention), then update the contract_sha256 field in command.yaml (currently
"sha256:placeholder-omn-10813-occ-self") to "sha256:<actual-digest>" so the
receipt is bound to the final contract content.
In `@drift/dod_receipts/OMN-10813/dod-pr-1698-open/command.yaml`:
- Line 10: Replace the placeholder in the receipt's contract_sha256 field with
the actual SHA-256 digest of the final contract file by computing the SHA-256 of
contracts/OMN-10813.yaml at the PR head and setting contract_sha256 to that
exact "sha256:<hex>" value (overwriting "sha256:placeholder-omn-10813"); ensure
the digest matches the contract content used in this PR so the receipt is bound
to the final contract version.
In `@drift/dod_receipts/OMN-7777/dod-occ-self/command.yaml`:
- Line 10: Replace the placeholder contract_sha256 in command.yaml with the
actual SHA-256 digest of the contract file for OMN-7777: compute the SHA-256 of
contracts/OMN-7777.yaml from the PR HEAD commit (e.g., compute the file bytes’
sha256 on the PR head, or use git show <HEAD>:contracts/OMN-7777.yaml |
sha256sum) and set contract_sha256: "sha256:<actual-digest>" so the receipt’s
contract_sha256 matches the contract file hash; update the value where
contract_sha256 is currently "sha256:placeholder-omn-7777-occ-self".
In `@drift/dod_receipts/OMN-7777/dod-pr-1632-open/command.yaml`:
- Line 10: Replace the placeholder value for the contract_sha256 field with the
actual SHA-256 digest of the final contract file; compute the hash for
contracts/OMN-7777.yaml at the PR head (e.g. run LC_ALL=C shasum -a 256
contracts/OMN-7777.yaml), then set contract_sha256 to the form
"sha256:<computed-hex-digest>" so the receipt is bound to the approved contract
content.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: b4498e0d-3eff-4129-9d84-861e7ae8a0e3
📒 Files selected for processing (6)
contracts/OMN-10813.yamlcontracts/OMN-7777.yamldrift/dod_receipts/OMN-10813/dod-occ-self/command.yamldrift/dod_receipts/OMN-10813/dod-pr-1698-open/command.yamldrift/dod_receipts/OMN-7777/dod-occ-self/command.yamldrift/dod_receipts/OMN-7777/dod-pr-1632-open/command.yaml
Summary
Evidence
contracts/OMN-10813.yaml— enriched contract withdod_evidencefor omnibase_infra PR evidence(triage): batch OCC evidence for 20 merged-PR tickets (OMN-12186) #1698contracts/OMN-7777.yaml— enriched contract withdod_evidencefor omniclaude PR contracts(OMN-12128): add handler routing evidence #1632drift/dod_receipts/OMN-10813/dod-pr-1698-open/command.yaml— PR receipt at head907f014edrift/dod_receipts/OMN-7777/dod-pr-1632-open/command.yaml— PR receipt at head98d3c738Summary by CodeRabbit
Chores
Documentation