Repository navigation
evidence(OMN-19970): bind each criterion to the tests that decide it - #11906
Merged
Merged
Conversation
The autobind companion bound AC1, AC2 and AC3 to one check that counts `def _publish` in cli_seed.py. That proves a function exists, not that a second seed leaves the same rows, that fixture savings stay out of the measured total, or that the label reaches the rows, so the sweep could never read any criterion as receipt-proven. Append one item per criterion, each bound to the omnimarket tests that decide it and retiring the grep binding with supersedes_ac_binding, in the shape of OMN-19997 (onex_change_control#11828). Receipts are real runs on omnimarket dev 532ec1f53, the PostgreSQL tests on a real cluster; the same selection fails to collect on 43cbc9035^. AC3's exposure half is the lab readback on the lakshman lane, cited in its receipt, because the hosted sweep cannot reach the lab.
Contributor
|
Merged as Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Binds each acceptance criterion of OMN-19970 to the omnimarket tests that decide it. The autobind companion bound all three to one check that counts
def _publishincli_seed.py, which proves a function exists and no criterion's behaviour, so the sweep could never read any of them as receipt-proven. Same shape as OMN-19997's onex_change_control#11828.What changed
contracts/OMN-19970.yaml: three appendeddod_evidenceitems,source: manual, each withbinds_ac, anac_bindingsentry and asupersedes_ac_bindingretiring the grep binding ondod-OmniNode-ai-omnimarket-pr-3082for that label. No existing entry is edited.ac1-seeding-twice-leaves-the-same-rows→ AC1:tests/test_omn19970_dev_seed.py::test_seeding_twice_leaves_the_same_rows_all_labelled_fixture.ac2-measured-savings-exclude-fixtures→ AC2:test_metering_excludes_fixture_rows_unless_asked(SQLite) andtest_summary_view_keeps_fixture_savings_out_of_the_measured_total(real PostgreSQL).ac3-fixture-label-reaches-the-rows→ AC3:test_seed_wire_messages_land_labelled_through_the_runner_seamandtest_runner_labels_from_the_envelope_tag_and_defaults_to_real(real PostgreSQL).drift/dod_receipts/OMN-19970/<item>/test_passes.yaml: one PASS receipt per item.How it was verified
onex_change_control.validation.ac_criteria.criterion_hashfrom the ticket's live criteria (read 2026-09-30 09:4xZ): all three match the hashes carried here.check_valuerun on omnimarketdev532ec1f53(on .201, PostgreSQL 16 binaries on PATH, nothing skipped): 1 passed (AC1), 2 passed (AC2), 2 passed (AC3). Negative control: the same selection against43cbc9035^(the commit before omnimarket#3082 merged) fails to collect, 2 errors, pytest exit 4.check_ac_binding_acceptance.py --ticket-bodies <live body>: exit 0. Control:binds_ac: AC9is refused withac_binding_unknown_criterion, exit 1.check_receipt_hardening.py --paths-file0 <the 4 changed files>: exit 0. Control: a zeroedcontract_entry_sha256is refused as a mismatch, exit 1; restored byte-identical, exit 0.check_contract_change_rebinds_receipts.py: self-test exit 0; gate "3 touched dod_evidence entr(ies) … every receipt bound to one of them re-verifies".validator_occ_append_only --ticket-id OMN-19970: "No append-only violations".data_source: fixture) is posted on omnimarket#3082 and cited in the AC3 receipt. It is not a check here, because the hosted sweep cannot reach the lab lane.Failure paths
n/a: this change adds evidence items and receipts; it writes no runtime receipt, verdict or report of its own.
Open defects
none
Local gates
--no-verify, noSKIP=, no--no-gpg-sign, nocore.hooksPathoverride. Every pre-commit and pre-push hook ran.The one hook that failed on the first commit attempt,
reject-deploy-gate-skip-token, failed on the laptop's Bash 3.2 ("requires Bash 4+"); it passed once Homebrew Bash 5.3 was first on PATH.Not in this change
Evidence-Ticket: OMN-19970