Repository navigation
evidence(OMN-9413): add contract and dod receipts for registration orchestrator topic subscription regression test - #1094
Merged
Conversation
…chestrator topic subscription regression test Contract OMN-9413: node_registration_orchestrator declares 7 subscribe_topics but at runtime only 3 consumer groups were wired. Fixed in OMN-10448 (which delegated all wiring to generic contract auto-wiring). This OCC entry records the regression test proof via omnibase_infra PR #1634.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis PR introduces a Definition of Done (DOD) contract and evidence collection for ticket OMN-9413. It adds a contract specification file that documents regression-test requirements (node registration orchestrator auto-wiring to 7 topics) and evidence validation logic, plus three receipt files that record the passing execution status and grep-based validation outputs from those tests. ChangesOMN-9413 Ticket Contract and Evidence
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Existing receipts bound only to omnibase_infra PR #1634. Receipt-gate's pr_ticket_mismatch requires at least one PASS receipt bound to this OCC PR's number.
jonahgabriel
added a commit
that referenced
this pull request
May 18, 2026
Existing receipt bound only to omnibase_core PR #1094. Receipt-gate pr_ticket_mismatch requires at least one PASS receipt bound to this OCC PR.
jonahgabriel
enabled auto-merge (squash)
May 18, 2026 03:06
jonahgabriel
added a commit
that referenced
this pull request
May 18, 2026
…idator workflow_call fix (#1089) * evidence(OMN-11119): add contract and dod receipts for check-name validator workflow_call fix Binds omnibase_core PR #1094 (extend validate-check-names.py to detect workflow_call composite check names and emit WORKFLOW_CALL_COMPOSITE_NAME_MISMATCH). * evidence(OMN-11119): add self-binding receipt for OCC PR #1089 Existing receipt bound only to omnibase_core PR #1094. Receipt-gate pr_ticket_mismatch requires at least one PASS receipt bound to this OCC PR.
jonahgabriel
added a commit
that referenced
this pull request
Aug 30, 2026
… parse Round 1 of dod-deploy-assessment was BLOCKed 3/3 by the contract-compliance check, which EXECUTES dod_evidence rather than only shape-checking it. Two distinct defects, both fixed here: 1. `grep -q` exits on first match and SIGPIPEs the upstream `base64 -d`. Under the runner's `pipefail` that surfaced as `Command failed (exit 141)` even for content that was present. Replaced with `grep -c`, which consumes the whole stream and still exits 1 on zero matches -- so the check stays falsifiable without the false RED. 2. The omnimarket check probed `?ref=dev` for a symbol that only lands when omnimarket#2225 merges -- but this contract is what unblocks #2225's own deploy-gate, so the two PRs deadlocked against each other. Rescoped to #2225's live file list (`pulls/2225/files`), the same shape OMN-16984 used. Still falsifiable: RED the moment that PR stops carrying the file. The two omninode_infra checks stay pinned to `?ref=dev` and are genuinely GREEN only because #1094 merged at 2026-08-30T17:22:24Z; both were RED before it. All three verified locally against live GitHub (each prints 1, exit 0). The kustomization check is deliberately separate from the manifest check: a file committed but absent from the overlay's kustomization is never applied, and a single check would read as done while nothing deploys. Ticket: OMN-17210
jonahgabriel
added a commit
that referenced
this pull request
Aug 30, 2026
…uct PRs (#7736) * evidence(OMN-17210): add a falsifiable deploy-scope DoD for both product PRs The OMN-13317 autobind wrote only a `uv run pytest` behavior proof onto contracts/OMN-17210.yaml. The deploy-gate correctly rejects that as non-falsifiable on omnimarket#2225: DEPLOY GATE FAILED: PR touches runtime paths but no cited ticket has deploy DoD evidence. ... OMN-17210 [dod-occ-diff-derived-behavior-proof] REJECTED -- no live-surface probe in command position (commands found: ['uv']) pytest's exit status cannot depend on the state of any deployed or remote surface, so it can never go RED for a deploy reason. Adds `dod-deploy-assessment` with three checks, each putting a `gh api` read of the LIVE dev branch in command position and grepping for a symbol that exists nowhere on dev today -- so each is RED right now and only goes GREEN once the corresponding PR actually lands: - omnimarket#2225: `class HandlerReceiptGateProjectionRunner(BaseProjectionRunner)` on omnimarket dev. RED today -- node_projection_receipt_gate ships only the pure reducer and its handle_dict shim, no BaseProjectionRunner subclass. - omninode_infra#1094: the savings writer Deployment's `python -m omnimarket.nodes.node_projection_savings.handlers.handler_savings` command line on omninode_infra dev. RED today -- the manifest does not exist there. - omninode_infra#1094: the same manifest listed in k8s/onex-dev/runtime/kustomization.yaml, so a file landed without being wired into the overlay does not read as done. RED today -- that kustomization lists twelve runtime Deployments. None reads back a receipt or contract this ticket's own PRs author, which is the failure mode OMN-14505 added the falsifiability rule for. Ticket: OMN-17210 * evidence(OMN-17210): make the deploy-scope checks pass live, not just parse Round 1 of dod-deploy-assessment was BLOCKed 3/3 by the contract-compliance check, which EXECUTES dod_evidence rather than only shape-checking it. Two distinct defects, both fixed here: 1. `grep -q` exits on first match and SIGPIPEs the upstream `base64 -d`. Under the runner's `pipefail` that surfaced as `Command failed (exit 141)` even for content that was present. Replaced with `grep -c`, which consumes the whole stream and still exits 1 on zero matches -- so the check stays falsifiable without the false RED. 2. The omnimarket check probed `?ref=dev` for a symbol that only lands when omnimarket#2225 merges -- but this contract is what unblocks #2225's own deploy-gate, so the two PRs deadlocked against each other. Rescoped to #2225's live file list (`pulls/2225/files`), the same shape OMN-16984 used. Still falsifiable: RED the moment that PR stops carrying the file. The two omninode_infra checks stay pinned to `?ref=dev` and are genuinely GREEN only because #1094 merged at 2026-08-30T17:22:24Z; both were RED before it. All three verified locally against live GitHub (each prints 1, exit 0). The kustomization check is deliberately separate from the manifest check: a file committed but absent from the overlay's kustomization is never applied, and a single check would read as done while nothing deploys. Ticket: OMN-17210 * evidence(OMN-17210): add deploy assessment receipt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OMN-9413 — OCC Evidence: registration orchestrator all 7 topics subscribed
Adds contract YAML + dod receipts proving the OMN-9413 regression test is in place.
Evidence
contracts/OMN-9413.yaml— ticket contract with evidence requirementsdrift/dod_receipts/OMN-9413/dod-001/command.yaml— regression test pass receipt (2 passed)drift/dod_receipts/OMN-9413/dod-002/command.yaml— infra PR contracts(OMN-12061): add model registry evidence #1634 receiptomnibase_infra PR
OmniNode-ai/omnibase_infra#1634
Evidence-Source: OCC#1093
Evidence-Ticket: OMN-9413
Summary by CodeRabbit