Skip to content

OMN-11011 classify package migrations - #669

Merged
jonahgabriel merged 2 commits into
mainfrom
jonah/omn-11011-schema-classify-package-migrations
May 17, 2026
Merged

jonahgabriel merged 2 commits into
mainfrom
jonah/omn-11011-schema-classify-package-migrations

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented May 16, 2026 •

Copy link
Copy Markdown
Contributor

Evidence-Source: OCC#1072
Evidence-Ticket: OMN-11011

Summary

  • Classifies the OMN-11011 omnimarket package migrations after generated-tree exclusion.
  • Documents that nightly_loop_decisions, nightly_loop_iterations, and review_bot_bypass_log each have exactly one scanned omnimarket node migration and require no suppressions or repairs.
  • Adds a regression test for the local package migration ownership paths.

Evidence

  • uv run pytest tests/test_migration_ownership_omn11011.py -q
  • uv run ruff check tests/test_migration_ownership_omn11011.py
  • uv run pytest tests/test_golden_chain_duplication_sweep.py -q
  • $OMNI_HOME/onex_change_control/.venv/bin/check-migration-conflicts --repos-root $OMNI_HOME --repos omnibase_core omnibase_infra omniclaude omnidash omniintelligence omnimarket omnimemory onex_change_control --suppressions-file $OMNI_HOME/onex_change_control/migration_conflict_suppressions.yaml

Notes

@coderabbitai

coderabbitai Bot commented May 16, 2026 •

Copy link
Copy Markdown

Warning

Rate limit exceeded

@jonahgabriel has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 2 minutes and 5 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5ea6dd05-7f24-4999-af45-33085bfca1f9

📥 Commits

Reviewing files that changed from the base of the PR and between 2a2be49 and 2840a54.

📒 Files selected for processing (2)
  • docs/evidence/omn-11011-migration-package-classification.md
  • tests/test_migration_ownership_omn11011.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-11011-schema-classify-package-migrations

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
github-actions Bot enabled auto-merge May 16, 2026 20:54
@github-actions

github-actions Bot commented May 16, 2026 •

Copy link
Copy Markdown

✅ Architectural Review — PASSED

Errors: 0
Warnings: 0

What this checks

Rule Description
ARCH-TOPIC-001 No hardcoded Kafka topic strings in handler code
ARCH-DI-001 No event_bus=None bypass
ARCH-DI-002 No direct Handler instantiation outside workflow_runner/adapters
ARCH-DI-003 No reinvented DI containers
ARCH-TOPIC-002 contract.yaml topics follow `onex.{cmd

No architectural violations found.

Powered by node_pr_review_bot

@github-actions

github-actions Bot commented May 16, 2026 •

Copy link
Copy Markdown

✅ PR Review Bot — CLEAN

Findings: 0
Run ID: ``

Note: Reviewer models are running as stubs (OMN-7969–OMN-7972 pending). Architectural findings from Phase 1 (arch-lint) are the authoritative signal until model handlers land.


Verdict semantics

Verdict Meaning
clean No blocking findings
risks_noted Findings noted; threads passed verification
blocking_issue MAJOR/CRITICAL findings not resolved — do not merge

Powered by node_pr_review_bot — FSM pipeline with multi-model review fan-out

@github-actions

github-actions Bot commented May 16, 2026 •

Copy link
Copy Markdown

⚠️ Hostile Reviewer — DEGRADED (informational)

Blocking findings (critical/error): 0
Total findings: 0
Models succeeded: none

Note: All reviewer models failed or were unavailable. Degraded results are informational during the pilot phase (OMN-8524) and do not block merge. Error: cli_review exited non-zero (all models failed or binary error)


Gate semantics (pilot phase)

Verdict Meaning Blocks merge?
passed No critical/error findings No
blocked CRITICAL or ERROR findings found Yes
degraded All models unavailable (infra) No (pilot)

Powered by omniintelligence.review_pairing.cli_review — node-based adversarial review via HandlerLlmCliSubprocess (OMN-8524)

@sonarqubecloud

Copy link
Copy Markdown

@jonahgabriel
jonahgabriel added this pull request to the merge queue May 17, 2026
Merged via the queue into main with commit fdfac59 May 17, 2026
42 of 46 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-11011-schema-classify-package-migrations branch May 17, 2026 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant