[jonahgabriel]

Summary

• Implements PostgresDataSource class satisfying the existing DataSource protocol, backed by psycopg2 connecting to omnidash_analytics on .201:5436
• SQL injection prevention via strict regex table name validation (^[a-zA-Z_][a-zA-Z0-9_]*$)
• Reads DSN from OMNIDASH_ANALYTICS_DB_URL env var or constructor parameter
• Adds psycopg2-binary>=2.9.10 to project dependencies
• 6 unit tests (mocked psycopg2, no DB needed) + 4 integration tests (require real DB, auto-skipped in CI)

Test plan

• 6 unit tests pass: row count, columns, sample rows, None→empty string, handler protocol check, missing DSN error
• 4 integration tests auto-skip without OMNIDASH_ANALYTICS_DB_URL
• All 194 existing tests still pass (0 regressions)

Closes OMN-7624 (sub-task 3a: runtime adapter)

Summary by CodeRabbit

• Refactor

  • PostgreSQL data source now uses DSN string for configuration instead of individual parameters.
  • Improved connection management and lifecycle handling.
  • Enhanced table name validation and schema filtering.

• Tests

  • Added comprehensive unit and integration tests for PostgreSQL data source functionality.

• Chores

  • Added psycopg2-binary dependency.

[linear]

OMN-7624

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Lite

Run ID: 78b3a442-5e3f-4736-ad0b-5b1f577154b2

📥 Commits

Reviewing files that changed from the base of the PR and between 6da5507 and 67e6b6f.

⛔ Files ignored due to path filters (1)

• uv.lock is excluded by !**/*.lock

📒 Files selected for processing (3)

• pyproject.toml
• src/omnimarket/nodes/node_data_verification/handlers/datasource_postgres.py
• tests/test_datasource_postgres.py

---

📝 Walkthrough

Walkthrough

This pull request adds psycopg2-binary as a runtime dependency and refactors the PostgresDataSource class to use DSN-based connection configuration instead of individual host/port/database parameters. The connection lifecycle is redesigned to handle auto-reconnection and query execution improvements including stricter SQL identifier validation and enhanced result normalization. A comprehensive test suite is introduced covering unit and integration scenarios.

Changes

Cohort / File(s)	Summary
Dependency Addition pyproject.toml	Added psycopg2-binary>=2.9.10 to the package's runtime dependencies.
PostgreSQL DataSource Refactoring src/omnimarket/nodes/node_data_verification/handlers/datasource_postgres.py	Redesigned PostgresDataSource.__init__() to accept dsn: str | None with validation against OMNIDASH_ANALYTICS_DB_URL; removed from_env() classmethod and parameterized constructor. Replaced connection management with lazy initialization and auto-reconnection in _get_conn() with autocommit = True. Introduced _quote_table() with stricter regex validation for table names. Updated query methods: get_row_count() uses SELECT COUNT(*), get_sample_rows() uses RealDictCursor with value stringification and fallback from ORDER BY created_at DESC to LIMIT-only on undefined column errors. Enhanced schema introspection in get_columns() with table_schema = 'public' filtering. Added __del__() and improved close() logging.
Test Coverage tests/test_datasource_postgres.py	New comprehensive test file with unit tests mocking psycopg2.connect to validate initialization errors, row counting, column retrieval, sample row normalization, and integration with HandlerDataVerification. Integration tests (gated by OMNIDASH_ANALYTICS_DB_URL) verify real database interactions including row counts, column schemas, value stringification, and end-to-end verification workflows with proper resource cleanup.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~50 minutes

Poem

🐰 A rabbit hops through DSN strings,
No more host params—cleaner things!
psycopg2 connects with flair,
From env to DSN, handled with care,
Tests verify each hop and bound! 🎉

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}