Repository navigation
fix(OMN-10698): exclude ADR canary from main runtime profile - #573
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
✅ Architectural Review — PASSEDErrors: 0 What this checks
No architectural violations found. Powered by node_pr_review_bot |
✅ PR Review Bot — CLEANFindings: 0
Verdict semantics
Powered by node_pr_review_bot — FSM pipeline with multi-model review fan-out |
|
| Verdict | Meaning | Blocks merge? |
|---|---|---|
passed |
No critical/error findings | No |
blocked |
CRITICAL or ERROR findings found | Yes |
degraded |
All models unavailable (infra) | No (pilot) |
Powered by omniintelligence.review_pairing.cli_review — node-based adversarial review via HandlerLlmCliSubprocess (OMN-8524)
Summary
canaryruntime profilemainruntime ownership from auto-wiring a handler whose injected sub-handlers are not materialized by the current resolverVerification
env -u PYTHONPATH uv run pytest tests/validation/test_runtime_profile_contract_ownership.py src/omnimarket/nodes/node_adr_canary_orchestrator/tests/test_handler_canary_orchestrator.py tests/test_no_cross_node_reach_in.py -qenv -u PYTHONPATH uv run ruff check src/omnimarket/nodes/node_adr_canary_orchestrator tests/test_no_cross_node_reach_in.py tests/validation/test_runtime_profile_contract_ownership.pyenv -u PYTHONPATH uv run mypy src/omnimarket/ --strictbash scripts/validation/check_leaked_literals.sh blocking allRuntime
.201startup regression after fix(OMN-10698): remove cross-node handler imports, require DI for all sub-handlers #566:HandlerCanaryOrchestratorrequiredingestion,extraction,grading, anddraft_gen, but the main profile resolver could not satisfy them.Evidence-Ticket: OMN-10698
Evidence-Source: OCC#834
Evidence-Commit: b913c232359d9b520cbb8d7e1ebc5594700319aa