Skip to content

fix(OMN-10698): exclude ADR canary from main runtime profile - #573

Merged
jonahgabriel merged 1 commit into
mainfrom
jonah/omn-10698-runtime-profile-containment
May 9, 2026
Merged

jonahgabriel merged 1 commit into
mainfrom
jonah/omn-10698-runtime-profile-containment

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented May 9, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • move the ADR canary orchestrator contract onto the dedicated canary runtime profile
  • keep main runtime ownership from auto-wiring a handler whose injected sub-handlers are not materialized by the current resolver
  • extend the runtime profile ownership guard to cover this canary crash path

Verification

  • env -u PYTHONPATH uv run pytest tests/validation/test_runtime_profile_contract_ownership.py src/omnimarket/nodes/node_adr_canary_orchestrator/tests/test_handler_canary_orchestrator.py tests/test_no_cross_node_reach_in.py -q
  • env -u PYTHONPATH uv run ruff check src/omnimarket/nodes/node_adr_canary_orchestrator tests/test_no_cross_node_reach_in.py tests/validation/test_runtime_profile_contract_ownership.py
  • env -u PYTHONPATH uv run mypy src/omnimarket/ --strict
  • bash scripts/validation/check_leaked_literals.sh blocking all

Runtime

Evidence-Ticket: OMN-10698
Evidence-Source: OCC#834
Evidence-Commit: b913c232359d9b520cbb8d7e1ebc5594700319aa

@coderabbitai

coderabbitai Bot commented May 9, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@jonahgabriel has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 3 minutes and 40 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ef27fdc7-7473-4d88-ac87-a37a32e01a91

📥 Commits

Reviewing files that changed from the base of the PR and between e787622 and faeeaed.

📒 Files selected for processing (2)
  • src/omnimarket/nodes/node_adr_canary_orchestrator/contract.yaml
  • tests/validation/test_runtime_profile_contract_ownership.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-10698-runtime-profile-containment

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented May 9, 2026

Copy link
Copy Markdown

✅ Architectural Review — PASSED

Errors: 0
Warnings: 0

What this checks

Rule Description
ARCH-TOPIC-001 No hardcoded Kafka topic strings in handler code
ARCH-DI-001 No event_bus=None bypass
ARCH-DI-002 No direct Handler instantiation outside workflow_runner/adapters
ARCH-DI-003 No reinvented DI containers
ARCH-TOPIC-002 contract.yaml topics follow `onex.{cmd

No architectural violations found.

Powered by node_pr_review_bot

@github-actions
github-actions Bot enabled auto-merge May 9, 2026 06:33
@github-actions

github-actions Bot commented May 9, 2026 •

Copy link
Copy Markdown

✅ PR Review Bot — CLEAN

Findings: 0
Run ID: ``

Note: Reviewer models are running as stubs (OMN-7969–OMN-7972 pending). Architectural findings from Phase 1 (arch-lint) are the authoritative signal until model handlers land.


Verdict semantics

Verdict Meaning
clean No blocking findings
risks_noted Findings noted; threads passed verification
blocking_issue MAJOR/CRITICAL findings not resolved — do not merge

Powered by node_pr_review_bot — FSM pipeline with multi-model review fan-out

@github-actions

github-actions Bot commented May 9, 2026

Copy link
Copy Markdown

⚠️ Hostile Reviewer — DEGRADED (informational)

Blocking findings (critical/error): 0
Total findings: 0
Models succeeded: none

Note: All reviewer models failed or were unavailable. Degraded results are informational during the pilot phase (OMN-8524) and do not block merge. Error: cli_review exited non-zero (all models failed or binary error)


Gate semantics (pilot phase)

Verdict Meaning Blocks merge?
passed No critical/error findings No
blocked CRITICAL or ERROR findings found Yes
degraded All models unavailable (infra) No (pilot)

Powered by omniintelligence.review_pairing.cli_review — node-based adversarial review via HandlerLlmCliSubprocess (OMN-8524)

@jonahgabriel
jonahgabriel added this pull request to the merge queue May 9, 2026
Merged via the queue into main with commit dfd87ff May 9, 2026
40 of 41 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-10698-runtime-profile-containment branch May 9, 2026 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant