Repository navigation
fix(OMN-10569): strip baked LAN/path/identity defaults from omnimarket source - #546
Merged
jonahgabriel merged 5 commits intoMay 7, 2026
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (36)
📝 WalkthroughWalkthroughThis PR systematically removes hardcoded internal IP addresses, localhost defaults, and home-directory fallbacks across 40+ files, replacing them with environment-variable-driven configuration. All defaults now resolve to empty strings when environment variables are unset, requiring explicit configuration in deployment environments. A new contract (OMN-10569) documents the expected outcome and verification checks. ChangesRemove Hardcoded Environment Defaults
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly Related PRs
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
| Verdict | Meaning | Blocks merge? |
|---|---|---|
passed |
No critical/error findings | No |
blocked |
CRITICAL or ERROR findings found | Yes |
degraded |
All models unavailable (infra) | No (pilot) |
Powered by omniintelligence.review_pairing.cli_review — node-based adversarial review via HandlerLlmCliSubprocess (OMN-8524)
…t source Replace all hardcoded 192.168.x.x IPs, /Users/jonah, /Volumes/PRO-G40 paths, localhost:9092 broker defaults, and glm-4.5 model ID literals with empty-string defaults. Affected surfaces: probe_system_health, probe_kafka_topics, all consumer entrypoints, platform readiness/diagnostics dimension_checks, node_nightly_loop_controller, node_handoff_effect, and 8 sweep node __main__.py entrypoints. Pre-existing postgres integration test failure confirmed on main.
…efaults-strip PR Adds docs/work-tracking/contracts/OMN-10569.yaml with dod-deploy item (docker exec import check) so the deploy-gate can verify the env-var default cleanup does not break runtime handler imports.
…ontract summary test_work_tracking_contracts_have_no_user_paths bans /Users/<name> and /Volumes/<name> in docs/work-tracking/contracts/. The summary field used descriptive text containing those patterns; replace with generic terms.
jonahgabriel
force-pushed
the
jonah/omn-10569-task-3-strip-baked-lanpathidentity-defaults-from-omnimarket
branch
from
May 7, 2026 19:21
75f4fe3 to
cd2d9bf
Compare
jonahgabriel
added this pull request to the merge queue
May 7, 2026
jonahgabriel
deleted the
jonah/omn-10569-task-3-strip-baked-lanpathidentity-defaults-from-omnimarket
branch
May 7, 2026 19:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes OMN-10569. Strips all hardcoded LAN IPs, user-specific paths, and model ID literals from
src/omnimarket/production source (36 files).What was removed:
192.168.86.200/192.168.86.201asos.environ.getfallback defaults → replaced with""/Users/jonah/Code/omni_homeand/Volumes/PRO-G40/Code/omni_home→os.environ.get("OMNI_HOME", "")localhost:9092Kafka broker defaults across all 7 consumer entrypoints →""glm-4.5hardcoded model ID default →""(3 locations)Path.home() / "Code" / "omni_home"path construction as default →""jonah@192.168.86.201SSH target default →os.environ.get("ONEX_INFRA_SSH_TARGET", "")Pattern: All replaced with empty-string defaults. Callers that need a value must set the env var explicitly. Probes/consumers that previously silently used a wrong machine now either skip cleanly (probes) or fail loudly at startup (consumers).
Remaining docstring/comment references to IPs in test assertions (`test_model_policy.py`) are in `tests/` scope (task #1).
Test plan
dod_evidence
ticket: OMN-10569
check_type: grep_absent
pattern: "192\.168\.(86|0)\.[0-9]+"
scope: src/omnimarket/
result: no matches in os.environ.get defaults
Evidence-Source
OMN-10569
Evidence-Source: OCC#773
Evidence-Ticket: OMN-10569
Summary by CodeRabbit
Configuration Changes
Documentation