Skip to content

fix(OMN-10452): name intelligence function handlers - #499

Merged
jonahgabriel merged 1 commit into
mainfrom
jonah/omn-10452-intelligence-handler-names
May 1, 2026
Merged

jonahgabriel merged 1 commit into
mainfrom
jonah/omn-10452-intelligence-handler-names

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented May 1, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • add explicit non-empty name fields to node_intelligence_orchestrator function handler refs
  • keep function-based routing profile-restricted to the intelligence runtime
  • add resolver-compatible tests proving names are non-empty and import-resolve to the declared functions

Verification

  • uv run pytest tests/nodes/node_intelligence_orchestrator/test_contract_runtime_readiness.py -q
  • uv run ruff check tests/nodes/node_intelligence_orchestrator/test_contract_runtime_readiness.py
  • uv run python - <<'PY'
    from pathlib import Path
    import yaml
    path = Path('src/omnimarket/nodes/node_intelligence_orchestrator/contract.yaml')
    raw = yaml.safe_load(path.read_text(encoding='utf-8'))
    handlers = raw['handler_routing']['handlers']
    print([entry['handler']['name'] for entry in handlers])
    PY
  • uv run validate-yaml contracts/OMN-10452.yaml

Evidence

Evidence-Ticket: OMN-10452
Evidence-Source: OCC#615
Central evidence: OmniNode-ai/onex_change_control#615

No live deploy, runtime restart, or .201 mutation was performed.

@coderabbitai

coderabbitai Bot commented May 1, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@jonahgabriel has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 11 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 633ff725-2128-49e3-8e74-0cb7b3c3844d

📥 Commits

Reviewing files that changed from the base of the PR and between da9d3cc and 017678d.

📒 Files selected for processing (3)
  • contracts/OMN-10452.yaml
  • src/omnimarket/nodes/node_intelligence_orchestrator/contract.yaml
  • tests/nodes/node_intelligence_orchestrator/test_contract_runtime_readiness.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-10452-intelligence-handler-names

Review rate limit: 0/5 reviews remaining, refill in 11 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented May 1, 2026

Copy link
Copy Markdown

⚠️ Hostile Reviewer — DEGRADED (informational)

Blocking findings (critical/error): 0
Total findings: 0
Models succeeded: none

Note: All reviewer models failed or were unavailable. Degraded results are informational during the pilot phase (OMN-8524) and do not block merge. Error: cli_review exited non-zero (all models failed or binary error)


Gate semantics (pilot phase)

Verdict Meaning Blocks merge?
passed No critical/error findings No
blocked CRITICAL or ERROR findings found Yes
degraded All models unavailable (infra) No (pilot)

Powered by omniintelligence.review_pairing.cli_review — node-based adversarial review via HandlerLlmCliSubprocess (OMN-8524)

@jonahgabriel
jonahgabriel enabled auto-merge May 1, 2026 16:22
@jonahgabriel
jonahgabriel added this pull request to the merge queue May 1, 2026
Merged via the queue into main with commit 35c0449 May 1, 2026
29 of 30 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-10452-intelligence-handler-names branch May 1, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant