[jonahgabriel]

Summary

• Adds tests/test_golden_chain_quality_scoring_compute.py with 29 unit tests covering the full handler stack for node_quality_scoring_compute
• Two test classes: TestQualityScoringGoldenChain (exercises handle_quality_scoring_compute end-to-end via Pydantic models) and TestScoreCodeQualityPure (exercises the pure score_code_quality function directly)
• Coverage: all six dimension presence/range, empty input validation, syntax error handling, unsupported language baseline, preset thresholds (strict/standard/lenient), custom weights, compliance threshold logic, below_threshold vs completed metadata status, frozen-model invariant

Context

The handler was already fully implemented — this PR adds the missing golden-chain test layer. The only existing tests were contract tests (topic names, schema refs); there were no behavioral tests exercising the scoring logic.

Related: OMN-10474

Test plan

• uv run pytest tests/test_golden_chain_quality_scoring_compute.py -v — 29/29 pass
• uv run pytest tests/ -m "not kafka" -q — 2966 pass, 4 pre-existing Postgres integration failures (require live DB, unrelated to this change)
• uv run ruff format + uv run ruff check — clean
• pre-commit run --files tests/test_golden_chain_quality_scoring_compute.py — all hooks pass

[coderabbitai]

Warning

Rate limit exceeded

@jonahgabriel has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 5 minutes and 30 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: bd41ebe6-8a00-463d-8685-6e1f13ce3be8

📥 Commits

Reviewing files that changed from the base of the PR and between da9d3cc and 08a104c.

📒 Files selected for processing (1)

• tests/test_golden_chain_quality_scoring_compute.py

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch jonah/omn-quality-scoring-handler

---

_{Review rate limit: 0/5 reviews remaining, refill in 5 minutes and 30 seconds.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

⚠️ Hostile Reviewer — DEGRADED (informational)

Blocking findings (critical/error): 0
Total findings: 0
Models succeeded: none

Note: All reviewer models failed or were unavailable. Degraded results are informational during the pilot phase (OMN-8524) and do not block merge. Error: cli_review exited non-zero (all models failed or binary error)

---

Gate semantics (pilot phase)

Verdict	Meaning	Blocks merge?
passed	No critical/error findings	No
blocked	CRITICAL or ERROR findings found	Yes
degraded	All models unavailable (infra)	No (pilot)

Powered by omniintelligence.review_pairing.cli_review — node-based adversarial review via HandlerLlmCliSubprocess (OMN-8524)