[jonahgabriel]

[skip-deploy-gate: typecheck-only fix, no runtime path changes]

Summary

• Replace path = "../..." uv.sources with git sources so uv sync works outside the omni_home/ monorepo layout (worktrees, standalone clones, and when omnimarket is resolved as a git dependency by other repos)
• Add git sources for omnibase-spi and omninode-memory where PyPI versions are stale and missing modules needed at runtime (protocols.runtime, models.persona)
• Add omnibase-spi as explicit direct dependency so the git source override applies (uv only overrides direct deps)

Root cause

The previous pyproject.toml had:

[tool.uv.sources]
omnibase-core = { path = "../omnibase_core", editable = true }
omnibase-compat = { path = "../omnibase_compat", editable = true }
omninode-memory = { path = "../omnimemory", editable = true }

These relative paths only resolve inside the omni_home/ directory structure. When omnibase_infra resolves omnimarket as a git dependency, it clones omnimarket standalone — the ../omnibase_core path doesn't exist and uv sync fails.

Additionally, several PyPI packages are stale:

• omnibase-spi 0.20.4 (PyPI) is missing protocols.runtime that omnibase-infra 0.32.0 imports
• omninode-memory 0.11.0 (PyPI) is missing models.persona that omnimarket tests import
• omnibase-compat is not published to PyPI at all

Test plan

• uv sync succeeds in worktree (standalone clone)
• uv run python -c "from omnibase_spi.protocols.runtime import ..." resolves
• uv run python -c "import omnibase_infra" resolves
• 2280/2281 tests pass (1 Kafka integration test requires running broker)
• All pre-commit hooks pass
• Verify CI green via gh pr checks

💘 Generated with Crush

[skip-deploy-gate: typecheck-only fix, no runtime path changes]

Summary by CodeRabbit

• Chores
  • Added a new runtime dependency (omnibase-spi) and updated package source configurations to use remote sources for related packages, improving dependency management and build consistency.
• Refactor
  • Simplified internal issue-handling logic for ticket queries to reduce complexity while preserving existing behavior and outputs.

[github-actions]

⚠️ Hostile Reviewer — DEGRADED (informational)

Blocking findings (critical/error): 0
Total findings: 0
Models succeeded: none

Note: All reviewer models failed or were unavailable. Degraded results are informational during the pilot phase (OMN-8524) and do not block merge. Error: cli_review exited non-zero (all models failed or binary error)

---

Gate semantics (pilot phase)

Verdict	Meaning	Blocks merge?
passed	No critical/error findings	No
blocked	CRITICAL or ERROR findings found	Yes
degraded	All models unavailable (infra)	No (pilot)

Powered by omniintelligence.review_pairing.cli_review — node-based adversarial review via HandlerLlmCliSubprocess (OMN-8524)

[coderabbitai]

📝 Walkthrough

Walkthrough

Added runtime dependency omnibase-spi>=0.20.4, replaced local editable package sources with Git-based sources for omnibase-compat, omninode-memory, and added omnibase-spi in pyproject.toml; simplified construction of issues in handler_ticket_query.py by directly using issue.model_dump().

Changes

Cohort / File(s)	Summary
Project metadata pyproject.toml	Added runtime dependency omnibase-spi>=0.20.4. Switched package sources from local editable path overrides to Git-based sources (main branch) for omnibase-compat, omninode-memory, and added omnibase-spi source.
Ticket query handler src/omnimarket/nodes/node_ticket_query/handlers/handler_ticket_query.py	Removed per-item conditional check and now constructs ModelIssueResult instances using ModelIssueResult(**issue.model_dump()) for each raw_issues item; removed an # type: ignore[import-not-found] comment on a TYPE_CHECKING import.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I nibble through deps and tidy the tree,
Paths turned to Git for a cleaner spree,
A tiny refactor, issues built neat,
omnibase-spi hops in — what a treat! 🥕

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title accurately and concisely describes the primary change: replacing broken UV path-based sources with git sources to fix dependency resolution.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch jonah/omn-9403-fix-uv-sources

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

pyproject.toml (1)

182-184: Consider pinning git sources to explicit commit SHAs in pyproject.toml for clarity.

Lines 182–184 use branch = "main", which is mutable. While uv.lock already captures concrete commits (e850cc3a, 168c71a622f, 87355d7d2bf) and provides reproducibility in locked workflows, explicitly pinning rev in the manifest makes the intent clearer and reduces reliance on lock file regeneration.

Suggested improvement

-omnibase-compat = { git = "https://github.com/OmniNode-ai/omnibase_compat.git", branch = "main" }
-omnibase-spi = { git = "https://github.com/OmniNode-ai/omnibase_spi.git", branch = "main" }
-omninode-memory = { git = "https://github.com/OmniNode-ai/omnimemory.git", branch = "main" }
+omnibase-compat = { git = "https://github.com/OmniNode-ai/omnibase_compat.git", rev = "e850cc3a2f6779957e2d5693005eb5a4a7391b6c" }
+omnibase-spi = { git = "https://github.com/OmniNode-ai/omnibase_spi.git", rev = "168c71a622f6592978344faaa95ff809b70a15cb" }
+omninode-memory = { git = "https://github.com/OmniNode-ai/omnimemory.git", rev = "87355d7d2bf675565b37de93056581cae48d3c08" }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@pyproject.toml` around lines 182 - 184, Replace the mutable branch pins with
explicit commit SHAs for the git dependencies: change omnibase-compat (currently
branch = "main") to use rev = "e850cc3a", omnibase-spi to rev = "168c71a622f",
and omninode-memory to rev = "87355d7d2bf" in pyproject.toml so the manifest
explicitly references those commits instead of the main branch.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@pyproject.toml`:
- Around line 182-184: Replace the mutable branch pins with explicit commit SHAs
for the git dependencies: change omnibase-compat (currently branch = "main") to
use rev = "e850cc3a", omnibase-spi to rev = "168c71a622f", and omninode-memory
to rev = "87355d7d2bf" in pyproject.toml so the manifest explicitly references
those commits instead of the main branch.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: af2e7a51-c233-40a1-a909-d43afd144437

📥 Commits

Reviewing files that changed from the base of the PR and between 86dc374 and 17be303.

⛔ Files ignored due to path filters (1)

• uv.lock is excluded by !**/*.lock

📒 Files selected for processing (1)

• pyproject.toml