Repository navigation
fix(OMN-19400): negative control no longer collides with widened causal markers - #2870
Merged
jonahgabriel merged 1 commit intoSep 25, 2026
Merged
Conversation
…l marker OMN-19401 (omnimarket#2851, merged same day) widened the step_by_step_explanation heuristic to also accept causal connectives (because/therefore/consequently/since/as a result/this means) so a correct causal explanation is not wrongly refused. test_an_answer_that_follows_the_directive_meets_the_rule's negative control, "9 sheep are left, because all but 9 of them died.", now contains "because" and is legitimately no longer flagged, so the assertion that it SHOULD be flagged failed dev-wide on every PR that runs Tests (Split 14/20). Replace the negative control with an answer that carries none of the ten accepted markers, and assert that directly so a future marker addition fails loudly here instead of red on an unrelated PR.
Contributor
|
OCC autobind did not mint a companion for this PR: no changed-file candidate could be proven RED against the merge base, and emitting a PR-existence probe instead would be non-falsifiable evidence (OMN-15247). Hand-authored evidence is required. |
✅ Hostile Reviewer — PASSEDBlocking findings (critical/error): 0 Gate semantics
Powered by omniintelligence.review_pairing.cli_review — node-based adversarial review via HandlerLlmCliSubprocess (OMN-8524) |
✅ Architectural Review — PASSEDErrors: 0 What this checks
No architectural violations found. Static architectural lint — no model inference (OMN-14176). |
jonahgabriel
deleted the
jonah/omn-19400-fix-negative-control-marker-collision
branch
September 25, 2026 01:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OMN-19400
Dev-wide red on Tests (Split 14/20), visible on every PR running that shard (e.g. omnimarket#2859, jobs 107816799092/107820471172).
Root cause: OMN-19401 (omnimarket#2851, merged same day) widened the
step_by_step_explanationheuristic markers to also accept causal connectives (because,therefore,consequently,since,as a result,this means), so a correct causal explanation is no longer wrongly refused. OMN-19400's own test (merged via omnimarket#2852) used a negative-control string —"9 sheep are left, because all but 9 of them died."— that now legitimately contains"because", so_apply_heuristic_checkno longer flags it, and the test's assertion that it SHOULD be flagged (is not None) failed. Two independently-correct merged PRs interacting, not a flake.Fix:
tests/unit/delegation/test_step_by_step_directive_reaches_the_model_omn19400.py— replace the negative-control string with"9 sheep are left.", which carries none of the ten accepted markers, and assert that directly so a future marker addition reddens here instead of on an unrelated PR's shard.Proof
ruff format/ruff check --fixclean,mypy --stricton the changed file:Success: no issues found in 1 source file. Pre-commit ran clean on push (all applicable hooks passed).Not runtime-affecting (test-only change, no src/ touched).
Evidence-Ticket: OMN-19400
Evidence-Source: OCC#11152