Repository navigation
ci(OMN-18638): advance the runtime-rebuild reusable pin to 5ecdeef2 - #2629
Merged
jonahgabriel merged 3 commits intoSep 18, 2026
Merged
Conversation
✅ Architectural Review — PASSEDErrors: 0 What this checks
No architectural violations found. Static architectural lint — no model inference (OMN-14176). |
jonahgabriel
enabled auto-merge (squash)
September 17, 2026 21:43
Contributor
|
OCC autobind did not mint a companion for this PR: no changed-file candidate could be proven RED against the merge base, and emitting a PR-existence probe instead would be non-falsifiable evidence (OMN-15247). Hand-authored evidence is required. |
✅ Hostile Reviewer — PASSEDBlocking findings (critical/error): 0 Gate semantics
Powered by omniintelligence.review_pairing.cli_review — node-based adversarial review via HandlerLlmCliSubprocess (OMN-8524) |
The pin selects the reusable workflow AND, through infra_ref's default of github.job_workflow_sha, the revision of the scripts the job runs. At 43bd2754 this repository's lab-pass receipts were emitted by lab_pass_receipt.py and check_dev_lane_staleness.py as they stood on 2026-09-16, so neither OMN-18436's declared settle budget nor OMN-18602's three-member verify class had reached the sibling path. The bump does not populate agent_command_id on the sibling receipt. The OMN-18573 wiring touched omnibase_infra's own caller workflow and lab_pass_receipt.py only; the reusable's emit step passes no --agent-command-id at any revision. That half stays open on OMN-18638.
The autobind publisher job failed on a full runner disk earlier, so no Evidence-Source line was ever written to this PR body. The OCC Companion Merged Gate has been failing closed on "body has no Evidence-Source: line yet (occ-autobind mint may still be in flight)" after its 1500s poll deadline. A rerun replays the pinned reusable ref and does not republish the mint command; a fresh push does. No file content changes.
jonahgabriel
force-pushed
the
jonah/omn-18638-bump-runtime-rebuild-reusable-pin
branch
from
September 18, 2026 03:46
ad7dccc to
b54ebe1
Compare
…point, and pin the settle budget Two halves of OMN-18638 that the reusable-workflow pin in the previous commit does not reach. 1. omnibase-infra floor 0.38.30 -> 0.38.31. The OMN-18626 guard landed by #2630 compares this repo's base contract against `_AUTHORIZED_BINDINGS`, which ships inside the INSTALLED omnibase_infra distribution. #2627 moved this repo's `model_name` to the served `Qwen3.8-27B`; the sibling half is 0ee5bb023 (omnibase_infra#3721) and 0.38.31 is the first published release carrying it. At 0.38.30 the two authorities disagree, the guard is red on every PR in this repository, and `render_bifrost_delegation_contract._merge_lane_overlay` would refuse the rendered contract outright -- a lab lane container start FAILS TO START rather than routing badly. 0.38.31 declares `omnibase-core==0.47.16` and `omnibase-spi==0.23.3`, both admitted by the floors already in this file, so the bump cascades nothing. 2. A test that pins the lab-pass settle budget. Before omnibase_infra `da329b6a8` (OMN-18436) the budget was not declared: it was `job ceiling - elapsed - reserved tail`, which gave this repository about 161 seconds where omnibase_infra's own caller allowed 900. A lane that needs 512 seconds to answer its readiness endpoints then emits a FAIL receipt while healthy, and under rule 24(b) that receipt refuses the sha for staging delivery. `da329b6a8` moved the number into `config/lab_pass_settle_budget.yaml`, read at `infra_ref`, which defaults to the very SHA this repository pins -- so "equalise the budget" is exactly "pin at or after `da329b6a8`", and the previous commit's pin does that. The new test keeps it there. It refuses the three pins this repository has actually run that predate the declaration, and requires the current pin to be recorded as verified, because omnibase_infra's wheel does not package that config and cross-repo git ancestry is not resolvable from a unit test. The honest limit is stated in the module docstring: this is a recorded verification, not a computed one, so the next bump re-verifies rather than inherits. A second test refuses any caller-side input naming a budget, ceiling or timeout, since the declaration over there is the single authority and a caller value answers to neither of its bounds. Verified locally: the OMN-18626 guard passes against 0.38.31 and the pin tests pass; reverting the pin to the OMN-17057 one turns the first test red with the measured reason.
jonahgabriel
deleted the
jonah/omn-18638-bump-runtime-rebuild-reusable-pin
branch
September 18, 2026 08:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes part of OMN-18638.
What this changes
One line: the pin of
OmniNode-ai/omnibase_infra/.github/workflows/runtime-rebuild-trigger-reusable.yml, from43bd2754to5ecdeef2, plus the comment recording why.Why
The pin selects the reusable workflow and, through
infra_ref's default ofgithub.job_workflow_sha, the revision of the SCRIPTS the job runs. At43bd2754this repository's lab-pass receipts were produced bylab_pass_receipt.pyandcheck_dev_lane_staleness.pyas they stood on 2026-09-16, so two changes had not reached the sibling path:da329b6a8(OMN-18436) — the settle budget stops being "job ceiling minus elapsed minus tail" and becomes a per-lane declaration inconfig/lab_pass_settle_budget.yaml, with the job ceiling derived from it. Under the old derivation any convergence slower than about 20 minutes produced a receipt that failed on timing alone, on a healthy lane running the merged sha.5ecdeef24(OMN-18602) — the lab-receipt guards move to a three-member verify class.What this does NOT fix, stated because it was expected to
It does not populate
agent_command_idon the sibling receipt. The OMN-18573 wiring (0c7586ec) touchedomnibase_infra's own caller workflow,scripts/ci/lab_pass_receipt.pyand its test — it never touched the reusable, whose emit step passes no--agent-command-idat its currentdevtip or at either pin. Verified by reading the emit invocation in both files at both revisions. That half is a change to the reusable and stays open on OMN-18638.Verification
git merge-base --is-ancestor 5ecdeef241139b5385e12f285f2dd82b8b1dd267 origin/devinomnibase_infra→ exit 0.0c7586ec(OMN-18573) is an ancestor of the new pin, so the newerlab_pass_receipt.pytravels with it even though the flag does not.omnimarket#2463.Evidence lane:
deploy-agent-http-hang-diag-2105.Second pass, 2026-09-18: what the pin bump alone did not reach
The first push was BLOCKED on
Tests. Run 35304476288 job 105507851923 reported8 failed / 22194 passed, in two classes, neither caused by the pin bump.
Class 1, fixed here. One failure in the OMN-18626 two-repo guard landed by
#2630: this repository's base contract says
Qwen3.8-27B(moved there by #2627)while the INSTALLED
omnibase-infra0.38.30 binding table still saysQwen3.6-35B-A3B. That table ships inside the distribution, so which release isinstalled decides what the guard compares against. The sibling half is
0ee5bb023(omnibase_infra#3721) and 0.38.31 is the first published releasecarrying it, so this pass raises the floor 0.38.30 -> 0.38.31 in
pyproject.tomland relocks. 0.38.31 declares
omnibase-core==0.47.16andomnibase-spi==0.23.3, both admitted by the floors already in this file, sonothing cascades. The guard is red on every open PR in this repository at
0.38.30, so this unblocks more than this one.
Class 2, not mine. Seven failures in
tests/test_omn18565_ordering_independent_verdict_terminal_rls.py, allpsycopg2.errors.InvalidTextRepresentation: invalid input syntax for type uuid: "omninode", raised fromhandler_projection_delegation._publish_aggregate_snapshotspassing the wrongvalue as the aggregate read's tenant filter. That is already owned by open
#2633, whose subject is exactly binding the aggregate read to the returned
tenant. I have not competed with it and have written nothing in that file.
The settle budget, adopted onto this ticket
Before omnibase_infra
da329b6a8(OMN-18436) the lab-pass settle budget was notdeclared anywhere: it was
job ceiling - elapsed - reserved tail, which gavethis repository about 161 seconds where omnibase_infra's own caller allowed 900.
A lane that needs 512 seconds to answer its readiness endpoints then emits a
FAIL receipt while healthy, and under rule 24(b) that receipt refuses the sha
for staging delivery.
da329b6a8moved the number intoconfig/lab_pass_settle_budget.yaml, read atinfra_ref, which defaults to theSHA this repository pins -- so equalising the budget is exactly pinning at or
after
da329b6a8, which the first commit already does.tests/ci/test_lab_pass_settle_budget_pin_omn18638.pykeeps it there. Itrefuses the three pins this repository has actually run that predate the
declaration, and requires the current pin to be recorded as verified.
omnibase_infra's wheel packages only
src/omnibase_infra, so that config doesnot reach an installed distribution, and cross-repo git ancestry is not
resolvable from a unit test -- the docstring states that limit rather than
implying it, and the failure message names the
git merge-base --is-ancestorcommand a future bumper must run. A second test refuses any caller-side input
naming a budget, a ceiling or a timeout.
Verification, second pass
uv run pytest tests/unit/delegation/test_base_contract_agrees_with_installed_lab_bindings_omn18626.py tests/ci/test_lab_pass_settle_budget_pin_omn18638.py tests/ci/test_rebuild_trigger_pin_omn18387.py -q-> 6 passed, against installedomnibase-infra 0.38.31.test_the_pin_carries_the_declared_settle_budgetred with the measuredreason, then the file was restored byte-identical to HEAD.
Evidence lane:
omn18638-pr2629-fix-0800.Evidence-Source: OCC#10132
Evidence-Ticket: OMN-18638