Repository navigation
fix(OMN-13124): repoint routing_decision contract DB target to omnibase_infra - #1213
jonahgabriel wants to merge 1 commit into
Conversation
…se_infra node_projection_routing_decision declared db_io.db_tables[].database: omnidash_analytics, but agent_routing_decisions only exists in omnibase_infra (DDL owner: omnibase_infra migration 021; this node is a NON-OWNER WRITER with metadata duplicate_migration_policy: forbid_cross_repo_create_table). The omnibase_infra runtime auto-wiring (handler_wiring._DB_URL_ENV_MAP) resolves the contract database field to the DSN env var, so the prior value pointed the write at OMNIDASH_ANALYTICS_DB_URL where the table does not exist — the handler logged UndefinedTable (golden-chain sweep run12 Finding). Repoint database -> omnibase_infra so the auto-wiring connects the write to OMNIBASE_INFRA_DB_URL. This makes writer DSN == reader DSN: the registration golden chain already reads agent_routing_decisions from omnibase_infra and passes. Single canonical DB home, no divergent duplicate table (the OMN-13127 invariant; the contract's own forbid_cross_repo_create_table policy explicitly prohibits adding an omnidash_analytics CREATE TABLE). Follows the existing node_projection_overnight precedent (also database: omnibase_infra). Handler INSERT column set (id, correlation_id, selected_agent, confidence_score, created_at, request_type, alternatives, routing_reason, domain, metadata, project_path, project_name, claude_session_id) matches the omnibase_infra agent_routing_decisions schema exactly (migration 021 + 028), verified against a throwaway postgres 14. Verify: ruff clean; mypy --strict clean (6 files); routing_decision node tests 16/16; runtime dogfood + projection materialization validation 9/9. Evidence-Source: OCC#<pending>
|
Warning Review limit reached
More reviews will be available in 55 minutes and 8 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
✅ Architectural Review — PASSEDErrors: 0 What this checks
No architectural violations found. Powered by node_pr_review_bot |
✅ PR Review Bot — CLEANFindings: 0
Verdict semantics
Powered by node_pr_review_bot — Qwen3-Coder-30B reviewer + DeepSeek-R1 judge (OMN-7963) |
|
| Verdict | Meaning | Blocks merge? |
|---|---|---|
passed |
No critical/error findings | No |
blocked |
CRITICAL or ERROR findings found | Yes |
degraded |
All models unavailable (infra) | No (pilot) |
Powered by omniintelligence.review_pairing.cli_review — node-based adversarial review via HandlerLlmCliSubprocess (OMN-8524)
|
Superseded by a re-named branch (jonah/omn-13124-routing-decision-db-repoint) so the receipt-gate identity binding matches Evidence-Ticket: OMN-13124. |
Pull request was closed
OMN-13124 — make routing_decision write target durable (capstone Finding #1 residual)
node_projection_routing_decisiondeclareddb_io.db_tables[].database: omnidash_analytics, butagent_routing_decisionsonly exists inomnibase_infra(DDL owner: migration 021; this node is a NON-OWNER WRITER withforbid_cross_repo_create_table). The omnibase_infra runtime auto-wiring (handler_wiring._DB_URL_ENV_MAP) resolves the contractdatabasefield to the DSN env var, so the prior value pointed the write atOMNIDASH_ANALYTICS_DB_URLwhere the table does not exist — the handler loggedUndefinedTable(golden-chain sweep run12 Finding).This change is the companion to the routing-decision projection node (the original projection node landed under a separate ticket) and is grouped with the pattern_learning durability work under OMN-13124.
Change
Repoint
database->omnibase_infra(one field + explanatory comment). The auto-wiring then connects the write toOMNIBASE_INFRA_DB_URL, where the table lives. This makes writer DSN == reader DSN: the registration golden chain already readsagent_routing_decisionsfromomnibase_infraand passes. Single canonical DB home, no divergent duplicate table (the duplicate-tail-table invariant; the node's ownforbid_cross_repo_create_tablepolicy prohibits adding an omnidash_analytics CREATE TABLE). Follows the existingnode_projection_overnightprecedent (alsodatabase: omnibase_infra).Verification (local)
omnibase_infraagent_routing_decisionsschema exactly (migration 021 + 028), verified against throwaway postgres 14.ruffclean;mypy --strictclean (6 files); routing node tests 16/16; runtime dogfood + projection materialization validation 9/9.Contract DB target only — no DDL, no new migration, no live deploy, no .201 mutation.
Evidence-Source: OCC#2618
Evidence-Ticket: OMN-13124
Do NOT merge — reported for the lead to enqueue.