Repository navigation
feat(OMN-12795): guidance section parser + provenance fields on ModelContextPackArtifact - #1098
Conversation
…odelContextPackArtifact Extends ModelContextPackArtifact with four optional provenance fields (source_file, heading_path, char_count, reason_selected) that section-parsed guidance artifacts populate; all existing callers remain valid (fields default to None). Adds omnimarket.nodes.node_context_pack_builder_compute.parsers.parser_guidance_section — a pure COMPUTE-eligible GuidanceSectionParser that splits guidance file text at ATX heading boundaries into typed ParsedSection objects, each convertible to a ModelContextPackArtifact via to_artifact(). Zero filesystem I/O: the caller (EFFECT side) supplies raw text; the parser returns deterministic output. 16 new unit tests cover heading parsing, nesting, provenance field storage, to_artifact() round-trip, and hash stability. Full suite: 6330 passed, 0 failed. mypy --strict: 0 issues. All pre-commit hooks pass.
|
Warning Review limit reached
More reviews will be available in 50 minutes and 28 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (9)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
✅ Architectural Review — PASSEDErrors: 0 What this checks
No architectural violations found. Powered by node_pr_review_bot |
✅ PR Review Bot — CLEANFindings: 0
Verdict semantics
Powered by node_pr_review_bot — FSM pipeline with multi-model review fan-out |
|
| Verdict | Meaning | Blocks merge? |
|---|---|---|
passed |
No critical/error findings | No |
blocked |
CRITICAL or ERROR findings found | Yes |
degraded |
All models unavailable (infra) | No (pilot) |
Powered by omniintelligence.review_pairing.cli_review — node-based adversarial review via HandlerLlmCliSubprocess (OMN-8524)
Summary
Evidence
Evidence-Source: OCC#2311
Evidence-Ticket: OMN-12795
Deployment
Additive only — no deploy, no shared-pin bump, no main promotion. Per plan §P2 parallelisation rules: feature→dev, no lane deploy until coordinated deploy.
Test plan