Repository navigation
ci(OMN-20998): omnidash's pr-title check runs omnimarket's node, not onex_change_control's reusable - #393
Merged
Conversation
onexbot-occ-writer Bot
pushed a commit
to OmniNode-ai/onex_change_control
that referenced
this pull request
Oct 11, 2026
…mniNode-ai/omnidash#393 OCC companion by node_pr_lifecycle_fix_effect (OMN-13317 F1 / OMN-13990 / OMN-14285). Product PR head 60b027df3d60dc1c792729292e01dad97bfff3b6.
jonahgabriel
force-pushed
the
occ-ret-prtitledash-omn-20998-i3-8e80
branch
from
October 14, 2026 14:57
60b027d to
3f822b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lab: host=h201 lane=occ-ret-prtitledash-i3-8e80 command=
uv run --no-project --with pytest --with pyyaml python -m pytest tests/ci/test_pr_title_check_omnimarket_node.py -q --noconftest -p no:cacheprovider -c /dev/nullobserved=31 passed; merge-base control at c1eadc4 returned exit 1, 3 failed and 28 passed.Ticket: OMN-20998.
Run
omnimarket.nodes.node_pr_title_check_computefrom publishedomnimarket==0.4.310, using the omniclaude job shape. Preserve job idpr-title, contextpr-title / check-title, opened/edited triggers and the runner expression. Add the missing local producer row, the installed-node parity test, its pre-commit hook and the child's contract. The existing receipt gate executes the contract's test commands.The test covers 25 title/author verdict cases and three malformed requests. The actual workflow run block admitted an OMN title (exit 0), refused a bare title (exit 1) and admitted a
chore(deps)title (exit 0). The downloaded PyPI wheel contains the node andHandlerPrTitleCheck.Lab: host=h201 lane=occ-ret-prtitledash-i3-8e80 observed=node_dod_verify local_done_gate dry-run verified 3/3 on the edited tree (exit 0) and failed 3/3 on the merge-base control (exit 1); actionlint passed (exit 0), invalid-job-key control failed (exit 1). These are pre-PR contract-source-unbound checks.
All selected pre-commit hooks passed. The commit retry exposed normalization-symmetry's sibling-checkout assumption, so the hook now runs the same checker from
omnibase-core==0.47.39in an isolated Python environment. Its checker matches the canonical source byte-for-byte; a planted normalization mismatch fails with exit 1. The full selected-file pre-commit run passes without core environment overrides. Ruff check/format and whitespace checks passed.The offline advisory gate reports six findings on dev and seven with this change, using the controller's reread 24-context cache. The only added finding is
pr-title-check.yml::pr-title UNENFORCED_VERIFICATION_JOB: pre-existing unenforced pr-title context, now visible; the orchestrator adds pr-title / check-title to omnidash:dev required contextsEvidence-Ticket: OMN-20998
Evidence-Source: OCC#13696