Repository navigation
fix(OMN-20937): contract.local.yaml.example broker becomes a placeholder - #389
Merged
Merged
Conversation
… in contract.local.yaml.example contract.local.yaml.example carried a lab broker address (a host and port) and a person's name in a comment. The broker value becomes the placeholder "<broker-host>:<port>" and the comment says contract.local.yaml holds your own deployment's endpoints. Adds contracts/OMN-20937.yaml with a grep check that the example holds no 192.168 address and no tailnet name. The same ticket removes the matching lab values from the omniclaude repository in its own pull request.
Contributor
|
OCC autobind did not mint a companion for this PR: no changed-file candidate could be proven RED against the merge base, and emitting a PR-existence probe instead would be non-falsifiable evidence (OMN-15247). Hand-authored evidence is required. Considered 2 changed file(s):
This verdict is occ-autobind's, derived from this head and its merge base alone. A second producer, the occ-companion-effect backstop, consumes its own command on the lab bus and may still mint a companion under the generic binding. Whether it does depends on that consumer running, not on this diff (OMN-18876). |
…-20937-contract-local-placeholder
jonahgabriel
added a commit
to OmniNode-ai/onex_change_control
that referenced
this pull request
Oct 14, 2026
* evidence(OMN-20937): add omnidash PR 389 placeholder evidence This commit appends one dod_evidence item, dod-omn20937-omnidash-pr-389-example-placeholder, binding AC1, for OmniNode-ai/omnidash#389. Its command check reads contract.local.yaml.example at omnidash head 55d96573 with git show, requires the placeholder <broker-host>:<port>, and refuses any 192.168 address or .ts.net name. It adds the PASS receipt, captured with check_receipt_hardening --capture-probe: green (exit 0) at 55d96573, red (exit 1) at merge base d8087405. Existing items are unchanged. * evidence(OMN-18921): mint the owed OCC self-bind for PR #13808 * chore(omn-20937): add repository provenance comment to dod-omn20937-omnidash-pr-389-example-placeholder * evidence(OMN-18921): mint the owed OCC self-bind for PR #13808 --------- Co-authored-by: onexbot-occ-writer[bot] <onexbot-occ-writer[bot]@users.noreply.github.com>
repo-evidence / dod-verify failed on omnidash PR 389 at head 58ab6fb with "no test-side change: the bound tests cannot be shown to fail at the merge base". Adds tests/ci/test_contract_local_example_omn20937.py (3 pytest tests: contract.local.yaml.example holds no private LAN address, no tailnet name, and its event_bus.bootstrap_servers is the placeholder "<broker-host>:<port>") and binds it as a test_passes check in contracts/OMN-20937.yaml. Locally: 3 passed at head; 2 failed at merge base 9618276.
The change adds AC1 for the broker placeholder and AC2 for the absence of private LAN addresses and tailnet names to contracts/OMN-20937.yaml, with one dod_evidence entry per criterion bound to the existing focused pytest selections. This addresses the repo-evidence / dod-verify failure that occurred with zero bound checks because the file had no binds_ac. The existing regression suite shows 3 passed, and the contract passes omnibase-core==0.47.39 ModelTicketContract. Both bound pytest selections and the existing grep command pass in the updated worktree and fail against the example from merge-base 1c40fd3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ticket OMN-20937. Operator RULING 2026-10-10T21:57:38Z: lab and deployment configuration does not belong in a shipped repository.
Changes
Verification
grep -nE '192\.168|\.ts\.net' contract.local.yaml.examplepython3 yaml.safe_loadof the fileLab: host=omninode-pc (h201) lane=config-out-6-9f8a command=
grep -nE '192\.168|\.ts\.net' contract.local.yaml.exampleandpython3 -c yaml.safe_loadof the file observed=at head 14705ec grep exit 1 (no match), the file parsesEvidence-Source: OCC#13808
Evidence-Ticket: OMN-20937