Skip to content

fix(OMN-17292): declare the correlation-trace reader on delegation-control-plane - #373

Closed
jonahgabriel wants to merge 1 commit into
devfrom
omn-17292-correlation-trace-reader
Closed

jonahgabriel wants to merge 1 commit into
devfrom
omn-17292-correlation-trace-reader

Conversation

@jonahgabriel

Copy link
Copy Markdown
Contributor

What

scripts/generate-registry.ts adds projectionSource(TOPICS.delegationCorrelationTrace, false) to the dataSources of the registered component delegation-control-plane. src/registry/component-registry.json is regenerated with one new dataSources object plus the generatedAt stamp. There is no UI, component, route, or behaviour change.

Why

omnibase_infra's exposure-reader-coverage gate (OMN-17199) resolves readers only from this registry's dataSources. Because the reader was missing, the exposure reported code no_reader and blocked every omnimarket contract-pin advance in omnibase_infra (OmniNode-ai/omnibase_infra#4666, OmniNode-ai/omnibase_infra#4677). The component already reads the topic: DelegationControlPlane renders DelegationEvidenceTabs, whose DelegationCorrelationTracePanel calls fetchCorrelationTrace in src/services/delegation-api.ts, which GETs projectionUrl(TOPICS.delegationCorrelationTrace, correlation_id=...). The topic onex.snapshot.projection.delegation.correlation-trace.v1 was made bus_backed by omnimarket#3440 (OMN-19976), and the lab served catalogue in this repo lists it status ok.

Evidence

The gate run locally against omnimarket d2b0d9986ed7 and this registry printed "OK: 23 served bus_backed exposure(s), 0 without a reader" and resolved correlation-trace to "delegation-control-plane, delegation-evidence.ts". Against omnidash 8db0048 it failed only on correlation-trace with code no_reader. npx vitest run over scripts/generate-registry.test.ts, shared/types/component-manifest.test.ts, src/templates/templates.test.ts, src/components/dashboard/delegation-control-plane/, src/components/dashboard/ComponentPalette.test.tsx and src/pages/local/: 18 files, 243 tests passed.

Evidence-Ticket: OMN-17292

@onexbot-occ-writer

Copy link
Copy Markdown
Contributor

OCC autobind did not mint a companion for this PR: no changed-file candidate could be proven RED against the merge base, and emitting a PR-existence probe instead would be non-falsifiable evidence (OMN-15247). Hand-authored evidence is required.

Considered 2 changed file(s):

  • scripts/generate-registry.ts: no candidate grammar reads this file type (only Python declarations, uv.lock lines, release-artefact lines and contract-pin lines are proposed)
  • src/registry/component-registry.json: no candidate grammar reads this file type (only Python declarations, uv.lock lines, release-artefact lines and contract-pin lines are proposed)

This verdict is occ-autobind's, derived from this head and its merge base alone. A second producer, the occ-companion-effect backstop, consumes its own command on the lab bus and may still mint a companion under the generic binding. Whether it does depends on that consumer running, not on this diff (OMN-18876).

…ntrol-plane

scripts/generate-registry.ts adds projectionSource(TOPICS.delegationCorrelationTrace, false) to the dataSources of the registered component delegation-control-plane. This regenerates src/registry/component-registry.json with one new dataSources object and the generatedAt stamp, without any UI, component, route, or behaviour change. The component already reads the topic: DelegationControlPlane renders DelegationEvidenceTabs, whose DelegationCorrelationTracePanel calls fetchCorrelationTrace in src/services/delegation-api.ts, which GETs projectionUrl(TOPICS.delegationCorrelationTrace, correlation_id=...). The component is placed on the shipped template src/templates/delegation-evidence.ts.
@jonahgabriel

Copy link
Copy Markdown
Contributor Author

landing-controller (OMN-19998, OMN-17427): closing this PR as superseded: superseded by the merged omnidash#382. A worker judged it at becf891 and the controller verified it live before closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant