Skip to content

fix(OMN-9875): point generate:fixtures wrapper at local script - #18

Merged
github-actions[bot] merged 1 commit into
mainfrom
jonah/omn-9875-fix-fixtures-wrapper
Apr 26, 2026
Merged

github-actions[bot] merged 1 commit into
mainfrom
jonah/omn-9875-fix-fixtures-wrapper

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented Apr 26, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Fixes npm run generate:fixtures which errored with generate_fixtures.py not found at $OMNIBASE_INFRA_PATH/scripts/generate_fixtures.py
  • The script lives in omnidash-v2/scripts/generate_fixtures.py (v2-specific, not shared infra); wrapper was copy-pasted from an infra pattern
  • OMNIBASE_INFRA_PATH is still required — used by uv run --project to resolve Python deps (omnibase_infra.projectors.file_snapshot_sink)

Changes

  • scripts/run-generate-fixtures.sh: SCRIPT_PATH now points at $REPO/scripts/generate_fixtures.py instead of $OMNIBASE_INFRA_PATH/scripts/generate_fixtures.py; updated header comment to clarify separation of concerns
  • .env.example: added two-line clarification explaining OMNIBASE_INFRA_PATH is for Python deps only, not the script location

DoD Evidence

OMN-9875 — npm run generate:fixtures exits 0 locally with OMNIBASE_INFRA_PATH set:

generating onex.snapshot.projection.llm_cost.v1 (192 records)
generating onex.snapshot.projection.delegation.summary.v1 (1 records)
generating onex.snapshot.projection.delegation.decisions.v1 (15 records)
generating onex.snapshot.projection.overnight.v1 (1 records)
generating onex.snapshot.projection.baselines.quality.v1 (1 records)
generating onex.snapshot.projection.baselines.roi.v1 (1 records)
generating onex.snapshot.projection.registration.v1 (15 records)
generating onex.event.raw.registration.v1 (10 records)
generating onex.event.raw.llm_cost.v1 (10 records)
generating onex.event.raw.overnight.v1 (10 records)
generating onex.event.raw.delegation.v1 (10 records)
generating onex.event.raw.baselines.v1 (10 records)
done — wrote to fixtures

7 projection files + 5 raw event files written. Exit code 0.

Summary by CodeRabbit

  • Documentation
    • Updated fixture generation and development environment configuration documentation to clarify script locations and dependency resolution procedures.

The wrapper looked for generate_fixtures.py in $OMNIBASE_INFRA_PATH/scripts/
but the script lives in omnidash-v2/scripts/. OMNIBASE_INFRA_PATH is still
needed for `uv run --project` to resolve Python deps from omnibase_infra.
Updated .env.example to clarify what OMNIBASE_INFRA_PATH is used for.
@linear

linear Bot commented Apr 26, 2026

Copy link
Copy Markdown

OMN-9875

@coderabbitai

coderabbitai Bot commented Apr 26, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Lite

Run ID: 13c7ce03-c9f2-4a97-8c6d-0aa54af9f60a

📥 Commits

Reviewing files that changed from the base of the PR and between f32a833 and 6f2e839.

📒 Files selected for processing (2)
  • .env.example
  • scripts/run-generate-fixtures.sh

📝 Walkthrough

Walkthrough

Documentation and configuration updates to clarify that the generate_fixtures.py script is located in the current repository's scripts/ directory, while uv run --project still uses OMNIBASE_INFRA_PATH to resolve dependencies.

Changes

Cohort / File(s) Summary
Environment Documentation
.env.example
Added clarifying comments explaining that OMNIBASE_INFRA_PATH is used by uv run --project to resolve dependencies for omnibase_infra.projectors.*, and that generate_fixtures.py is located in the current repository's scripts/ directory.
Fixture Generation Script
scripts/run-generate-fixtures.sh
Updated header documentation and modified SCRIPT_PATH variable to reference $REPO/scripts/generate_fixtures.py instead of the external omnibase_infra location, while retaining the uv run --project "$OMNIBASE_INFRA_PATH" invocation for dependency resolution.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 A fixture script finds its true home,
Within our scripts, no more to roam,
While infra paths resolve with care,
Dependencies dance through the air,
Comments guide us, clear and bright! ✨


Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
github-actions Bot merged commit accfa2a into main Apr 26, 2026
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant