Repository navigation
fix(OMN-9875): point generate:fixtures wrapper at local script - #18
Merged
Merged
Conversation
The wrapper looked for generate_fixtures.py in $OMNIBASE_INFRA_PATH/scripts/ but the script lives in omnidash-v2/scripts/. OMNIBASE_INFRA_PATH is still needed for `uv run --project` to resolve Python deps from omnibase_infra. Updated .env.example to clarify what OMNIBASE_INFRA_PATH is used for.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Lite Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughDocumentation and configuration updates to clarify that the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm run generate:fixtureswhich errored withgenerate_fixtures.py not found at $OMNIBASE_INFRA_PATH/scripts/generate_fixtures.pyomnidash-v2/scripts/generate_fixtures.py(v2-specific, not shared infra); wrapper was copy-pasted from an infra patternOMNIBASE_INFRA_PATHis still required — used byuv run --projectto resolve Python deps (omnibase_infra.projectors.file_snapshot_sink)Changes
scripts/run-generate-fixtures.sh:SCRIPT_PATHnow points at$REPO/scripts/generate_fixtures.pyinstead of$OMNIBASE_INFRA_PATH/scripts/generate_fixtures.py; updated header comment to clarify separation of concerns.env.example: added two-line clarification explaining OMNIBASE_INFRA_PATH is for Python deps only, not the script locationDoD Evidence
OMN-9875 —
npm run generate:fixturesexits 0 locally with OMNIBASE_INFRA_PATH set:7 projection files + 5 raw event files written. Exit code 0.
Summary by CodeRabbit