Repository navigation
ci(OMN-14104): gate CI fanout behind OCC preflight - #1868
Merged
Merged
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 48 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughA centralized ChangesOCC preflight gating rollout
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
|
| Verdict | Meaning | Blocks merge? |
|---|---|---|
passed |
No critical/error findings | No |
blocked |
CRITICAL or ERROR findings found | Yes |
degraded |
All models unavailable (infra) | No (pilot) |
Powered by omniintelligence.review_pairing.cli_review — node-based adversarial review via HandlerLlmCliSubprocess (OMN-8524)
jonahgabriel
force-pushed
the
jonah/omn-14104-occ-first-ci-gating
branch
from
July 7, 2026 13:42
1a8a05f to
767eb3c
Compare
jonahgabriel
enabled auto-merge (squash)
July 7, 2026 18:39
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/ci.yml (1)
2068-2079: 🔒 Security & Privacy | 🟠 Major | ⚡ Quick winDo not let OCC failure skip required gates
.github/workflows/ci.yml:2068-2079, 2636-2687, 2750-2768, 2801-2815, 2919-2930
needs.occ-preflight.result == 'success' &&makes these jobs skip when OCC fails; skipped required checks count as passing, so branch protection can still merge. Keepquality-gate,tests-gate,security-gate,ci-summary, anddod-evidence-checkpresent and fail them explicitly whenocc-preflightis notsuccess.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/ci.yml around lines 2068 - 2079, The required CI gates are currently being skipped when occ-preflight fails because the downstream job conditions gate on needs.occ-preflight.result == 'success', which can let branch protection treat them as passing. Update the affected jobs (quality-gate, tests-gate, security-gate, ci-summary, and dod-evidence-check) in the CI workflow so they always remain present and explicitly fail when occ-preflight is not successful, using the existing job names and needs.occ-preflight dependency to locate and adjust the conditions.
🧹 Nitpick comments (1)
.github/workflows/cr-thread-gate.yml (1)
28-39: 🚀 Performance & Scalability | 🔵 Trivial | ⚡ Quick winMake the reusable CR thread gate skip
occ-preflightfor upstream-gated callers. Both in-repo callers already run their ownocc-preflightbefore invoking this workflow, so this nested preflight repeats the same cross-repo check on every run and adds avoidable latency/API calls. Add an input to disable the internal preflight for callers that have already gated upstream.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/cr-thread-gate.yml around lines 28 - 39, Update the reusable CR thread gate workflow so the occ-preflight job can be skipped when the caller has already run gating upstream. Add a workflow input on the reusable entry point and use it to conditionally bypass the occ-preflight job in .github/workflows/cr-thread-gate.yml, while keeping gate dependent on the preflight only when enabled. Refer to the occ-preflight and gate jobs and the reusable workflow inputs block when making the change.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yml:
- Around line 26-35: The occ-preflight job is missing the permissions needed by
the reusable workflow. Update the occ-preflight job in the CI workflow to
include a permissions block matching the other callers, granting contents: read
and pull-requests: read so the occ-preflight reusable workflow can access PR
metadata when needed.
---
Outside diff comments:
In @.github/workflows/ci.yml:
- Around line 2068-2079: The required CI gates are currently being skipped when
occ-preflight fails because the downstream job conditions gate on
needs.occ-preflight.result == 'success', which can let branch protection treat
them as passing. Update the affected jobs (quality-gate, tests-gate,
security-gate, ci-summary, and dod-evidence-check) in the CI workflow so they
always remain present and explicitly fail when occ-preflight is not successful,
using the existing job names and needs.occ-preflight dependency to locate and
adjust the conditions.
---
Nitpick comments:
In @.github/workflows/cr-thread-gate.yml:
- Around line 28-39: Update the reusable CR thread gate workflow so the
occ-preflight job can be skipped when the caller has already run gating
upstream. Add a workflow input on the reusable entry point and use it to
conditionally bypass the occ-preflight job in
.github/workflows/cr-thread-gate.yml, while keeping gate dependent on the
preflight only when enabled. Refer to the occ-preflight and gate jobs and the
reusable workflow inputs block when making the change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: ff0b1a73-0ab1-4427-a8a1-326294a6b307
📒 Files selected for processing (51)
.github/workflows/auto-merge.yml.github/workflows/ban-hardcoded-runner-ip.yml.github/workflows/call-occ-preflight.yml.github/workflows/call-receipt-gate.yml.github/workflows/call-reject-skip.yml.github/workflows/canonical-inference-gate.yml.github/workflows/check-handshake.yml.github/workflows/check-instructional-skills.yml.github/workflows/ci.yml.github/workflows/concurrency-primitive-guard.yml.github/workflows/contract-validation.yml.github/workflows/cr-thread-check.yml.github/workflows/cr-thread-gate-caller.yml.github/workflows/cr-thread-gate.yml.github/workflows/daemon-venv-skew-gate.yml.github/workflows/defect-anchor-gate.yml.github/workflows/dep-provenance-gate.yml.github/workflows/deploy-gate-reusable.yml.github/workflows/deploy-gate.yml.github/workflows/docs-validate.yml.github/workflows/handoff-infra-health-gate.yml.github/workflows/hook-log-path-lint.yml.github/workflows/hostile-reviewer.yml.github/workflows/imperative-contract-guard.yml.github/workflows/integration-tests.yml.github/workflows/main-target-guard.yml.github/workflows/no-faked-boundary.yml.github/workflows/non-dev-base-guard.yml.github/workflows/omni-standards-compliance.yml.github/workflows/omnimarket-dispatch-drift-gate.yml.github/workflows/onex-schema-compat.yml.github/workflows/plan-hard-fields-gate.yml.github/workflows/plan-verified-state-gate.yml.github/workflows/plugin-compat-gate.yml.github/workflows/pr-title-check.yml.github/workflows/receipt-honesty.yml.github/workflows/reject-deploy-gate-skip.yml.github/workflows/reject-imperative-skills.yml.github/workflows/security-scan.yml.github/workflows/session-id-canonical-lint.yml.github/workflows/skill-mcp-ref-lint.yml.github/workflows/skill-receipt-mode-gate.yml.github/workflows/stale-todo-gate.yml.github/workflows/url-authority-gate.yml.github/workflows/validate-agent-configs.yml.github/workflows/validate-pr-contracts.yml.github/workflows/validate-skill-aspiration.yml.github/workflows/validate-skill-backing-node.yml.github/workflows/validate-validator-requirements.yml.github/workflows/validator-runtime-profiles.yml.github/workflows/verification-evidence-lint.yml
jonahgabriel
disabled auto-merge
July 8, 2026 17:00
…tartup_failure
The reusable occ-preflight.yml declares permissions {contents: read,
pull-requests: read}. ci.yml has no workflow-level permissions block, so the
occ-preflight reusable-call job inherited the repo default token (read =
pull-requests: none). A called workflow cannot request more than the caller
grants, so GitHub rejected the entire CI workflow at startup (startup_failure)
on every attempt — deterministic and specific to this branch, invisible to
actionlint. Mirror the grant that the standalone call-occ-preflight.yml already
sets, scoped to the single job for zero blast radius on the other 60 jobs.
jonahgabriel
force-pushed
the
jonah/omn-14104-occ-first-ci-gating
branch
from
July 9, 2026 12:03
990168a to
3666476
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/ci.yml (1)
2825-2844: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
boundary-parity'sif:doesn't check occ-preflight result.
needs: occ-preflightwas added, but the job's customif:(lines 2836-2839) still only checksgithub.event_name/changed_files— it never referencesneeds.occ-preflight.result. Since a customif:overrides GitHub's implicitsuccess()gating onneeds, this job will still run when occ-preflight fails, defeating the PR's goal of gating runner-heavy validation behind OCC eligibility.🐛 Proposed fix
if: >- + needs.occ-preflight.result == 'success' && ( github.event_name == 'merge_group' || github.event_name == 'push' || - contains(github.event.pull_request.changed_files || '0', '0') == false + contains(github.event.pull_request.changed_files || '0', '0') == false)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/ci.yml around lines 2825 - 2844, The boundary-parity job’s custom if: is bypassing the implicit success gating from needs: occ-preflight, so it can still run after occ-preflight fails. Update the boundary-parity job condition in ci.yml to explicitly require the occ-preflight result to be successful, while preserving the existing event_name and changed_files logic. Use the boundary-parity job definition and the occ-preflight dependency as the key symbols to locate the change.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/security-scan.yml:
- Around line 277-296: The SARIF upload guard in the Checkov workflow is
checking the wrong output path, so the upload step may be skipped even when
results exist. Update the hashFiles condition in the security-scan workflow to
match the actual Checkov output location used by the Upload Checkov results
step, and keep the existing upload target aligned with that same path.
---
Outside diff comments:
In @.github/workflows/ci.yml:
- Around line 2825-2844: The boundary-parity job’s custom if: is bypassing the
implicit success gating from needs: occ-preflight, so it can still run after
occ-preflight fails. Update the boundary-parity job condition in ci.yml to
explicitly require the occ-preflight result to be successful, while preserving
the existing event_name and changed_files logic. Use the boundary-parity job
definition and the occ-preflight dependency as the key symbols to locate the
change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 47811853-9a20-4a5c-89ab-5eecf0950716
📒 Files selected for processing (48)
.github/workflows/auto-merge.yml.github/workflows/ban-hardcoded-runner-ip.yml.github/workflows/call-occ-preflight.yml.github/workflows/call-receipt-gate.yml.github/workflows/call-reject-skip.yml.github/workflows/canonical-inference-gate.yml.github/workflows/check-handshake.yml.github/workflows/check-instructional-skills.yml.github/workflows/ci.yml.github/workflows/concurrency-primitive-guard.yml.github/workflows/contract-validation.yml.github/workflows/daemon-venv-skew-gate.yml.github/workflows/defect-anchor-gate.yml.github/workflows/dep-provenance-gate.yml.github/workflows/deploy-gate-reusable.yml.github/workflows/deploy-gate.yml.github/workflows/docs-validate.yml.github/workflows/handoff-infra-health-gate.yml.github/workflows/hook-log-path-lint.yml.github/workflows/hostile-reviewer.yml.github/workflows/imperative-contract-guard.yml.github/workflows/integration-tests.yml.github/workflows/main-target-guard.yml.github/workflows/no-faked-boundary.yml.github/workflows/non-dev-base-guard.yml.github/workflows/omni-standards-compliance.yml.github/workflows/omnimarket-dispatch-drift-gate.yml.github/workflows/onex-schema-compat.yml.github/workflows/plan-hard-fields-gate.yml.github/workflows/plan-verified-state-gate.yml.github/workflows/plugin-compat-gate.yml.github/workflows/pr-title-check.yml.github/workflows/receipt-honesty.yml.github/workflows/reject-deploy-gate-skip.yml.github/workflows/reject-imperative-skills.yml.github/workflows/security-scan.yml.github/workflows/session-id-canonical-lint.yml.github/workflows/skill-mcp-ref-lint.yml.github/workflows/skill-receipt-mode-gate.yml.github/workflows/stale-todo-gate.yml.github/workflows/url-authority-gate.yml.github/workflows/validate-agent-configs.yml.github/workflows/validate-pr-contracts.yml.github/workflows/validate-skill-aspiration.yml.github/workflows/validate-skill-backing-node.yml.github/workflows/validate-validator-requirements.yml.github/workflows/validator-runtime-profiles.yml.github/workflows/verification-evidence-lint.yml
✅ Files skipped from review due to trivial changes (1)
- .github/workflows/call-occ-preflight.yml
🚧 Files skipped from review as they are similar to previous changes (44)
- .github/workflows/validate-skill-backing-node.yml
- .github/workflows/hook-log-path-lint.yml
- .github/workflows/docs-validate.yml
- .github/workflows/deploy-gate.yml
- .github/workflows/plan-verified-state-gate.yml
- .github/workflows/main-target-guard.yml
- .github/workflows/canonical-inference-gate.yml
- .github/workflows/validate-agent-configs.yml
- .github/workflows/plan-hard-fields-gate.yml
- .github/workflows/omnimarket-dispatch-drift-gate.yml
- .github/workflows/session-id-canonical-lint.yml
- .github/workflows/no-faked-boundary.yml
- .github/workflows/daemon-venv-skew-gate.yml
- .github/workflows/defect-anchor-gate.yml
- .github/workflows/call-receipt-gate.yml
- .github/workflows/concurrency-primitive-guard.yml
- .github/workflows/receipt-honesty.yml
- .github/workflows/check-instructional-skills.yml
- .github/workflows/validate-validator-requirements.yml
- .github/workflows/handoff-infra-health-gate.yml
- .github/workflows/validate-pr-contracts.yml
- .github/workflows/reject-deploy-gate-skip.yml
- .github/workflows/skill-mcp-ref-lint.yml
- .github/workflows/validator-runtime-profiles.yml
- .github/workflows/auto-merge.yml
- .github/workflows/call-reject-skip.yml
- .github/workflows/dep-provenance-gate.yml
- .github/workflows/integration-tests.yml
- .github/workflows/deploy-gate-reusable.yml
- .github/workflows/validate-skill-aspiration.yml
- .github/workflows/verification-evidence-lint.yml
- .github/workflows/reject-imperative-skills.yml
- .github/workflows/onex-schema-compat.yml
- .github/workflows/imperative-contract-guard.yml
- .github/workflows/url-authority-gate.yml
- .github/workflows/skill-receipt-mode-gate.yml
- .github/workflows/hostile-reviewer.yml
- .github/workflows/contract-validation.yml
- .github/workflows/check-handshake.yml
- .github/workflows/plugin-compat-gate.yml
- .github/workflows/ban-hardcoded-runner-ip.yml
- .github/workflows/non-dev-base-guard.yml
- .github/workflows/stale-todo-gate.yml
- .github/workflows/pr-title-check.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gate omniclaude CI fanout behind OCC preflight so OCC eligibility fails before runner-heavy validation starts.
Changes
occ-preflightas the first CI dependency.always()aggregators so they do not run after OCC failure.Test plan
actionlint -shellcheck= .github/workflows/ci.ymlruby -ryaml -e YAML.load_file(ARGV[0]) .github/workflows/ci.ymlgit diff --checkType safety checklist
metadata["key"]ormetadata.get("key")string literal access on Pydantic model fieldsmetadata: dict[str, Any]fields without TypedDict or# ONEX_EXCLUDE:commentexcept Exception— must use narrowed type, or minimal-scope boundary withlogger.exception(...)+ degrade comment, or typed wrap/re-raiseRelated issues
OMN-14104
Evidence-Source: OCC#3674
Evidence-Ticket: OMN-14104
Summary by CodeRabbit
New Features
Bug Fixes