Skip to content

chore(OMN-14077): drop onex_change_control from queue-repo automation lists - #1862

Merged
jonahgabriel merged 3 commits into
devfrom
jonah/omn-14077-occ-nonqueue-automation
Jul 9, 2026
Merged

jonahgabriel merged 3 commits into
devfrom
jonah/omn-14077-occ-nonqueue-automation

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented Jul 6, 2026 •

Copy link
Copy Markdown
Contributor

What

Drop onex_change_control from the merge-queue automation repo lists (OMN-14077). Its merge queue (ruleset 16846914) was disabled on 2026-07-06 to relieve the deepest CI jam; OCC is now non-queue and merges via the direct squash path.

Changes

  • plugins/onex/skills/_bin/_lib/armed_not_enqueued.py — remove OmniNode-ai/onex_change_control from QUEUE_REPOS. Otherwise every armed OCC PR is false-flagged as "armed but not enqueued" (there is no queue to enqueue into). Docstring example updated to match.
  • scripts/cron-merge-sweep.sh — remove onex_change_control from the ONEX_QUEUE_REPOS queue-heal default; the method-mismatch heal does not apply to a non-queue repo.
  • tests/unit/skills/bin/test_armed_not_enqueued.py — update the QUEUE_REPOS coverage assertion to the 6-repo set + assert OCC absent.

The enqueue path already degrades gracefully on a missing queue (merge_queue_enqueue.py::is_no_merge_queue_error), so nothing hard-breaks in the interim; this change removes the wasted probes and the armed-not-enqueued false-flags.

Verification (local)

  • uv run pytest tests/unit/skills/bin/test_armed_not_enqueued.py → 33 passed.
  • uv run ruff check + ruff format --check clean on changed files.
  • bash -n scripts/cron-merge-sweep.sh → OK.
  • pre-commit (staged) green.

Ref: OMN-14077 (under OMN-13979 / Lever 1b of docs/plans/2026-07-06-ci-streamlining-logjam-reduction-plan.md).

Evidence-Source: OCC#3663
Evidence-Ticket: OMN-14077

@coderabbitai

coderabbitai Bot commented Jul 7, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 32 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4fc70758-4e5a-436c-8361-7713b09e673a

📥 Commits

Reviewing files that changed from the base of the PR and between 3967e18 and 70b8236.

📒 Files selected for processing (4)
  • plugins/onex/skills/_bin/_lib/armed_not_enqueued.py
  • plugins/onex/skills/_bin/armed-not-enqueued.sh
  • scripts/cron-merge-sweep.sh
  • tests/unit/skills/bin/test_armed_not_enqueued.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-14077-occ-nonqueue-automation

Comment @coderabbitai help to get the list of available commands.

@jonahgabriel
jonahgabriel enabled auto-merge July 7, 2026 00:26
@github-actions

github-actions Bot commented Jul 7, 2026 •

Copy link
Copy Markdown
Contributor

⚠️ Hostile Reviewer — DEGRADED (informational)

Blocking findings (critical/error): 0
Total findings: 0
Models succeeded: none

Note: All reviewer models failed or were unavailable. Degraded results are informational during the pilot phase (OMN-8524) and do not block merge. Error: cli_review exited non-zero (all models failed or binary error)


Gate semantics (pilot phase)

Verdict Meaning Blocks merge?
passed No critical/error findings No
blocked CRITICAL or ERROR findings found Yes
degraded All models unavailable (infra) No (pilot)

Powered by omniintelligence.review_pairing.cli_review — node-based adversarial review via HandlerLlmCliSubprocess (OMN-8524)

@jonahgabriel
jonahgabriel disabled auto-merge July 8, 2026 17:01
… lists

OCC merge queue (ruleset 16846914) was disabled 2026-07-06 to relieve the
deepest CI jam (OCC was 13-14 entries deep, evidence-companion PRs only).
onex_change_control is now non-queue; remove it from:

- armed_not_enqueued.py QUEUE_REPOS — otherwise every armed OCC PR is
  false-flagged as 'armed but not enqueued' (no queue to enqueue into).
- cron-merge-sweep.sh ONEX_QUEUE_REPOS queue-heal default — the
  method-mismatch heal does not apply to a non-queue repo.

Update the QUEUE_REPOS coverage test to the 6-repo set. OCC PRs now merge via
the direct squash path (gh pr merge --squash --auto).
@jonahgabriel
jonahgabriel force-pushed the jonah/omn-14077-occ-nonqueue-automation branch from dafc9a7 to 70b8236 Compare July 9, 2026 13:06
@jonahgabriel
jonahgabriel merged commit 5de4a87 into dev Jul 9, 2026
236 of 251 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-14077-occ-nonqueue-automation branch July 9, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant