[jonahgabriel]

Summary

• Updates scripts/cron-contract-verify.sh so the cron tick invokes /onex:contract_sweep --mode runtime --full-runtime-verification instead of runtime mode without the full verification flag.
• Adds a shell regression test that builds a temporary canonical clone, runs the cron wrapper in dry-run mode, and proves the full-runtime prompt is emitted without executing claude.

Verification

• bash scripts/tests/test-cron-contract-verify.sh -> 3 passed, 0 failed.
• Push preflight hooks passed for jonah/omn-9071-full-runtime-cron: mypy, pyright, ONEX validation, clean root directory, duplicate model filename check, Pydantic pattern validation, single class per file, enum governance, __all__ exports, and DoD evidence advisory.

OCC Evidence

• Central OCC evidence files are intentionally not included in this product PR. They will be added separately in onex_change_control.

Summary by CodeRabbit

• Chores
  • Enhanced contract verification process to utilize comprehensive runtime verification capabilities, replacing the previous narrower verification mode
  • Added automated regression tests for contract verification workflows to validate correct behavior during dry-run execution scenarios

Evidence-Ticket: OMN-9071
Evidence-Source: OCC#1206

[coderabbitai]

📝 Walkthrough

Walkthrough

Updated scripts/cron-contract-verify.sh to use --full-runtime-verification flag for runtime contract sweep delegation. Added scripts/tests/test-cron-contract-verify.sh as a regression test that validates dry-run behavior using isolated Git clones and mocked claude binary.

Changes

Contract verification script update and test

Layer / File(s)	Summary
Script update to full runtime verification scripts/cron-contract-verify.sh	Comment documentation and PROMPT configuration now specify --full-runtime-verification flag for the /onex:contract_sweep delegation.
Regression test for dry-run behavior scripts/tests/test-cron-contract-verify.sh	New test script with assertion helpers, cleanup and setup functions (canonical clone initialization and mocked claude binary), and main test case that validates dry-run output includes expected full runtime verification flags and excludes registration-only messaging and allowed-tools invocation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A script now sweeps with vigor bright,
Full runtime checks to set things right,
A test ensures no stone's unturned,
So contracts flow as they have earned! 🌙

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 14.29% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: enabling full runtime verification for cron contract verification, which aligns with the core objective of updating the cron script to use --full-runtime-verification flag.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch jonah/omn-9071-full-runtime-cron

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

⚠️ Hostile Reviewer — DEGRADED (informational)

Blocking findings (critical/error): 0
Total findings: 0
Models succeeded: none

Note: All reviewer models failed or were unavailable. Degraded results are informational during the pilot phase (OMN-8524) and do not block merge. Error: cli_review exited non-zero (all models failed or binary error)

---

Gate semantics (pilot phase)

Verdict	Meaning	Blocks merge?
passed	No critical/error findings	No
blocked	CRITICAL or ERROR findings found	Yes
degraded	All models unavailable (infra)	No (pilot)

Powered by omniintelligence.review_pairing.cli_review — node-based adversarial review via HandlerLlmCliSubprocess (OMN-8524)

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@scripts/tests/test-cron-contract-verify.sh`:
- Around line 79-87: The push command currently pushes the local branch named
"main" (git -C "${clone}" push -u origin main -q ...) which can fail if the
checked-out branch is "master"; update the push to push the current HEAD to the
remote main ref (use git -C "${clone}" push -u origin HEAD:main ...) so the
current branch (HEAD) is deterministically published as remote ref "main" and
avoids CI flakiness.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fe1dee9d-9ec4-4d05-b915-a6d5ebdd7b2f

📥 Commits

Reviewing files that changed from the base of the PR and between 3e4ed0c and 3b1c376.

📒 Files selected for processing (2)

• scripts/cron-contract-verify.sh
• scripts/tests/test-cron-contract-verify.sh