test(registration): tighten warning assertion in test_unexpected_error_logged_as_warning (OMN-3574)

[jonahgabriel]

Summary

• Replace bare assert warning_msgs with keyword-specific assertions in test_unexpected_error_logged_as_warning — now verifies the WARNING log actually references "schema" or "initialize", rejecting spurious warnings from unrelated code paths
• Apply the same tightening to test_advisory_lock_failure_logged_as_warning which had the identical under-constrained pattern

Mutation test verification

Deleting the else: logger.warning(...) branch in _initialize_schema now causes test_unexpected_error_logged_as_warning to FAIL (confirmed manually during development).

Test plan

• All 14 tests in test_plugin_schema_init.py pass
• Mutation test: removing the logger.warning() branch causes test_unexpected_error_logged_as_warning to fail
• ruff check passes on changed file
• No implementation changes — test-only

Closes OMN-3574

Summary by CodeRabbit

• Tests
  • Enhanced validation for schema initialization warnings in test suite to ensure messages properly reference schema-related processes.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cb426101-860f-4ed0-a296-9f76269a516b

📥 Commits

Reviewing files that changed from the base of the PR and between 74536e0 and aab06a8.

📒 Files selected for processing (1)

• tests/unit/nodes/node_registration_orchestrator/test_plugin_schema_init.py

---

📝 Walkthrough

Walkthrough

Test validation tightening in plugin schema initialization tests. Warning assertions now require logged messages to explicitly contain "schema" or "initialize" rather than accepting any warning, ensuring validation specificity across two test cases.

Changes

Cohort / File(s)	Summary
Test Warning Validation tests/unit/nodes/node_registration_orchestrator/test_plugin_schema_init.py	Tightened warning message validation in two tests to require explicit references to schema initialization ("schema" or "initialize" keywords) instead of accepting generic warnings.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 The warnings now must speak their truth,
No generic logs allowed, forsooth!
"Schema" and "initialize" ring clear,
Validation tightened, crisp and dear. 🔍✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: tightening warning assertions in a specific test function related to registration schema initialization.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch jonah/omn-3574-tighten-warning-assertion

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}