Repository navigation
ci(OMN-18205): re-pin merge-hold gate to the seam-routed reusable - #3616
Conversation
Re-pins this repo's merge-hold-gate job to omnimarket#2575's dev squash commit, whose evaluate job routes through the trusted-CI seam instead of an unconditional GitHub-hosted runner. Evidence-Ticket: OMN-18205
|
OCC autobind did not mint a companion for this PR: no changed-file candidate could be proven RED against the merge base, and emitting a PR-existence probe instead would be non-falsifiable evidence (OMN-15247). Hand-authored evidence is required. |
|
No OCC evidence companion was minted for this PR. this PR is already bound to OCC#9779; its evidence companion exists and nothing needs authoring To clear this: Nothing to do — the companion already exists. Reported by |
Hand-authored (autobind declined: no changed-file candidate provable RED against the merge base for a two-line CI re-pin). Adds the dod_evidence entry and its PASS receipt binding OMN-18205 to omnibase_infra#3616. Evidence-Ticket: OMN-18205
…guardrail (#9779) * ci(OMN-18205): re-pin merge-hold gate to the seam-routed reusable Re-pins this repo's merge-hold-gate job to omnimarket#2575's dev squash commit, whose evaluate job routes through the trusted-CI seam instead of an unconditional GitHub-hosted runner. Evidence-Ticket: OMN-18205 * ci(OMN-18205): cite the ticket in the workflow change for the App-PR guardrail check-app-pr-branch-allowed (OMN-18327) requires a workflow-file change to cite its dispatching ticket in an added line before this branch may be opened as a PR by the onexbot-occ-writer App. Evidence-Ticket: OMN-18205 * evidence(OMN-18205): OCC self-bind for #9779 Structural binding receipt only (OMN-18075): not declared in dod_evidence, no binds_ac, no contract_entry_sha256. Evidence-Ticket: OMN-18205 * evidence(OMN-18205): OCC companion for OmniNode-ai/omnibase_infra#3616 Hand-authored (autobind declined: no changed-file candidate provable RED against the merge base for a two-line CI re-pin). Adds the dod_evidence entry and its PASS receipt binding OMN-18205 to omnibase_infra#3616. Evidence-Ticket: OMN-18205 * evidence(OMN-18205): fix self-bind receipt whole-file hash after appending PR #3616's entry The pr-9779 self-bind receipt pinned the whole-file contract hash from before this branch appended the dod-OmniNode-ai-omnibase_infra-pr-3616 entry; update it to the current pinned hash. Evidence-Ticket: OMN-18205 --------- Co-authored-by: jonahgabriel <jonah@omninode.ai>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hostile Reviewer — adversarial findings (OMN-17492)
Models succeeded: glm-review
Models failed: codex
New finding threads: 2
Deduped (already posted on this PR): 0
Nit-level findings suppressed: 1
The model is the FINDER, never the gate: merge is gated only by the
deterministic Hostile Review Thread Gate, which blocks while
hostile-reviewer threads are unresolved. Resolve each thread after
addressing (or rejecting, with a reply) its finding.
|
| Surface | Meaning | Blocks merge? |
|---|---|---|
| Review threads | Per-finding, posted by the reviewer | No (informational) |
Hostile Review Thread Gate |
Deterministic: unresolved hostile-reviewer threads exist | Fails until resolved (not yet a required context) |
degraded verdict |
Fewer than 2 models succeeded (infra) | No |
Powered by omniintelligence.review_pairing.cli_review — multi-model adversarial review: qwen3-review, qwen3-review-b, glm-review (OMN-8468/OMN-8524/OMN-17492)
There was a problem hiding this comment.
Hostile Reviewer — adversarial findings (OMN-17492)
Models succeeded: glm-review
Models failed: codex
New finding threads: 4
Deduped (already posted on this PR): 0
Nit-level findings suppressed: 1
The model is the FINDER, never the gate: merge is gated only by the
deterministic Hostile Review Thread Gate, which blocks while
hostile-reviewer threads are unresolved. Resolve each thread after
addressing (or rejecting, with a reply) its finding.
There was a problem hiding this comment.
Hostile Reviewer — adversarial findings (OMN-17492)
Models succeeded: glm-review
Models failed: codex
New finding threads: 0
Deduped (already posted on this PR): 0
Nit-level findings suppressed: 1
The model is the FINDER, never the gate: merge is gated only by the
deterministic Hostile Review Thread Gate, which blocks while
hostile-reviewer threads are unresolved. Resolve each thread after
addressing (or rejecting, with a reply) its finding.
Findings not anchored to a changed file
-
[MAJOR] hostile-reviewer (glm-review)
Comment asserts CI gate guarantees that the diff itself cannot verify | The new comment claims the pinned reusable workflow 'verifies each pin is reachable from the protected branch instead of merely fetchable.' However, the gate being invoked is the very artifact being repinned; a malicious or compromised commit at ff6e41c could omit that reachability check while the comment still advertises it as enforced. Self-referential trust in the pinned workflow is presented as a control without an out-of-band verif
Resolve this thread when addressed — the
Hostile Review Thread Gateblocks while hostile-reviewer threads are unresolved (OMN-17492). -
[MINOR] hostile-reviewer (glm-review)
Commit date 2026-09-16 appears inconsistent with a 27478af-era repin narrative | The comment states the pin was 'committed 2026-09-16T03:01:49Z' while the surrounding history describes unmergeable PRs 'based on 27478af or later.' If the tooling date is accurate, the timestamp should be cross-checked; if it is a typo (e.g., 2025), embedding a wrong timestamp in an audit-oriented comment degrades the traceability the OMN-18205 review is meant to provide. | Evidence: ff6e41c is omnimarket#2575's squash merge
Resolve this thread when addressed — the
Hostile Review Thread Gateblocks while hostile-reviewer threads are unresolved (OMN-17492). -
[MINOR] hostile-reviewer (glm-review)
Enforced equality of workflow pin and vocabulary_ref creates hidden coupling | The comment states a wiring test enforces that the workflow pin and vocabulary_ref remain identical. This couples two semantically distinct dependencies (executable gate logic vs. vocabulary data) and forces atomic repins of both, increasing blast radius of future updates and making it impossible to bump one independently if they diverge upstream. | Evidence: The merge-hold wiring test below also enforces that the workflow pin an
Resolve this thread when addressed — the
Hostile Review Thread Gateblocks while hostile-reviewer threads are unresolved (OMN-17492).
) * ci(OMN-18205): re-pin merge-hold gate to the seam-routed reusable Re-pins this repo's merge-hold-gate job to omnimarket#2575's dev squash commit, whose evaluate job routes through the trusted-CI seam instead of an unconditional GitHub-hosted runner. Evidence-Ticket: OMN-18205 * ci(OMN-18205): document merge-hold pin provenance * ci(OMN-18205): rely on pin reachability gate
Re-pins this repo's merge-hold-gate job to omnimarket#2575's dev squash commit, whose evaluate job routes through the runner seam.
Evidence-Ticket: OMN-18205
Evidence-Source: OCC#9779