Skip to content

fix(event-bus): retain capped topic creation spec (OMN-15978) - #2732

Merged
jonahgabriel merged 1 commit into
devfrom
jonah/omn-15978-topic-cap-readiness
Aug 13, 2026
Merged

jonahgabriel merged 1 commit into
devfrom
jonah/omn-15978-topic-cap-readiness

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented Aug 13, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • retain the exact partition-capped spec submitted to Kafka during topic creation
  • make same-process readiness compare broker metadata with that effective spec
  • add a cold-start regression for a six-partition contract capped to one in dev

Ticket: OMN-15978

Live finding

The onex-dev effects runtime created gateway topics with the dev cap of one partition but cached the uncapped six-partition contract spec. Its readiness loop therefore could not converge until a restart treated the topics as pre-existing.

Verification

  • uv run pytest tests/unit/event_bus/test_topic_provisioner_rf_policy_omn15395.py -q — 61 passed
  • pre-commit on both changed files — passed
  • guarded pre-push impacted suite — 9,064 passed, 30 skipped
  • full all-files pre-commit additionally exposed unrelated baseline failures in untouched orchestrator/SPDX files; no such files are included here

Evidence-Source: OCC#6425
Evidence-Ticket: OMN-15978

  • Hosted gate refresh after OCC merge: 2026-08-13T12:15Z
  • Runner-recovery CI refresh: 2026-08-13T15:53Z

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 56 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f1691581-c95f-42d2-8fc1-adc06b6a7566

📥 Commits

Reviewing files that changed from the base of the PR and between a6d52de and 59241b9.

📒 Files selected for processing (2)
  • src/omnibase_infra/event_bus/service_topic_manager.py
  • tests/unit/event_bus/test_topic_provisioner_rf_policy_omn15395.py

Comment @coderabbitai help to get the list of available commands.

@jonahgabriel jonahgabriel added the ci:ready Full CI runs on this PR (OMN-15731 label-gated CI pilot) label Aug 13, 2026
@jonahgabriel
jonahgabriel enabled auto-merge (squash) August 13, 2026 10:51
@jonahgabriel jonahgabriel changed the title fix(event-bus): retain capped topic creation spec fix(event-bus): retain capped topic creation spec (OMN-15978) Aug 13, 2026
@github-actions

github-actions Bot commented Aug 13, 2026 •

Copy link
Copy Markdown
Contributor

❓ Hostile Reviewer — UNKNOWN

Blocking findings (critical): 0
Total findings: 0
Models succeeded: none


Gate semantics (pilot phase)

Verdict Meaning Blocks merge?
passed No critical findings No
blocked CRITICAL findings found Yes
degraded All models unavailable (infra) No (pilot)

Powered by omniintelligence.review_pairing.cli_review — node-based adversarial review via HandlerLlmCliSubprocess (OMN-8468/OMN-8524)

@jonahgabriel jonahgabriel added ci:ready Full CI runs on this PR (OMN-15731 label-gated CI pilot) and removed ci:ready Full CI runs on this PR (OMN-15731 label-gated CI pilot) labels Aug 13, 2026
@jonahgabriel
jonahgabriel merged commit c65eb55 into dev Aug 13, 2026
537 of 652 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-15978-topic-cap-readiness branch August 13, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:ready Full CI runs on this PR (OMN-15731 label-gated CI pilot)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant