Repository navigation
fix(OMN-15978): bind gateway operations to command topics - #2729
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe gateway attach effect contract now maps attach, heartbeat, and detach operations to command topics. Regression tests verify unique topic ownership. The dispatch parity baseline updates the related identifiers, selections, route records, route count, and timestamp. ChangesGateway routing
Estimated code review effort: 2 (Simple) | ~10 minutes Mergeability Score: ⚪ Minimal · up to The routing contract and regression fixture are aligned, and no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
fd0060f to
af23742
Compare
…ibase_infra#2729 (#6412) * evidence(OMN-15978): author OCC companion for OmniNode-ai/omnibase_infra#2729 OCC companion by node_pr_lifecycle_fix_effect (OMN-13317 F1 / OMN-13990 / OMN-14285). Product PR head af2374233b1d3a3ce9068ff6bd74e624e2facf8a. * evidence(OMN-15978): self-bind OCC#6412 + rebind contract_sha256 --------- Co-authored-by: omnimarket-bot <bot@omninode.ai>
✅ Hostile Reviewer — PASSEDBlocking findings (critical): 0 Gate semantics (pilot phase)
Powered by omniintelligence.review_pairing.cli_review — node-based adversarial review via HandlerLlmCliSubprocess (OMN-8468/OMN-8524) |
Summary
operation_matchgateway handler to its single command topic in the node contractDefect
With
event_model: nulland no handler-leveltopic, the runtime's_topics_for_handler_entryreturns every declared subscribe topic for every handler. Attach, heartbeat, and detach dispatchers therefore all subscribe to all three request topics, allowing a healthy consumer group to invoke the wrong typed request handler.Verification
git diff --check, mypy, architecture validation, and deploy-scope hook: passedDependency
OMN-15918 / omnibase_infra#2727 is merged. This branch is rebased directly onto that merge and targets
dev. Do not deploy a runtime-effects image until this change also lands and its OCC evidence is merged.Summary by CodeRabbit
Bug Fixes
Tests
Evidence-Ticket: OMN-15978
Evidence-Source: OCC#6413