Repository navigation
fix(OMN-14974): create TLS context for managed Kafka - #2487
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 58 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Land OCC evidence companion for OMN-14974 / omnibase_infra#2487.
|
| Verdict | Meaning | Blocks merge? |
|---|---|---|
passed |
No critical findings | No |
blocked |
CRITICAL findings found | Yes |
degraded |
All models unavailable (infra) | No (pilot) |
Powered by omniintelligence.review_pairing.cli_review — node-based adversarial review via HandlerLlmCliSubprocess (OMN-8468/OMN-8524)
Summary
ssl.SSLContextfor bothSSLandSASL_SSL, even when the system trust store is usedWhy
The exact candidate runtime reached both staging MSK brokers but all three new pods exited before SASL/IAM authentication.
aiokafkarejects an SSL transport without an explicitssl_context; the shared auth helper only created one whenKAFKA_SSL_CA_FILEwas set. The staging configuration correctly usesSASL_SSL+AWS_MSK_IAM+ the system trust store, so the helper must construct the default context.Verification
test_msk_iam_builds_default_aiokafka_ssl_contextfailed withKeyError: ssl_contextLive evidence and rollout
SASL_SSL,AWS_MSK_IAMValueError: ssl_context is mandatoryTicket: OMN-14974
Evidence-Ticket: OMN-14974
Evidence-Source: OCC#5063
Evidence-Commit: 36b8166796fc6c96700fd3ee52fb05c4516c4415
Evidence-Source: OCC#5063
Evidence-Commit: 36b8166796fc6c96700fd3ee52fb05c4516c4415
Evidence-Head: 40ceacf