Repository navigation
fix(OMN-13995): register dep_cascade_dedup skill so it resolves instead of Unknown node - #2215
Conversation
…ad of Unknown node `onex skill dep_cascade_dedup` hard-failed from the canonical infra venv with "Unknown skill" even though the backing node node_dep_cascade_dedup_orchestrator is registered in the omnimarket onex.nodes catalog and both request + result models exist. The only gap was a missing skill_mapping.yaml row, so the post-release dep-bump dedup sweep was unrunnable headless. Same regression class as OMN-13511 / OMN-13712 (node exists, skill unmapped). Additive mapping row only (mirrors merge_sweep shape); args mirror ModelDepCascadeDedupRequest (repos/dependency-type/label/close-comment/dry-run). Tests: - dep_cascade_dedup registered + wired to node + typed result model - payload validates against ModelDepCascadeDedupRequest (repos = the sweep's roots/repos it scans); dry-run boolean default wiring - registered in the node-backed dogfood catalog-resolution gate - CLAUDE.md rule #8 fail-fast guard: the sweep-repo-fallback _resolve_root in BOTH node_integration_sweep_orchestrator and node_dod_sweep_orchestrator raises RuntimeError when the repo-registry env is unset and no explicit root is supplied — never a silent default. Closes OMN-13995
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 57 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
onex skill dep_cascade_deduphard-failed today from the canonical infra venv:The backing node
node_dep_cascade_dedup_orchestratoris registered in the omnimarketonex.nodescatalog and bothModelDepCascadeDedupRequestandModelDepCascadeDedupResultexist — the only gap was a missingskill_mapping.yamlrow, so the post-release dep-bump dedup sweep was unrunnable headless. This is the same regression class as OMN-13511 / OMN-13712 (node exists, skill unmapped).Change (surgical, additive)
src/omnibase_infra/cli/skill_mapping.yaml(mirrors themerge_sweepentry shape). Args mirrorModelDepCascadeDedupRequest:repos(string_list),dependency-type,label,close-comment,dry-run(default false). No org-wide defaults flipped, no other skill touched.dod_evidence
Reproduction of the pre-fix failure, and post-fix proof (verifier != runner — proven locally against the omnimarket-installed venv):
onex skill dep_cascade_dedup→Error: Unknown skill 'dep_cascade_dedup'.dep_cascade_dedup→node_dep_cascade_dedup_orchestrator, result_model...model_dep_cascade_dedup_result.ModelDepCascadeDedupResult;_parse_skill_args(--repos omnibase_core,omnibase_infra --dry-run)builds a payload that validates againstModelDepCascadeDedupRequest(repos=('omnibase_core','omnibase_infra'),dry_run=True).node_integration_sweep_orchestratorandnode_dod_sweep_orchestrator_resolve_root('')raiseRuntimeError("ONEX_CC_REPO_PATH is not set ...")when the repo-registry env is unset and no explicit root is supplied — never a silent default.test_cli_skill.pysuite: 31 passed / 14 omnimarket-optional skips (importorskip, CI parity).ruff checkclean;pre-commit run --filesall hooks Passed/Skipped (none failed); added test lines are mypy-clean (the 2 pre-existingunused-ignorein the local no-omnimarket env are untouchedruntime_sweeplines that resolve in CI).Epic: OMN-13976 (WS-M dogfood/adoption rail).
Closes OMN-13995
Evidence-Source: OCC#3633
Evidence-Ticket: OMN-13995