Skip to content

fix(OMN-13995): register dep_cascade_dedup skill so it resolves instead of Unknown node - #2215

Merged
jonahgabriel merged 1 commit into
devfrom
jonah/omn-13995-register-dep-cascade-dedup-skill
Jul 7, 2026
Merged

jonahgabriel merged 1 commit into
devfrom
jonah/omn-13995-register-dep-cascade-dedup-skill

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented Jul 5, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

onex skill dep_cascade_dedup hard-failed today from the canonical infra venv:

Error: Unknown skill 'dep_cascade_dedup'. Known skills: agent_healthcheck, aislop_sweep, ...

The backing node node_dep_cascade_dedup_orchestrator is registered in the omnimarket onex.nodes catalog and both ModelDepCascadeDedupRequest and ModelDepCascadeDedupResult exist — the only gap was a missing skill_mapping.yaml row, so the post-release dep-bump dedup sweep was unrunnable headless. This is the same regression class as OMN-13511 / OMN-13712 (node exists, skill unmapped).

Change (surgical, additive)

  • One declarative row added to src/omnibase_infra/cli/skill_mapping.yaml (mirrors the merge_sweep entry shape). Args mirror ModelDepCascadeDedupRequest: repos (string_list), dependency-type, label, close-comment, dry-run (default false). No org-wide defaults flipped, no other skill touched.

dod_evidence

Reproduction of the pre-fix failure, and post-fix proof (verifier != runner — proven locally against the omnimarket-installed venv):

  • Pre-fix: onex skill dep_cascade_dedup → Error: Unknown skill 'dep_cascade_dedup'.
  • Post-fix resolution: registry resolves dep_cascade_dedup → node_dep_cascade_dedup_orchestrator, result_model ...model_dep_cascade_dedup_result.ModelDepCascadeDedupResult; _parse_skill_args(--repos omnibase_core,omnibase_infra --dry-run) builds a payload that validates against ModelDepCascadeDedupRequest (repos=('omnibase_core','omnibase_infra'), dry_run=True).
  • Fail-fast preserved (CLAUDE.md rule feat: migrate 96 models to domain-organized structure #8): verified both node_integration_sweep_orchestrator and node_dod_sweep_orchestrator _resolve_root('') raise RuntimeError("ONEX_CC_REPO_PATH is not set ...") when the repo-registry env is unset and no explicit root is supplied — never a silent default.
  • Tests: 6 targeted tests pass with omnimarket present (registered+wired, payload validates, dry-run default, node-backed catalog gate incl. dep_cascade, both sweep-repo-fallback fail-fast cases). Full focused test_cli_skill.py suite: 31 passed / 14 omnimarket-optional skips (importorskip, CI parity).
  • Gates: ruff check clean; pre-commit run --files all hooks Passed/Skipped (none failed); added test lines are mypy-clean (the 2 pre-existing unused-ignore in the local no-omnimarket env are untouched runtime_sweep lines that resolve in CI).

Epic: OMN-13976 (WS-M dogfood/adoption rail).

Closes OMN-13995


Evidence-Source: OCC#3633
Evidence-Ticket: OMN-13995

…ad of Unknown node

`onex skill dep_cascade_dedup` hard-failed from the canonical infra venv with
"Unknown skill" even though the backing node node_dep_cascade_dedup_orchestrator
is registered in the omnimarket onex.nodes catalog and both request + result
models exist. The only gap was a missing skill_mapping.yaml row, so the
post-release dep-bump dedup sweep was unrunnable headless. Same regression
class as OMN-13511 / OMN-13712 (node exists, skill unmapped).

Additive mapping row only (mirrors merge_sweep shape); args mirror
ModelDepCascadeDedupRequest (repos/dependency-type/label/close-comment/dry-run).

Tests:
- dep_cascade_dedup registered + wired to node + typed result model
- payload validates against ModelDepCascadeDedupRequest (repos = the sweep's
  roots/repos it scans); dry-run boolean default wiring
- registered in the node-backed dogfood catalog-resolution gate
- CLAUDE.md rule #8 fail-fast guard: the sweep-repo-fallback _resolve_root in
  BOTH node_integration_sweep_orchestrator and node_dod_sweep_orchestrator
  raises RuntimeError when the repo-registry env is unset and no explicit root
  is supplied — never a silent default.

Closes OMN-13995
@coderabbitai

coderabbitai Bot commented Jul 5, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 57 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 24643ca4-cec4-4ed4-b172-3a842841543c

📥 Commits

Reviewing files that changed from the base of the PR and between 005b961 and 023b932.

📒 Files selected for processing (2)
  • src/omnibase_infra/cli/skill_mapping.yaml
  • tests/unit/cli/test_cli_skill.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-13995-register-dep-cascade-dedup-skill

Comment @coderabbitai help to get the list of available commands.

@jonahgabriel
jonahgabriel enabled auto-merge July 5, 2026 21:16
@jonahgabriel
jonahgabriel added this pull request to the merge queue Jul 6, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 6, 2026
@jonahgabriel
jonahgabriel added this pull request to the merge queue Jul 6, 2026
@jonahgabriel
jonahgabriel removed this pull request from the merge queue due to a manual request Jul 6, 2026
@jonahgabriel
jonahgabriel added this pull request to the merge queue Jul 6, 2026
@jonahgabriel
jonahgabriel removed this pull request from the merge queue due to a manual request Jul 6, 2026
@jonahgabriel
jonahgabriel added this pull request to the merge queue Jul 6, 2026
@jonahgabriel
jonahgabriel removed this pull request from the merge queue due to a manual request Jul 6, 2026
@jonahgabriel
jonahgabriel added this pull request to the merge queue Jul 6, 2026
@jonahgabriel
jonahgabriel removed this pull request from the merge queue due to a manual request Jul 6, 2026
@jonahgabriel
jonahgabriel added this pull request to the merge queue Jul 6, 2026
@jonahgabriel
jonahgabriel removed this pull request from the merge queue due to a manual request Jul 6, 2026
@jonahgabriel
jonahgabriel added this pull request to the merge queue Jul 6, 2026
@jonahgabriel
jonahgabriel removed this pull request from the merge queue due to a manual request Jul 6, 2026
@jonahgabriel
jonahgabriel added this pull request to the merge queue Jul 6, 2026
@jonahgabriel
jonahgabriel removed this pull request from the merge queue due to a manual request Jul 6, 2026
@jonahgabriel
jonahgabriel added this pull request to the merge queue Jul 6, 2026
@jonahgabriel
jonahgabriel removed this pull request from the merge queue due to a manual request Jul 6, 2026
@jonahgabriel
jonahgabriel added this pull request to the merge queue Jul 6, 2026
@jonahgabriel
jonahgabriel removed this pull request from the merge queue due to a manual request Jul 6, 2026
@jonahgabriel
jonahgabriel added this pull request to the merge queue Jul 6, 2026
@jonahgabriel
jonahgabriel removed this pull request from the merge queue due to a manual request Jul 6, 2026
@jonahgabriel
jonahgabriel added this pull request to the merge queue Jul 6, 2026
@jonahgabriel
jonahgabriel removed this pull request from the merge queue due to a manual request Jul 6, 2026
@jonahgabriel
jonahgabriel added this pull request to the merge queue Jul 6, 2026
@jonahgabriel
jonahgabriel removed this pull request from the merge queue due to a manual request Jul 6, 2026
@jonahgabriel
jonahgabriel added this pull request to the merge queue Jul 6, 2026
@jonahgabriel
jonahgabriel removed this pull request from the merge queue due to a manual request Jul 6, 2026
@jonahgabriel
jonahgabriel added this pull request to the merge queue Jul 6, 2026
@jonahgabriel
jonahgabriel removed this pull request from the merge queue due to a manual request Jul 6, 2026
@jonahgabriel
jonahgabriel added this pull request to the merge queue Jul 6, 2026
@jonahgabriel
jonahgabriel removed this pull request from the merge queue due to a manual request Jul 6, 2026
@jonahgabriel
jonahgabriel added this pull request to the merge queue Jul 6, 2026
@jonahgabriel
jonahgabriel removed this pull request from the merge queue due to a manual request Jul 6, 2026
@jonahgabriel
jonahgabriel added this pull request to the merge queue Jul 6, 2026
@jonahgabriel
jonahgabriel removed this pull request from the merge queue due to a manual request Jul 6, 2026
@jonahgabriel
jonahgabriel added this pull request to the merge queue Jul 6, 2026
@jonahgabriel
jonahgabriel removed this pull request from the merge queue due to a manual request Jul 6, 2026
@jonahgabriel
jonahgabriel added this pull request to the merge queue Jul 6, 2026
@jonahgabriel
jonahgabriel removed this pull request from the merge queue due to a manual request Jul 7, 2026
@jonahgabriel
jonahgabriel added this pull request to the merge queue Jul 7, 2026
@jonahgabriel
jonahgabriel removed this pull request from the merge queue due to a manual request Jul 7, 2026
@jonahgabriel
jonahgabriel added this pull request to the merge queue Jul 7, 2026
@jonahgabriel
jonahgabriel removed this pull request from the merge queue due to a manual request Jul 7, 2026
@jonahgabriel
jonahgabriel added this pull request to the merge queue Jul 7, 2026
@jonahgabriel
jonahgabriel removed this pull request from the merge queue due to a manual request Jul 7, 2026
@jonahgabriel
jonahgabriel added this pull request to the merge queue Jul 7, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 7, 2026
@jonahgabriel
jonahgabriel merged commit be5a18a into dev Jul 7, 2026
78 of 88 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-13995-register-dep-cascade-dedup-skill branch July 7, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant