Repository navigation
ci(OMN-13875): CI Summary directly gates Contract Compliance Check - #2188
Conversation
Contract Compliance Check (contract-compliance) was only an indirect dependency of the required CI Summary via detect-changes/test-parallel. When it fails, GitHub marks those dependents skipped; CI Tests Gate tolerates a skipped test-parallel (docs-only path), so a contract- compliance failure slipped through with CI Summary green. Wire contract-compliance directly into CI Summary needs + pass condition (success||skipped; it always runs on PR/merge_group so skipped never occurs in the queue). Evidence-Source: workflow-logic fix, no Python touched.
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 56 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
OMN-13875 — omnibase_infra finding #3
Problem
Contract Compliance Check(contract-compliance) was not a direct input to the requiredCI Summary. It only reached the aggregate viadetect-changes/test-parallel(both list it inneeds). When contract-compliance fails, GitHub marks those dependents skipped;CI Tests Gatetoleratestest-parallel == skipped(the legitimate docs-only path), andCI Summarynever referenced contract-compliance — so a contract-compliance failure slipped through with CI Summary green. Same class as OMN-13873.Fix
Add
contract-compliancedirectly toci-summary.needsand to its pass condition assuccess || skipped, plus report it in both summary branches.Wedge-safety
contract-compliance's jobif:ispull_request || merge_group || pushand it carries no path/zone filter, so on every gating event (incl. docs-only PRs) it runs and is neverskipped. The skipped tolerance only covers non-gating events (workflow_dispatch), so no failure slips via skipped and no docs-only PR is wedged.CI Summaryis the required context (verified via branch protection).Verification
Workflow-YAML-only change (no Python touched). Validated via
yaml.safe_load(OK) + targetedpre-commit run --files .github/workflows/ci.yml(applicable hooks Passed) + the live CI run on this PR.Evidence-Source: OCC#3523
Evidence-Ticket: OMN-13875