Skip to content

ci(OMN-13875): CI Summary directly gates Contract Compliance Check - #2188

Merged
jonahgabriel merged 1 commit into
devfrom
jonah/omn-13875-infra-ci-summary-contract-compliance
Jul 3, 2026
Merged

jonahgabriel merged 1 commit into
devfrom
jonah/omn-13875-infra-ci-summary-contract-compliance

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented Jul 3, 2026 •

Copy link
Copy Markdown
Collaborator

OMN-13875 — omnibase_infra finding #3

Problem

Contract Compliance Check (contract-compliance) was not a direct input to the required CI Summary. It only reached the aggregate via detect-changes/test-parallel (both list it in needs). When contract-compliance fails, GitHub marks those dependents skipped; CI Tests Gate tolerates test-parallel == skipped (the legitimate docs-only path), and CI Summary never referenced contract-compliance — so a contract-compliance failure slipped through with CI Summary green. Same class as OMN-13873.

Fix

Add contract-compliance directly to ci-summary.needs and to its pass condition as success || skipped, plus report it in both summary branches.

Wedge-safety

contract-compliance's job if: is pull_request || merge_group || push and it carries no path/zone filter, so on every gating event (incl. docs-only PRs) it runs and is never skipped. The skipped tolerance only covers non-gating events (workflow_dispatch), so no failure slips via skipped and no docs-only PR is wedged. CI Summary is the required context (verified via branch protection).

Verification

Workflow-YAML-only change (no Python touched). Validated via yaml.safe_load (OK) + targeted pre-commit run --files .github/workflows/ci.yml (applicable hooks Passed) + the live CI run on this PR.

Evidence-Source: OCC#3523
Evidence-Ticket: OMN-13875

Contract Compliance Check (contract-compliance) was only an indirect
dependency of the required CI Summary via detect-changes/test-parallel.
When it fails, GitHub marks those dependents skipped; CI Tests Gate
tolerates a skipped test-parallel (docs-only path), so a contract-
compliance failure slipped through with CI Summary green. Wire
contract-compliance directly into CI Summary needs + pass condition
(success||skipped; it always runs on PR/merge_group so skipped never
occurs in the queue).

Evidence-Source: workflow-logic fix, no Python touched.
@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 56 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3faed2d1-60bd-4e58-b5a9-8816c6ee07ab

📥 Commits

Reviewing files that changed from the base of the PR and between b0d9e5d and a905586.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-13875-infra-ci-summary-contract-compliance

Comment @coderabbitai help to get the list of available commands.

@jonahgabriel
jonahgabriel enabled auto-merge July 3, 2026 05:48
@jonahgabriel
jonahgabriel added this pull request to the merge queue Jul 3, 2026
Merged via the queue into dev with commit c253d73 Jul 3, 2026
75 of 79 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-13875-infra-ci-summary-contract-compliance branch July 3, 2026 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant