Skip to content

feat(OMN-13753): provision missing prod secrets — omnidash-tls Certificate + umami-credentials InfisicalSecret - #2158

Closed
jonahgabriel wants to merge 2 commits into
devfrom
jonah/omn-13753-prod-secrets
Closed

jonahgabriel wants to merge 2 commits into
devfrom
jonah/omn-13753-prod-secrets

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented Jun 29, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Fixes two missing onex-prod Kubernetes secrets that are causing live prod alerts:

  • traefik logs Error configuring TLS: secret onex-prod/omnidash-tls does not exist every ~5m → dash.omninode.ai TLS broken
  • umami pod stuck in Init:CreateContainerConfigError → secret "umami-credentials" not found → analytics down

Changes

deploy/k8s/onex-prod/omnidash/certificate.yaml — explicit cert-manager Certificate resource for omnidash-tls, targeting dash.omninode.ai via the letsencrypt-prod ClusterIssuer (HTTP-01). The omnidash Ingress already carries the cert-manager.io/cluster-issuer: letsencrypt-prod annotation which triggers automatic issuance, but an explicit Certificate gives operators a named object they can describe, force-renew, and alert on independently of the Ingress object.

deploy/k8s/onex-prod/umami/infisical-secret.yaml — InfisicalSecret CRD that syncs umami-credentials from Infisical path /prod/umami/ following the same pattern as omnidash-secret.yaml in omninode_infra. Includes Path B (imperative fallback) guidance for running setup-cluster-secrets.sh create_umami_credentials if Infisical is not yet seeded.

contracts/OMN-13753.yaml — OCC contract with dod_evidence.

drift/dod_receipts/OMN-13753/ — deploy gate + lint receipts.

No literal secrets committed

grep -rn 'CHANGEME' deploy/k8s/onex-prod/ → no matches

All secret references use secretKeyRef / credentialsRef pointing to named Kubernetes secrets — values resolve at the cluster boundary (Infisical operator or setup-cluster-secrets.sh).

Operator action required (OMN-13418 gate)

This PR delivers manifest declarations. Applying to the cluster requires a fresh operator approval:

# Certificate (omnidash-tls):
kubectl apply -f deploy/k8s/onex-prod/omnidash/certificate.yaml
kubectl describe certificate omnidash-tls -n onex-prod

# umami-credentials (Path A — Infisical must have /prod/umami/ populated):
kubectl apply -f deploy/k8s/onex-prod/umami/infisical-secret.yaml
kubectl get secret umami-credentials -n onex-prod

# umami-credentials (Path B — imperative, no Infisical dependency):
# From omninode_infra: NAMESPACE=onex-prod ./scripts/setup-cluster-secrets.sh

Evidence-Source

Evidence-Source: OCC#3356
Evidence-Ticket: OMN-13753

…icate + umami-credentials InfisicalSecret

Adds declarative manifests for the two missing onex-prod Kubernetes secrets
that are causing traefik TLS errors and the umami pod Init:CreateContainerConfigError.

Changes:
- deploy/k8s/onex-prod/omnidash/certificate.yaml: explicit cert-manager Certificate
  resource for omnidash-tls (dash.omninode.ai) via letsencrypt-prod ClusterIssuer.
  Explicit Certificate is operator-inspectable and force-renewable, vs relying
  solely on the implicit Ingress annotation path.
- deploy/k8s/onex-prod/umami/infisical-secret.yaml: InfisicalSecret CRD that syncs
  umami-credentials from Infisical /prod/umami/ following the omnidash pattern.
  Includes Path B guidance for imperative provisioning via setup-cluster-secrets.sh.
- contracts/OMN-13753.yaml: OCC contract with dod_evidence.
- drift/dod_receipts/OMN-13753/: deploy gate + lint receipts.

No literal secret values committed. Applying to the cluster = operator gate (OMN-13418).
@jonahgabriel
jonahgabriel enabled auto-merge June 29, 2026 14:57
@coderabbitai

coderabbitai Bot commented Jun 29, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 27 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4d3645c6-d45f-4fbf-a83c-2f0ca98816d5

📥 Commits

Reviewing files that changed from the base of the PR and between cb1dfba and 11fccde.

📒 Files selected for processing (5)
  • contracts/OMN-13753.yaml
  • deploy/k8s/onex-prod/omnidash/certificate.yaml
  • deploy/k8s/onex-prod/umami/infisical-secret.yaml
  • drift/dod_receipts/OMN-13753/dod-manifest-lint/command.yaml
  • drift/dod_receipts/OMN-13753/dod-no-pre-merge-deploy/command.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-13753-prod-secrets

Comment @coderabbitai help to get the list of available commands.

@jonahgabriel

Copy link
Copy Markdown
Collaborator Author

Closing in favor of OmniNode-ai/omninode_infra#531.

Why misplaced here: k8s manifests for onex-prod belong in omninode_infra, not omnibase_infra. omnibase_infra's CI gates (Arch Invariants, Contract Compliance, Kafka Boundary, Topic Drift) reject cert-manager Certificate and InfisicalSecret manifests as self-inflicted failures — there are no Python contracts or Kafka topics involved.

The canonical fix is in the correct repo at: https://github.com/OmniNode-ai/omninode_infra/pull/531

Closing this PR.

auto-merge was automatically disabled June 29, 2026 16:20

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant