Repository navigation
fix(OMN-13670): expand Trivy CVE floors to green clean-main runtime build (emergency prod recovery) - #2129
Closed
jonahgabriel wants to merge 1 commit into
Closed
fix(OMN-13670): expand Trivy CVE floors to green clean-main runtime build (emergency prod recovery)#2129jonahgabriel wants to merge 1 commit into
jonahgabriel wants to merge 1 commit into
Conversation
…37c-gmf6-5ccf) GHSA-537c-gmf6-5ccf (HIGH): cryptography wheels <48.0.1 bundle a vulnerable OpenSSL build. Fixed in 48.0.1. Trivy gate was blocking the ECR build with cryptography==46.0.7. Raises the floor from >=46.0.3 to >=48.0.1. uv lock resolves: cryptography 48.0.1. DoD evidence: grep -q 'cryptography>=48.0.1' pyproject.toml — passes.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Collaborator
Author
|
Superseded by #2131 (single-line cryptography floor). Closing as duplicate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
EMERGENCY PROD RECOVERY — OMN-13670 (operator-authorized) — follow-up to #2128.
PR #2128 (merged 2026-06-27) re-applied OMN-13654 dep floors + OMN-13666 entrypoint tolerance.
However the ECR build-and-push-runtime.yml still fails after #2128 because:
cryptography==46.0.7(the resolved version from the>=46.0.3floor) triggers GHSA-537c-gmf6-5ccf (HIGH): vulnerable OpenSSL bundled in cryptography wheels; fixed in 48.0.1.Trivy scanner log from run 28298553147 (post-#2128 push):
Changes
Cryptography CVE floor expansion
pyproject.tomlraises the cryptography floor from>=46.0.3to>=48.0.1:uv lockresolves:cryptography 48.0.1. Trivy gate passes 0 HIGH/CRITICAL at this version.DoD evidence (dod-crypto-floor):
grep -q 'cryptography>=48.0.1' pyproject.toml— passes.dod_evidence
Evidence-Ticket: OMN-13670
Evidence-Source: OCC#3233
Evidence-Class: hotfix
Active-Hotfix-PR: #2129
hotfix-evidence: OCC-3233
backmerge: #2128 (original floors)
Local gate results (2026-06-28):
uv run ruff format src/ tests/ && uv run ruff check --fix src/ tests/— 0 issuesuv run mypy src/ --strict— "Success: no issues found in 2442 source files"uv run pytest tests/unit/docker/ tests/unit/runtime/ -q— 4976 passed, 8 skipped, 0 failedpre-commit run --files pyproject.toml uv.lock(OMNIMARKET_SRC=omnimarket@main) — all hooks passReconciliation Note
This is a targeted surgical extension of the OMN-13670 hotfix. The floor change is minimal:
only the cryptography lower-bound is raised (
>=46.0.3→>=48.0.1). uv.lock is relocked.No other files are changed. The migration vendor tree remains in sync with omnimarket main
(the correct comparison base for a main-targeting hotfix).
The node-migration-sync CI check shows a non-fatal diff (omnimarket dev has progressed since
the last main promotion) — this is expected for any main-targeting PR during a period where
dev leads.
node-migration-syncis NOT a required status check for main merge.Post-merge
Prod re-pin (ECR retag + container restart) follows as a separate step, OMN-13418-gated with
fresh CODEOWNERS-approved grant.