Repository navigation
feat(OMN-1547): Replace hardcoded topics with validated suffix constants #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jonahgabriel
merged 7 commits into
main
from
jonah/omn-1547-replace-hardcoded-topics-in-omnibase_infra-with-core-topic
Jan 27, 2026
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b22827b
feat(OMN-1547): Replace hardcoded topics with validated suffix constants
jonahgabriel d9b698f
fix(OMN-1547): Address PR review feedback
jonahgabriel 6d29348
docs(OMN-1547): Add clarifying comments for PR review feedback
jonahgabriel 32d1f57
fix(OMN-1547): Address PR review issues
jonahgabriel cf30bfe
fix(OMN-1547): Add namespace max length validation and export test
jonahgabriel 4f6543b
Merge main and fix PR #206 review issues
jonahgabriel ea67f9d
fix(OMN-1547): Update test to expect fail-fast behavior for session c…
jonahgabriel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| """ONEX Infrastructure Topic Constants. | ||
|
|
||
| This module provides platform-reserved topic suffix constants for ONEX infrastructure | ||
| components. Domain services should NOT import from this module - domain topics should | ||
| be defined in domain contracts. | ||
|
|
||
| Exports: | ||
| Platform topic suffix constants (e.g., SUFFIX_NODE_REGISTRATION) | ||
| ALL_PLATFORM_SUFFIXES: Complete tuple of all platform-reserved suffixes | ||
| build_full_topic: Compose full topic from env, namespace, and suffix | ||
| TopicCompositionError: Error raised when topic composition fails | ||
| """ | ||
|
|
||
| from omnibase_infra.topics.platform_topic_suffixes import ( | ||
| ALL_PLATFORM_SUFFIXES, | ||
| SUFFIX_FSM_STATE_TRANSITIONS, | ||
| SUFFIX_NODE_HEARTBEAT, | ||
| SUFFIX_NODE_INTROSPECTION, | ||
| SUFFIX_NODE_REGISTRATION, | ||
| SUFFIX_REGISTRATION_SNAPSHOTS, | ||
| SUFFIX_REQUEST_INTROSPECTION, | ||
| SUFFIX_RUNTIME_TICK, | ||
| ) | ||
| from omnibase_infra.topics.util_topic_composition import ( | ||
| MAX_NAMESPACE_LENGTH, | ||
| TopicCompositionError, | ||
| build_full_topic, | ||
| ) | ||
|
|
||
| __all__: list[str] = [ | ||
| # Individual suffix constants | ||
| "SUFFIX_NODE_REGISTRATION", | ||
| "SUFFIX_NODE_INTROSPECTION", | ||
| "SUFFIX_NODE_HEARTBEAT", | ||
| "SUFFIX_REQUEST_INTROSPECTION", | ||
| "SUFFIX_FSM_STATE_TRANSITIONS", | ||
| "SUFFIX_RUNTIME_TICK", | ||
| "SUFFIX_REGISTRATION_SNAPSHOTS", | ||
| # Aggregate tuple | ||
| "ALL_PLATFORM_SUFFIXES", | ||
| # Topic composition utilities | ||
| "build_full_topic", | ||
| "TopicCompositionError", | ||
| "MAX_NAMESPACE_LENGTH", | ||
| ] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.