Repository navigation
fix(OMN-12755): preserve workspace root in deploy-runtime - #1889
Conversation
|
Warning Review limit reached
More reviews will be available in 32 minutes and 46 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. 📝 WalkthroughWalkthroughThe PR implements workspace build source support for ChangesWorkspace Build Source and OMNI_HOME Override
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
OMNI_HOMEafter sourcing~/.omnibase/.envso workspace staging/ref capture use the requested rootBUILD_SOURCE/EXPECTED_BUILD_SOURCEbefore staging or builddeploy-runtime.sh --executewhenBUILD_SOURCE=workspaceBUILD_SOURCE,EXPECTED_BUILD_SOURCE, andOMNI_HOMEas explicit Docker build args and print the resolved args via--print-compose-cmdEvidence
bash -n scripts/deploy-runtime.shuv run pytest tests/scripts/test_deploy_runtime_build_context.py tests/scripts/test_deploy_runtime_no_env_file.py -quv run ruff check tests/scripts/test_deploy_runtime_build_context.pyuv run validate-yaml contracts/OMN-12755.yamlgit diff --checkDeploy note
Post-merge workspace-mode runtime validation should run
BUILD_SOURCE=workspace OMNI_HOME=/data/omninode/omni_home bash scripts/deploy-runtime.sh --execute --forceand inspect image provenance/build args for the operator workspace root.No dashboard changes.
Summary by CodeRabbit
New Features
BUILD_SOURCE=workspace.Tests
Chores
Evidence-Source: OCC#2244
Evidence-Ticket: OMN-12755